All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>, Peter Xu <peterx@redhat.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH v3 0/2] s390/mm: shared zeropage + KVM fixes
Date: Thu, 11 Apr 2024 23:56:18 +0200	[thread overview]
Message-ID: <3dbf706f-b6ca-45d7-a293-12aa5807fcdf@redhat.com> (raw)
In-Reply-To: <20240411142827.d5c3bc401c6536bb1315049a@linux-foundation.org>

On 11.04.24 23:28, Andrew Morton wrote:
> On Thu, 11 Apr 2024 18:14:39 +0200 David Hildenbrand <david@redhat.com> wrote:
> 
>> This series fixes one issue with uffd + shared zeropages on s390x and
>> fixes that "ordinary" KVM guests can make use of shared zeropages again.
>>
>> ...
>>
>> Without the shared zeropage, during (2), the VM would suddenly consume
>> 100 GiB on the migration source and destination. On the migration source,
>> where we don't excpect memory overcommit, we could easilt end up crashing
>> the VM during migration.
>>
>> Independent of that, memory handed back to the hypervisor using "free page
>> reporting" would end up consuming actual memory after the migration on the
>> destination, not getting freed up until reused+freed again.
>>
> 
> Is a backport desirable?
> 
> If so, the [1/2] Fixes dates back to 2015 and the [2/2] Fixes is from
> 2017.  Is it appropriate that the patches be backported so far back,
> and into different kernel versions?
> 

[2/2] won't be easy to backport to kernels without FAULT_FLAG_UNSHARE, 
so I wouldn't really suggest backports to kernels before that. [1/2] 
might be reasonable to backport, but might require some tweaking (page 
vs. folio).

-- 
Cheers,

David / dhildenb


  reply	other threads:[~2024-04-11 21:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11 16:14 [PATCH v3 0/2] s390/mm: shared zeropage + KVM fixes David Hildenbrand
2024-04-11 16:14 ` [PATCH v3 1/2] mm/userfaultfd: don't place zeropages when zeropages are disallowed David Hildenbrand
2024-04-11 16:14 ` [PATCH v3 2/2] s390/mm: re-enable the shared zeropage for !PV and !skeys KVM guests David Hildenbrand
2024-04-11 16:37   ` Alexander Gordeev
2024-04-11 21:09     ` David Hildenbrand
2024-04-15 11:49       ` Christian Borntraeger
2024-04-15 13:14         ` Alexander Gordeev
2024-04-15 18:24   ` Alexander Gordeev
2024-04-15 19:14     ` David Hildenbrand
2024-04-16  6:37       ` Alexander Gordeev
2024-04-16  7:05         ` David Hildenbrand
2024-04-16 12:02         ` Christian Borntraeger
2024-04-16 13:41           ` David Hildenbrand
2024-04-18 13:09             ` Christian Borntraeger
2024-04-11 21:28 ` [PATCH v3 0/2] s390/mm: shared zeropage + KVM fixes Andrew Morton
2024-04-11 21:56   ` David Hildenbrand [this message]
2024-04-12 13:25 ` Alexander Gordeev
2024-04-17 12:46 ` Alexander Gordeev
2024-04-17 12:47   ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3dbf706f-b6ca-45d7-a293-12aa5807fcdf@redhat.com \
    --to=david@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=agordeev@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=borntraeger@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=gerald.schaefer@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=peterx@redhat.com \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.