Re: [PATCH v8 3/9] xen: add bitmap to indicate per-domain state changes

["Jürgen Groß" <jgross@suse.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 848 bytes --]

On 06.03.25 16:41, Jan Beulich wrote:
> On 04.02.2025 12:34, Juergen Gross wrote:
>> @@ -1075,6 +1086,26 @@ static void clear_global_virq_handlers(struct domain *d)
>>       }
>>   }
>>   
>> +struct domain *lock_dom_exc_handler(void)
>> +{
>> +    struct domain *d;
>> +
>> +    d = get_global_virq_handler(VIRQ_DOM_EXC);
> 
> The Arm dom0less crash(es?) found by CI are apparently a result of this possibly
> returning NULL (hardware_domain == NULL). Returning NULL from here also in this
> case (and not just ...
> 
>> +    if ( unlikely(!get_domain(d)) )
>> +        return NULL;
> 
> ... in this one) would at least deal with the use from domain_changed_state(). I
> didn't closely check other uses. Thoughts?
> 
> Jan

Just about to post a patch.

There is one other case where a NULL check is wanted.


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]