From: Jan Beulich <jbeulich@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Michal Orzel" <michal.orzel@amd.com>,
"Julien Grall" <julien@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v8 3/9] xen: add bitmap to indicate per-domain state changes
Date: Thu, 6 Mar 2025 16:41:10 +0100 [thread overview]
Message-ID: <21bd8eff-1583-42a9-baf4-00a495ab7a5b@suse.com> (raw)
In-Reply-To: <20250204113407.16839-4-jgross@suse.com>
On 04.02.2025 12:34, Juergen Gross wrote:
> @@ -1075,6 +1086,26 @@ static void clear_global_virq_handlers(struct domain *d)
> }
> }
>
> +struct domain *lock_dom_exc_handler(void)
> +{
> + struct domain *d;
> +
> + d = get_global_virq_handler(VIRQ_DOM_EXC);
The Arm dom0less crash(es?) found by CI are apparently a result of this possibly
returning NULL (hardware_domain == NULL). Returning NULL from here also in this
case (and not just ...
> + if ( unlikely(!get_domain(d)) )
> + return NULL;
... in this one) would at least deal with the use from domain_changed_state(). I
didn't closely check other uses. Thoughts?
Jan
next prev parent reply other threads:[~2025-03-06 15:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 11:33 [PATCH v8 0/9] remove libxenctrl usage from xenstored Juergen Gross
2025-02-04 11:33 ` [PATCH v8 1/9] xen/events: don't allow binding a global virq from any domain Juergen Gross
2025-03-11 9:35 ` Julien Grall
2025-03-11 9:51 ` Jürgen Groß
2025-03-11 19:04 ` Julien Grall
2025-03-12 7:05 ` Jürgen Groß
2025-02-04 11:34 ` [PATCH v8 2/9] xen/events: allow setting of global virq handler only for unbound virqs Juergen Gross
2025-02-04 11:34 ` [PATCH v8 3/9] xen: add bitmap to indicate per-domain state changes Juergen Gross
2025-03-06 15:41 ` Jan Beulich [this message]
2025-03-06 15:52 ` Jürgen Groß
2025-02-04 11:34 ` [PATCH v8 4/9] xen: add new domctl get_changed_domain Juergen Gross
2025-02-04 11:34 ` [PATCH v8 5/9] tools/libs: add a new libxenmanage library Juergen Gross
2025-02-04 11:34 ` [PATCH v8 6/9] tools/xenstored: use new stable interface instead of libxenctrl Juergen Gross
2025-02-04 11:34 ` [PATCH v8 7/9] docs: update xenstore migration stream definition Juergen Gross
2025-03-11 9:43 ` Julien Grall
2025-03-11 9:58 ` Jürgen Groß
2025-03-11 18:52 ` Julien Grall
2025-02-04 11:34 ` [PATCH v8 8/9] tools/xenstored: use unique_id to identify new domain with same domid Juergen Gross
2025-03-12 17:40 ` Jason Andryuk
2025-03-13 9:52 ` Jürgen Groß
2025-02-04 11:34 ` [PATCH v8 9/9] tools/xenstored: use xenmanage_poll_changed_domain() Juergen Gross
2025-03-12 17:45 ` Jason Andryuk
2025-03-13 9:53 ` Jürgen Groß
2025-02-25 11:10 ` [PATCH v8 0/9] remove libxenctrl usage from xenstored Juergen Gross
2025-03-05 8:23 ` Juergen Gross
2025-03-05 23:32 ` Stefano Stabellini
2025-03-06 13:13 ` Jan Beulich
2025-03-06 13:27 ` Jürgen Groß
2025-03-06 13:53 ` Jan Beulich
2025-03-06 13:56 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21bd8eff-1583-42a9-baf4-00a495ab7a5b@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.