* [PATCH] powerpc: Lack! of! ibm,io-events! not! that! important!
@ 2011-08-01 5:30 Anton Blanchard
2011-08-01 10:29 ` Michael Neuling
0 siblings, 1 reply; 2+ messages in thread
From: Anton Blanchard @ 2011-08-01 5:30 UTC (permalink / raw)
To: benh, paulus; +Cc: linuxppc-dev
The ibm,io-events code is a bit verbose with its error messages.
Reverse the reporting so we only print when we successfully enable
I/O event interrupts.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
Index: linux-powerpc/arch/powerpc/platforms/pseries/io_event_irq.c
===================================================================
--- linux-powerpc.orig/arch/powerpc/platforms/pseries/io_event_irq.c 2011-07-26 08:50:11.291231586 +1000
+++ linux-powerpc/arch/powerpc/platforms/pseries/io_event_irq.c 2011-07-26 08:51:39.992772071 +1000
@@ -212,17 +212,15 @@ static int __init ioei_init(void)
struct device_node *np;
ioei_check_exception_token = rtas_token("check-exception");
- if (ioei_check_exception_token == RTAS_UNKNOWN_SERVICE) {
- pr_warning("IO Event IRQ not supported on this system !\n");
+ if (ioei_check_exception_token == RTAS_UNKNOWN_SERVICE)
return -ENODEV;
- }
+
np = of_find_node_by_path("/event-sources/ibm,io-events");
if (np) {
request_event_sources_irqs(np, ioei_interrupt, "IO_EVENT");
+ pr_info("IBM I/O event interrupts enabled\n");
of_node_put(np);
} else {
- pr_err("io_event_irq: No ibm,io-events on system! "
- "IO Event interrupt disabled.\n");
return -ENODEV;
}
return 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: Lack! of! ibm,io-events! not! that! important!
2011-08-01 5:30 [PATCH] powerpc: Lack! of! ibm,io-events! not! that! important! Anton Blanchard
@ 2011-08-01 10:29 ` Michael Neuling
0 siblings, 0 replies; 2+ messages in thread
From: Michael Neuling @ 2011-08-01 10:29 UTC (permalink / raw)
To: Anton Blanchard; +Cc: paulus, linuxppc-dev
In message <20110801153004.0e8af5df@kryten> you wrote:
>
> The ibm,io-events code is a bit verbose with its error messages.
> Reverse the reporting so we only print when we successfully enable
> I/O event interrupts.
NAK!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Mikey
PS :-)
PPS !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
>
> Index: linux-powerpc/arch/powerpc/platforms/pseries/io_event_irq.c
> ===================================================================
> --- linux-powerpc.orig/arch/powerpc/platforms/pseries/io_event_irq.c 2011-07
-26 08:50:11.291231586 +1000
> +++ linux-powerpc/arch/powerpc/platforms/pseries/io_event_irq.c 2011-07
-26 08:51:39.992772071 +1000
> @@ -212,17 +212,15 @@ static int __init ioei_init(void)
> struct device_node *np;
>
> ioei_check_exception_token = rtas_token("check-exception");
> - if (ioei_check_exception_token == RTAS_UNKNOWN_SERVICE) {
> - pr_warning("IO Event IRQ not supported on this system !\n");
> + if (ioei_check_exception_token == RTAS_UNKNOWN_SERVICE)
> return -ENODEV;
> - }
> +
> np = of_find_node_by_path("/event-sources/ibm,io-events");
> if (np) {
> request_event_sources_irqs(np, ioei_interrupt, "IO_EVENT");
> + pr_info("IBM I/O event interrupts enabled\n");
> of_node_put(np);
> } else {
> - pr_err("io_event_irq: No ibm,io-events on system! "
> - "IO Event interrupt disabled.\n");
> return -ENODEV;
> }
> return 0;
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-01 10:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-01 5:30 [PATCH] powerpc: Lack! of! ibm,io-events! not! that! important! Anton Blanchard
2011-08-01 10:29 ` Michael Neuling
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.