All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaromir Capik <jcapik@redhat.com>
To: Karel Zak <kzak@redhat.com>
Cc: kerolasa@gmail.com, util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH] fdformat: Add new switches -f/--from, -t/--to, -r/--repair
Date: Mon, 8 Sep 2014 13:50:02 -0400 (EDT)	[thread overview]
Message-ID: <2108552981.7794894.1410198602679.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1340617573.25924027.1406633523481.JavaMail.zimbra@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

Hello everyone.

I often re-check my patches few weeks after the push
and that allowed me to find a copy'n'paste issue
in the manual.

The fix is attached.

Thanks for pushing.

Regards,
Jaromir.

--
Jaromir Capik
Red Hat Czech, s.r.o.
Software Engineer / Secondary Arch

Email: jcapik@redhat.com
Web: www.cz.redhat.com
Red Hat Czech s.r.o., Purkynova 99/71, 612 45, Brno, Czech Republic
IC: 27690016 


----- Original Message -----
> From: "Jaromir Capik" <jcapik@redhat.com>
> To: "Karel Zak" <kzak@redhat.com>
> Cc: kerolasa@gmail.com, "util-linux" <util-linux@vger.kernel.org>
> Sent: Tuesday, July 29, 2014 1:32:03 PM
> Subject: Re: [PATCH] fdformat: Add new switches -f/--from, -t/--to, -r/--repair
> 
> Hello guys.
> 
> The reworked patch is attached.
> 
> Please, review once more.
> 
> Thanks,
> Jaromir.
> 
> --
> Jaromir Capik
> Red Hat Czech, s.r.o.
> Software Engineer / Secondary Arch
> 
> Email: jcapik@redhat.com
> Web: www.cz.redhat.com
> Red Hat Czech s.r.o., Purkynova 99/71, 612 45, Brno, Czech Republic
> IC: 27690016
> 

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fdformat-man-copy-n-paste-bug.patch --]
[-- Type: text/x-patch; name=fdformat-man-copy-n-paste-bug.patch, Size: 823 bytes --]

From 540b94d786e2c602b4b99da06cae3c6f81fa1315 Mon Sep 17 00:00:00 2001
From: Jaromir Capik <jcapik@redhat.com>
Date: Mon, 8 Sep 2014 19:42:10 +0200
Subject: [PATCH] fdformat: fixing copy'n'paste issue in the manual

The end track default is media specific, not zero.
---
 disk-utils/fdformat.8 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/disk-utils/fdformat.8 b/disk-utils/fdformat.8
index 797f50f..ae1e530 100644
--- a/disk-utils/fdformat.8
+++ b/disk-utils/fdformat.8
@@ -49,7 +49,7 @@ to load the disk parameters.
 Start at the track \fIN\fR (default is 0).
 .TP
 \fB\-t\fR, \fB\-\-to\fR \fIN\fR
-Stop at the track \fIN\fR (default is 0).
+Stop at the track \fIN\fR.
 .TP
 \fB\-r\fR, \fB\-\-repair\fR \fIN\fR
 Try to repair tracks failed during the verification (max \fIN\fR retries).
-- 
1.9.3


  parent reply	other threads:[~2014-09-08 17:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <844628876.22654954.1406302034993.JavaMail.zimbra@redhat.com>
2014-07-25 15:29 ` [PATCH] fdformat: Add new switches -f/--from, -t/--to, -r/--repair Jaromir Capik
2014-07-26 10:40   ` Sami Kerola
2014-07-28 14:38     ` Jaromir Capik
2014-07-28 15:10       ` Karel Zak
2014-07-28 16:01         ` Jaromir Capik
2014-07-28 19:15           ` Jaromir Capik
2014-07-29 11:32         ` Jaromir Capik
2014-07-29 11:53           ` Karel Zak
2014-09-08 17:50           ` Jaromir Capik [this message]
2014-09-16  9:15             ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2108552981.7794894.1410198602679.JavaMail.zimbra@redhat.com \
    --to=jcapik@redhat.com \
    --cc=kerolasa@gmail.com \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.