Re: [PATCH] fdformat: Add new switches -f/--from, -t/--to, -r/--repair

[Jaromir Capik <jcapik@redhat.com>]

> > > > > + if ((unsigned int)track_from > param.track - 1)
> > > > > + err(EXIT_FAILURE, _("'from' is out of allowed range\n"));
> > > > > + if ((unsigned int)track_to > param.track - 1)
> > > > > + err(EXIT_FAILURE, _("'to' is out of allowed range\n"));
> > > > > + if (track_from > track_to)
> > > > > + err(EXIT_FAILURE, _("'from' is higher than 'to'\n"));
> > > > 
> > > > The err() adds new line to print out, so the messages above will print
> > > > unexpected empty line.
> > > 
> > > This can be completely removed after the change to strtou32_or_err(),
> > > right?
> > 
> >  I guess you still want to check user's input against the hardware, so
> >  check
> >  if track_to is smaller than param.track is correct thing. Right?
> 
> The comparison with the param.track is done elsewhere as we don't know
> the disk parameters during the argument parsing yet.
> We get the parameters after finishing the argument parsing.

Sorry, I overlooked and thought you're writing about the argument
parsing. Of course, this needs to be preserved.

I've reworked the patch, but I'll send it after doing few tests at home.

J.