Re: [ammarfaizi2-block:palmer/linux/riscv-zicbom 6/6] arch/riscv/include/asm/errata_list.h:128:9: error: expected ':' or ')' before '__nops'

[Heiko Stübner <heiko@sntech.de>]

[-- Attachment #1: Type: text/plain, Size: 3081 bytes --]

Hi,

Am Donnerstag, 4. August 2022, 22:47:29 CEST schrieb kernel test robot:
> tree:   https://github.com/ammarfaizi2/linux-block palmer/linux/riscv-zicbom
> head:   d20ec7529236a2fcdb2d856fc0bd80b409a217fc
> commit: d20ec7529236a2fcdb2d856fc0bd80b409a217fc [6/6] riscv: implement cache-management errata for T-Head SoCs
> config: riscv-randconfig-r035-20220804 (https://download.01.org/0day-ci/archive/20220805/202208050445.jnUp8dLc-lkp(a)intel.com/config)
> compiler: riscv64-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/ammarfaizi2/linux-block/commit/d20ec7529236a2fcdb2d856fc0bd80b409a217fc
>         git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
>         git fetch --no-tags ammarfaizi2-block palmer/linux/riscv-zicbom
>         git checkout d20ec7529236a2fcdb2d856fc0bd80b409a217fc
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/mm/ kernel/dma/
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from arch/riscv/include/asm/alternative.h:11,
>                     from arch/riscv/include/asm/errata_list.h:8,
>                     from arch/riscv/include/asm/tlbflush.h:12,
>                     from arch/riscv/include/asm/pgtable.h:108,
>                     from arch/riscv/include/asm/uaccess.h:12,
>                     from include/linux/uaccess.h:11,
>                     from include/linux/sched/task.h:11,
>                     from include/linux/sched/signal.h:9,
>                     from include/linux/rcuwait.h:6,
>                     from include/linux/percpu-rwsem.h:7,
>                     from include/linux/fs.h:33,
>                     from include/linux/compat.h:17,
>                     from arch/riscv/include/asm/elf.h:12,
>                     from include/linux/elf.h:6,
>                     from include/linux/module.h:19,
>                     from include/linux/device/driver.h:21,
>                     from include/linux/device.h:32,
>                     from include/linux/dma-mapping.h:7,
>                     from include/linux/dma-direct.h:9,
>                     from arch/riscv/mm/dma-noncoherent.c:8:
>    arch/riscv/mm/dma-noncoherent.c: In function 'arch_sync_dma_for_device':
> >> arch/riscv/include/asm/errata_list.h:128:9: error: expected ':' or ')' before '__nops'
>      128 |         __nops(6),                                                      \

As the error suggests, the zicbom assembly uses the newly introduced nops
macros for better readability, so I guess in Palmer's tree they should sit
on top of the riscv-nops branch.

Heiko