From: Heiko Stuebner <heiko@sntech.de>
To: khilman@kernel.org
Cc: nm@ti.com, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH] PM / AVS: rockchip-io: fix the supply naming for the emmc supply on px30
Date: Sun, 23 Feb 2020 16:09:18 +0100 [thread overview]
Message-ID: <2116646.O5uUgpsMTn@phil> (raw)
In-Reply-To: <20200121222859.4069263-1-heiko@sntech.de>
Hi,
Am Dienstag, 21. Januar 2020, 23:28:59 CET schrieb Heiko Stuebner:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The supply going to the emmc/flash is named vccio6, not vccio0 and while
> the code does this correctly already, the comments and error output do not.
>
> So just change these values to the correct ones.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
oh so gently ping on this tiny patch ;-)
Thanks for considering
Heiko
> ---
> drivers/power/avs/rockchip-io-domain.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/avs/rockchip-io-domain.c b/drivers/power/avs/rockchip-io-domain.c
> index 398fc954419e..eece97f97ef8 100644
> --- a/drivers/power/avs/rockchip-io-domain.c
> +++ b/drivers/power/avs/rockchip-io-domain.c
> @@ -152,18 +152,18 @@ static void px30_iodomain_init(struct rockchip_iodomain *iod)
> int ret;
> u32 val;
>
> - /* if no VCCIO0 supply we should leave things alone */
> + /* if no VCCIO6 supply we should leave things alone */
> if (!iod->supplies[PX30_IO_VSEL_VCCIO6_SUPPLY_NUM].reg)
> return;
>
> /*
> - * set vccio0 iodomain to also use this framework
> + * set vccio6 iodomain to also use this framework
> * instead of a special gpio.
> */
> val = PX30_IO_VSEL_VCCIO6_SRC | (PX30_IO_VSEL_VCCIO6_SRC << 16);
> ret = regmap_write(iod->grf, PX30_IO_VSEL, val);
> if (ret < 0)
> - dev_warn(iod->dev, "couldn't update vccio0 ctrl\n");
> + dev_warn(iod->dev, "couldn't update vccio6 ctrl\n");
> }
>
> static void rk3288_iodomain_init(struct rockchip_iodomain *iod)
>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: khilman@kernel.org
Cc: nm@ti.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH] PM / AVS: rockchip-io: fix the supply naming for the emmc supply on px30
Date: Sun, 23 Feb 2020 16:09:18 +0100 [thread overview]
Message-ID: <2116646.O5uUgpsMTn@phil> (raw)
In-Reply-To: <20200121222859.4069263-1-heiko@sntech.de>
Hi,
Am Dienstag, 21. Januar 2020, 23:28:59 CET schrieb Heiko Stuebner:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The supply going to the emmc/flash is named vccio6, not vccio0 and while
> the code does this correctly already, the comments and error output do not.
>
> So just change these values to the correct ones.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
oh so gently ping on this tiny patch ;-)
Thanks for considering
Heiko
> ---
> drivers/power/avs/rockchip-io-domain.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/avs/rockchip-io-domain.c b/drivers/power/avs/rockchip-io-domain.c
> index 398fc954419e..eece97f97ef8 100644
> --- a/drivers/power/avs/rockchip-io-domain.c
> +++ b/drivers/power/avs/rockchip-io-domain.c
> @@ -152,18 +152,18 @@ static void px30_iodomain_init(struct rockchip_iodomain *iod)
> int ret;
> u32 val;
>
> - /* if no VCCIO0 supply we should leave things alone */
> + /* if no VCCIO6 supply we should leave things alone */
> if (!iod->supplies[PX30_IO_VSEL_VCCIO6_SUPPLY_NUM].reg)
> return;
>
> /*
> - * set vccio0 iodomain to also use this framework
> + * set vccio6 iodomain to also use this framework
> * instead of a special gpio.
> */
> val = PX30_IO_VSEL_VCCIO6_SRC | (PX30_IO_VSEL_VCCIO6_SRC << 16);
> ret = regmap_write(iod->grf, PX30_IO_VSEL, val);
> if (ret < 0)
> - dev_warn(iod->dev, "couldn't update vccio0 ctrl\n");
> + dev_warn(iod->dev, "couldn't update vccio6 ctrl\n");
> }
>
> static void rk3288_iodomain_init(struct rockchip_iodomain *iod)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-23 15:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 22:28 [PATCH] PM / AVS: rockchip-io: fix the supply naming for the emmc supply on px30 Heiko Stuebner
2020-01-21 22:28 ` Heiko Stuebner
2020-02-23 15:09 ` Heiko Stuebner [this message]
2020-02-23 15:09 ` Heiko Stuebner
2020-03-11 21:45 ` Kevin Hilman
2020-03-11 21:45 ` Kevin Hilman
2020-03-11 21:45 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2116646.O5uUgpsMTn@phil \
--to=heiko@sntech.de \
--cc=christoph.muellner@theobroma-systems.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.