[U-Boot-Users] A Shared flash.c

[U-Boot-Users] A Shared flash.c

[Stephen Williams]

The JSE board (PPC405GPr) I'm working on has an 8-bit flash
that is attached to the local bus, and I find that the flash.c
from board/walnut405 is almost identical. (I just needed to add
a case for a different chip vendor.) Would it make sense to
move more of its contents to common/flash.c? For example,
the flash_printinfo function seems like a candidate.

Would patches to that effect be accepted?
-- 
Steve Williams                "The woods are lovely, dark and deep.
steve at XXXXXXXXXX           But I have promises to keep,
http://www.XXXXXXXXXX         and lines to code before I sleep,
http://www.picturel.com       And lines to code before I sleep."

[U-Boot-Users] A Shared flash.c

[Wolfgang Denk]

In message <21181-51126@sneakemail.com> you wrote:
> 
> The JSE board (PPC405GPr) I'm working on has an 8-bit flash
> that is attached to the local bus, and I find that the flash.c
> from board/walnut405 is almost identical. (I just needed to add
> a case for a different chip vendor.) Would it make sense to
> move more of its contents to common/flash.c? For example,

It would make no sense, since there are  about  137  other  "flash.c"
files which are not at all identical.

> the flash_printinfo function seems like a candidate.

It ain't. Just compare a 5 or ten of the other flash drivers.

> Would patches to that effect be accepted?

Probably not. Except you can convince me that it is possible.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Any technology distinguishable from magic is insufficiently advanced.