All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Yaozhong Li <yaozhonguwl@gmail.com>,
	Shawn Lin <shawn.lin@rock-chips.com>
Cc: shawn.lin@rock-chips.com, Rob Herring <robh@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: enable SD UHS-I on Firefly-RK3399
Date: Sun, 01 Nov 2026 18:55:25 +0100	[thread overview]
Message-ID: <2120863.kXSN5OTJKJ@phil> (raw)
In-Reply-To: <b8221ba4-dccb-42f5-ae77-a6c087fa1d05@rock-chips.com>

Am Sonntag, 1. November 2026, 17:10:04 Mitteleuropäische Normalzeit schrieb Shawn Lin:
> 在 2026/09/22 星期二 13:50, Yaozhong Li 写道:
> > The SD slot on this board stays at 50 MHz with 3.3V signalling. The
> 
> ...
> 
> > 
> > I have no schematic for this board. The claim about what LDO4 feeds
> > rests on the vendor firmware device tree plus the measurements above.
> > 
> 
> It's easy to find one:
> https://github.com/armbian/armbian.github.io/blob/main/board-schematics/firefly-rk3399.pdf
> 
> Too bad it was designed this way! What if sdio-wifi is working on UHS
> modebut people insert a HighSpeed only sd card?

Hmm, when I read the schematics correctly, all parts of the sdio + wifi
supplied by vcc_1v8 (both APIO3_VDD_1V8 and also vddio of the wifi module
itself), while vcc_sdio only supplies SDMMC0_VDD?


Yaozhong Li: please trim that commit message down a lot, it doesn't
have to be novel size please.


Heiko

> 
> > The analysis and the commit message were drafted with the help of an
> > LLM-based assistant (Claude Code), cross-reviewed with a second one
> > (OpenAI Codex). The device tree change, the measurements and the final
> > wording are mine.
> > 
> >   arch/arm64/boot/dts/rockchip/rk3399-firefly.dts | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
> > index 0568dfa..7cabbc1 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
> > @@ -777,7 +777,6 @@ &sdio0 {
> >   
> >   	/* Power supply */
> >   	vqmmc-supply = <&vcc1v8_s3>;	/* IO line */
> > -	vmmc-supply = <&vcc_sdio>;	/* card's power */
> >   
> >   	#address-cells = <1>;
> >   	#size-cells = <0>;
> > @@ -804,6 +803,8 @@ &sdmmc {
> >   	max-frequency = <150000000>;
> >   	pinctrl-names = "default";
> >   	pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>;
> > +	sd-uhs-sdr104;
> > +	vqmmc-supply = <&vcc_sdio>;
> >   	status = "okay";
> >   };
> >   
> > 
> > base-commit: 940de590b839f71d6dc846160534bf202401b8b7
> 
> 






WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Yaozhong Li <yaozhonguwl@gmail.com>,
	Shawn Lin <shawn.lin@rock-chips.com>
Cc: shawn.lin@rock-chips.com, Rob Herring <robh@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: enable SD UHS-I on Firefly-RK3399
Date: Sun, 01 Nov 2026 18:55:25 +0100	[thread overview]
Message-ID: <2120863.kXSN5OTJKJ@phil> (raw)
In-Reply-To: <b8221ba4-dccb-42f5-ae77-a6c087fa1d05@rock-chips.com>

Am Sonntag, 1. November 2026, 17:10:04 Mitteleuropäische Normalzeit schrieb Shawn Lin:
> 在 2026/09/22 星期二 13:50, Yaozhong Li 写道:
> > The SD slot on this board stays at 50 MHz with 3.3V signalling. The
> 
> ...
> 
> > 
> > I have no schematic for this board. The claim about what LDO4 feeds
> > rests on the vendor firmware device tree plus the measurements above.
> > 
> 
> It's easy to find one:
> https://github.com/armbian/armbian.github.io/blob/main/board-schematics/firefly-rk3399.pdf
> 
> Too bad it was designed this way! What if sdio-wifi is working on UHS
> modebut people insert a HighSpeed only sd card?

Hmm, when I read the schematics correctly, all parts of the sdio + wifi
supplied by vcc_1v8 (both APIO3_VDD_1V8 and also vddio of the wifi module
itself), while vcc_sdio only supplies SDMMC0_VDD?


Yaozhong Li: please trim that commit message down a lot, it doesn't
have to be novel size please.


Heiko

> 
> > The analysis and the commit message were drafted with the help of an
> > LLM-based assistant (Claude Code), cross-reviewed with a second one
> > (OpenAI Codex). The device tree change, the measurements and the final
> > wording are mine.
> > 
> >   arch/arm64/boot/dts/rockchip/rk3399-firefly.dts | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
> > index 0568dfa..7cabbc1 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
> > @@ -777,7 +777,6 @@ &sdio0 {
> >   
> >   	/* Power supply */
> >   	vqmmc-supply = <&vcc1v8_s3>;	/* IO line */
> > -	vmmc-supply = <&vcc_sdio>;	/* card's power */
> >   
> >   	#address-cells = <1>;
> >   	#size-cells = <0>;
> > @@ -804,6 +803,8 @@ &sdmmc {
> >   	max-frequency = <150000000>;
> >   	pinctrl-names = "default";
> >   	pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>;
> > +	sd-uhs-sdr104;
> > +	vqmmc-supply = <&vcc_sdio>;
> >   	status = "okay";
> >   };
> >   
> > 
> > base-commit: 940de590b839f71d6dc846160534bf202401b8b7
> 
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2026-11-01 17:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22  5:50 [PATCH] arm64: dts: rockchip: enable SD UHS-I on Firefly-RK3399 Yaozhong Li
2026-09-22  5:50 ` Yaozhong Li
2026-11-01 15:44 ` Yaozhong Li
2026-11-01 15:44   ` Yaozhong Li
2026-11-02 14:02   ` Heiko Stübner
2026-11-02 14:02     ` Heiko Stübner
2026-11-01 16:10 ` Shawn Lin
2026-11-01 16:10   ` Shawn Lin
2026-11-01 17:55   ` Heiko Stuebner [this message]
2026-11-01 17:55     ` Heiko Stuebner
2026-11-02  1:06     ` Shawn Lin
2026-11-02  1:06       ` Shawn Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2120863.kXSN5OTJKJ@phil \
    --to=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=yaozhonguwl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.