From: "Guðni Már Gilbert" <gudnimar@noxmedical.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] python3-manifest: prune python3-core
Date: Wed, 01 May 2024 17:50:01 -0700 [thread overview]
Message-ID: <2135.1714611001880482361@lists.openembedded.org> (raw)
In-Reply-To: <CANx9H-BtxHrpWuRC7uobB1s3m4Pd3XPRLOEX_R7YVpCTiOQ0dA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1446 bytes --]
On Wed, May 1, 2024 at 11:27 PM, Tim Orling wrote:
>
> This manifest is automatically generated by:
> https://git.yoctoproject.org/poky/tree/meta/recipes-devtools/python/python3/create_manifest3.py
>
>
> We do not want to be making manual changes to the json file. If there are
> mistakes due to changes in what is now shipped with Python 3.12.x, we
> should be fixing in the tooling, not this file.
>
Using the script was my first approach, but I found out that the script doesn't prune the core package and is essentially expecting that the core is already set up correctly in the manifest file. Only items are appended to the core, items are never removed as far as I could see.
This could certainly be improved and I made an attempt but could not finish it today. I'd be happy to look into it when I find time.
>
> Also, please share your local QA tooling. It does no one any good to have
> that be siloed
>
What I have so far is to insert the warning in this line: https://github.com/openembedded/openembedded-core/blob/914128f6bd988cde278e087fb9457a0c70c7e5ec/meta/lib/oe/package.py#L1343 and adding the following two lines:
msg = f "FILES variable for package { pkg } contains ' { file } ' but was not found. \n "
oe.qa.handle_error( "files-not-found" , msg , d )
before the 'continue' statement.
I also added "files-not-found" to WARN_QA in insane.class just like how "files-invalid" is handled
[-- Attachment #2: Type: text/html, Size: 2246 bytes --]
next prev parent reply other threads:[~2024-05-02 0:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 21:27 [PATCH] python3-manifest: prune python3-core Guðni Már Gilbert
2024-05-01 23:27 ` [OE-core] " Tim Orling
2024-05-02 0:50 ` Guðni Már Gilbert [this message]
2024-05-05 11:41 ` Guðni Már Gilbert
-- strict thread matches above, loose matches on Subject: below --
2024-05-01 21:16 Guðni Már Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2135.1714611001880482361@lists.openembedded.org \
--to=gudnimar@noxmedical.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.