From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
Misael Lopez Cruz <misael.lopez@ti.com>
Subject: Re: [PATCH] ASoC: twl6040: Workaround for headset DC offset caused pop noise
Date: Wed, 12 Oct 2011 11:55:15 +0300 [thread overview]
Message-ID: <2135466.UdidpbexSR@barack> (raw)
In-Reply-To: <1362600.vrF78ASdYQ@barack>
On Wednesday 12 October 2011 11:18:50 Péter Ujfalusi wrote:
> > This sounds like you should be using a supply widget to do the reference
> > counting here?
>
> Probably it is better to move the whole thing to be handled by a supply
> widget (attached to the HS DACs).
> It will not mess up the sequence, and I'm not going to need to count in the
> driver.
> Will rewrite the patch.
I can not move the HS DAC power on/off to be handled by a supply widget...
Refcounting in a supply widget will not work for the power down, since the
supply widget will be turned off after the DAC widget. At time when the DAC
receives the PMD event the attached supply is still on.
I can update the commit message to explicitly say that we need to turn on both
HS DAC at the same time, and we need to turn tem off at the same time.
--
Péter
next prev parent reply other threads:[~2011-10-12 8:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 11:00 [PATCH] ASoC: twl6040: Workaround for headset DC offset caused pop noise Peter Ujfalusi
2011-10-11 13:29 ` Mark Brown
2011-10-12 8:18 ` Péter Ujfalusi
2011-10-12 8:55 ` Péter Ujfalusi [this message]
2011-10-12 9:46 ` Mark Brown
2011-10-12 10:45 ` Péter Ujfalusi
2011-10-12 10:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2135466.UdidpbexSR@barack \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.