All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
	Misael Lopez Cruz <misael.lopez@ti.com>
Subject: Re: [PATCH] ASoC: twl6040: Workaround for headset DC offset caused pop noise
Date: Wed, 12 Oct 2011 13:45:33 +0300	[thread overview]
Message-ID: <5817000.NdMGYPik3n@barack> (raw)
In-Reply-To: <20111012094625.GA3647@opensource.wolfsonmicro.com>

On Wednesday 12 October 2011 10:46:25 Mark Brown wrote:
> On Wed, Oct 12, 2011 at 11:55:15AM +0300, Péter Ujfalusi wrote:
> > I can not move the HS DAC power on/off to be handled by a supply
> > widget... Refcounting in a supply widget will not work for the power
> > down, since the supply widget will be turned off after the DAC widget.
> > At time when the DAC receives the PMD event the attached supply is
> > still on.
> > I can update the commit message to explicitly say that we need to turn
> > on both HS DAC at the same time, and we need to turn tem off at the
> > same time.
> I still don't understand what the problem is.  If nothing else you can
> do random register writes from an event on a supply widget...

I still have the code for the out of order McPDM shutdown which is using a 
supply widget attached to the codec's DAC/ADC.
The ordering of the two supply is not written in stone when both are attached 
to the same DAC.
Yes, I'm evaluating the possibility of the reordering the shutdown sequence in 
the core as you have suggested a while back. 

For this patch: I will merge the two DAC to one, and handle both of them in a 
single DAC widget. I have tested this and works fine.

--
Péter

  reply	other threads:[~2011-10-12 10:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-11 11:00 [PATCH] ASoC: twl6040: Workaround for headset DC offset caused pop noise Peter Ujfalusi
2011-10-11 13:29 ` Mark Brown
2011-10-12  8:18   ` Péter Ujfalusi
2011-10-12  8:55     ` Péter Ujfalusi
2011-10-12  9:46       ` Mark Brown
2011-10-12 10:45         ` Péter Ujfalusi [this message]
2011-10-12 10:48           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5817000.NdMGYPik3n@barack \
    --to=peter.ujfalusi@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    --cc=misael.lopez@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.