All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	linux-sh@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: sh-pfc: Remove r8a73a4 platform_device_id entry
Date: Wed, 29 Apr 2015 14:53:22 +0300	[thread overview]
Message-ID: <21370155.oZX1erNtOU@avalon> (raw)
In-Reply-To: <1430216107-31501-2-git-send-email-geert+renesas@glider.be>

Hi Geert,

Thank you for the patch.

On Tuesday 28 April 2015 12:15:07 Geert Uytterhoeven wrote:
> As of commit 9d07d414d4c33d86 ("ARM: shmobile: r8a73a4: ape6evm: Remove
> legacy platform"), r8a73a4 is only supported in generic DT-only ARM
> multi-platform builds.  The driver doesn't need to match platform
> devices by name anymore, hence remove the corresponding
> platform_device_id entry.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/pinctrl/sh-pfc/core.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/sh-pfc/core.c b/drivers/pinctrl/sh-pfc/core.c
> index 7b2c9495c3832410..287a3d048a5e1cf9 100644
> --- a/drivers/pinctrl/sh-pfc/core.c
> +++ b/drivers/pinctrl/sh-pfc/core.c
> @@ -579,9 +579,6 @@ static int sh_pfc_remove(struct platform_device *pdev)
>  }
> 
>  static const struct platform_device_id sh_pfc_id_table[] = {
> -#ifdef CONFIG_PINCTRL_PFC_R8A73A4
> -	{ "pfc-r8a73a4", (kernel_ulong_t)&r8a73a4_pinmux_info },
> -#endif
>  #ifdef CONFIG_PINCTRL_PFC_R8A7740
>  	{ "pfc-r8a7740", (kernel_ulong_t)&r8a7740_pinmux_info },
>  #endif

-- 
Regards,

Laurent Pinchart


WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	linux-sh@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: sh-pfc: Remove r8a73a4 platform_device_id entry
Date: Wed, 29 Apr 2015 11:53:22 +0000	[thread overview]
Message-ID: <21370155.oZX1erNtOU@avalon> (raw)
In-Reply-To: <1430216107-31501-2-git-send-email-geert+renesas@glider.be>

Hi Geert,

Thank you for the patch.

On Tuesday 28 April 2015 12:15:07 Geert Uytterhoeven wrote:
> As of commit 9d07d414d4c33d86 ("ARM: shmobile: r8a73a4: ape6evm: Remove
> legacy platform"), r8a73a4 is only supported in generic DT-only ARM
> multi-platform builds.  The driver doesn't need to match platform
> devices by name anymore, hence remove the corresponding
> platform_device_id entry.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/pinctrl/sh-pfc/core.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/sh-pfc/core.c b/drivers/pinctrl/sh-pfc/core.c
> index 7b2c9495c3832410..287a3d048a5e1cf9 100644
> --- a/drivers/pinctrl/sh-pfc/core.c
> +++ b/drivers/pinctrl/sh-pfc/core.c
> @@ -579,9 +579,6 @@ static int sh_pfc_remove(struct platform_device *pdev)
>  }
> 
>  static const struct platform_device_id sh_pfc_id_table[] = {
> -#ifdef CONFIG_PINCTRL_PFC_R8A73A4
> -	{ "pfc-r8a73a4", (kernel_ulong_t)&r8a73a4_pinmux_info },
> -#endif
>  #ifdef CONFIG_PINCTRL_PFC_R8A7740
>  	{ "pfc-r8a7740", (kernel_ulong_t)&r8a7740_pinmux_info },
>  #endif

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2015-04-29 11:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28 10:15 [PATCH 1/2] pinctrl: sh-pfc: r8a73a4: Remove obsolete multi-platform check Geert Uytterhoeven
2015-04-28 10:15 ` Geert Uytterhoeven
2015-04-28 10:15 ` [PATCH 2/2] pinctrl: sh-pfc: Remove r8a73a4 platform_device_id entry Geert Uytterhoeven
2015-04-28 10:15   ` Geert Uytterhoeven
2015-04-29 11:53   ` Laurent Pinchart [this message]
2015-04-29 11:53     ` Laurent Pinchart
2015-04-30  5:50   ` Simon Horman
2015-04-30  5:50     ` Simon Horman
2015-05-12  7:28   ` Linus Walleij
2015-05-12  7:28     ` Linus Walleij
2015-04-29 11:53 ` [PATCH 1/2] pinctrl: sh-pfc: r8a73a4: Remove obsolete multi-platform check Laurent Pinchart
2015-04-29 11:53   ` Laurent Pinchart
2015-05-12 10:29 ` Linus Walleij
2015-05-12 10:29   ` Linus Walleij
  -- strict thread matches above, loose matches on Subject: below --
2015-04-28 10:14 Geert Uytterhoeven
2015-04-28 10:14 ` Geert Uytterhoeven
2015-04-30  5:49 ` Simon Horman
2015-04-30  5:49   ` Simon Horman
2015-05-12  7:26 ` Linus Walleij
2015-05-12  7:26   ` Linus Walleij
2015-05-12  7:45   ` Geert Uytterhoeven
2015-05-12  7:45     ` Geert Uytterhoeven
2015-05-14  0:49   ` Simon Horman
2015-05-14  0:49     ` Simon Horman
2015-05-14 10:23     ` Linus Walleij
2015-05-14 10:23       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21370155.oZX1erNtOU@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=geert+renesas@glider.be \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.