All of lore.kernel.org
 help / color / mirror / Atom feed
From: "André Paiusco" <andre.paiusco@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH v4] ydotool: Add new package
Date: Thu, 07 Mar 2024 22:35:03 -0800	[thread overview]
Message-ID: <21393.1709879703135556993@lists.openembedded.org> (raw)
In-Reply-To: <CAMKF1sq8qy4zA53gTgFq2FZpZ9zvbNjpPY3DnycOVN=yFvW2xA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

Hello,

Two things:

First, I had a patch that I forgot to add to this, where I make the ydotoold.service be installed as a system service instead of a user service, otherwise the rootfs recipe fails as it can't enable it. I'd like suggestions to what you feel better. Sorry for missing that. If there's a more generic option for systemd user services, let me know.  
One option is: have a patch that whenever we have systemd as a dependency, we install it as system service and not user service.  
Another option is: disable the service by default, with that I can disable the hard dependency as mentioned above (seems to work just fine)

> this is an unterminated string, bitbake would have told you during
> parsing. Please test the bits before sending for review.
> It saves time.

I have no idea how this went through as last time I was only changing the packagegroup, sorry.

[-- Attachment #2: Type: text/html, Size: 956 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: "André Paiusco" <andre.paiusco@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH v4] ydotool: Add new package
Date: Thu, 07 Mar 2024 23:07:17 -0800	[thread overview]
Message-ID: <21393.1709879703135556993@lists.openembedded.org> (raw)
Message-ID: <20240308070717.SSHE16lS1Cl_SaF4y9vcSNqqJX3b5Tov0xJfM0ZQGcs@z> (raw)
In-Reply-To: <CAMKF1sq8qy4zA53gTgFq2FZpZ9zvbNjpPY3DnycOVN=yFvW2xA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]

Hello,

Two things:

First, I had a patch that I forgot to add to this, where I make the ydotoold.service be installed as a system service instead of a user service, otherwise the rootfs recipe fails as it can't enable it. I'd like suggestions to what you feel better. Sorry for missing that. If there's a more generic option for systemd user services, let me know.  
One option is: have a patch that whenever we have systemd as a dependency, we install it as system service and not user service.  
Another option is: disable the service by default, with that I can remove the hard dependency as mentioned above (seems to work just fine)

> this is an unterminated string, bitbake would have told you during
> parsing. Please test the bits before sending for review.
> It saves time.

I have no idea how this went through as last time I was only changing the packagegroup, sorry.

---- 
Edit: 
I'm sending a new patch version (v5) applying the second option, just tested, and it works fine, the only downside is the need to manually having to enable the service. If we disagree, I can implement the fixes on top of that one.

[-- Attachment #2: Type: text/html, Size: 1211 bytes --]

  reply	other threads:[~2024-03-08  6:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07 20:07 [PATCH v4] ydotool: Add new package Andre Paiusco
2024-03-07 22:40 ` [oe] " Ross Burton
2024-03-08  1:31 ` Khem Raj
2024-03-08  6:35   ` André Paiusco [this message]
2024-03-08  7:07     ` André Paiusco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21393.1709879703135556993@lists.openembedded.org \
    --to=andre.paiusco@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.