From: Heiner Kallweit <hkallweit1@gmail.com>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
Damien Le Moal <dlemoal@kernel.org>,
Niklas Cassel <cassel@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-ide@vger.kernel.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: [PATCH 2/2] PCI: Remove pci_enable_device_io()
Date: Sat, 23 Mar 2024 18:16:36 +0100 [thread overview]
Message-ID: <213ebf62-53a3-42b7-8518-ecd5cd6d6b08@gmail.com> (raw)
In-Reply-To: <370ff61c-1ae0-41ca-95fc-6c45e1b8791d@gmail.com>
After the last user was removed, remove this PCI core function.
It's very unlikely that we'll see a new device requiring
io space access, even though memory space access is supported.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/pci/pci.c | 14 --------------
include/linux/pci.h | 1 -
2 files changed, 15 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index e5f243dd4..a26d00bf1 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -2110,20 +2110,6 @@ static int pci_enable_device_flags(struct pci_dev *dev, unsigned long flags)
return err;
}
-/**
- * pci_enable_device_io - Initialize a device for use with IO space
- * @dev: PCI device to be initialized
- *
- * Initialize device before it's used by a driver. Ask low-level code
- * to enable I/O resources. Wake up the device if it was suspended.
- * Beware, this function can fail.
- */
-int pci_enable_device_io(struct pci_dev *dev)
-{
- return pci_enable_device_flags(dev, IORESOURCE_IO);
-}
-EXPORT_SYMBOL(pci_enable_device_io);
-
/**
* pci_enable_device_mem - Initialize a device for use with Memory space
* @dev: PCI device to be initialized
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 16493426a..ba1275778 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1315,7 +1315,6 @@ int pci_user_write_config_word(struct pci_dev *dev, int where, u16 val);
int pci_user_write_config_dword(struct pci_dev *dev, int where, u32 val);
int __must_check pci_enable_device(struct pci_dev *dev);
-int __must_check pci_enable_device_io(struct pci_dev *dev);
int __must_check pci_enable_device_mem(struct pci_dev *dev);
int __must_check pci_reenable_device(struct pci_dev *);
int __must_check pcim_enable_device(struct pci_dev *pdev);
--
2.44.0
next prev parent reply other threads:[~2024-03-23 17:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 17:13 [PATCH 0/2] PCI: Remove pci_enable_device_io() Heiner Kallweit
2024-03-23 17:14 ` [PATCH 1/2] ata: pata_cs5520: Remove not needed call to pci_enable_device_io Heiner Kallweit
2024-03-23 17:43 ` Sergey Shtylyov
2024-03-25 7:57 ` Damien Le Moal
2024-03-23 17:16 ` Heiner Kallweit [this message]
2024-03-25 7:58 ` [PATCH 2/2] PCI: Remove pci_enable_device_io() Damien Le Moal
2024-03-28 22:13 ` [PATCH 0/2] " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=213ebf62-53a3-42b7-8518-ecd5cd6d6b08@gmail.com \
--to=hkallweit1@gmail.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.