From: Heiner Kallweit <hkallweit1@gmail.com>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
Damien Le Moal <dlemoal@kernel.org>,
Niklas Cassel <cassel@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-ide@vger.kernel.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: [PATCH 1/2] ata: pata_cs5520: Remove not needed call to pci_enable_device_io
Date: Sat, 23 Mar 2024 18:14:45 +0100 [thread overview]
Message-ID: <5068d0ce-2140-4d3f-b305-e8f0d61eed1f@gmail.com> (raw)
In-Reply-To: <370ff61c-1ae0-41ca-95fc-6c45e1b8791d@gmail.com>
A few lines earlier pcim_enable_device() is called, which includes
the functionality of pci_enable_device_io(). Therefore we can safely
remove the call to pci_enable_device_io().
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/ata/pata_cs5520.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/ata/pata_cs5520.c b/drivers/ata/pata_cs5520.c
index 38795508c..027cf6710 100644
--- a/drivers/ata/pata_cs5520.c
+++ b/drivers/ata/pata_cs5520.c
@@ -151,12 +151,6 @@ static int cs5520_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
if (!host)
return -ENOMEM;
- /* Perform set up for DMA */
- if (pci_enable_device_io(pdev)) {
- dev_err(&pdev->dev, "unable to configure BAR2.\n");
- return -ENODEV;
- }
-
if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32))) {
dev_err(&pdev->dev, "unable to configure DMA mask.\n");
return -ENODEV;
--
2.44.0
next prev parent reply other threads:[~2024-03-23 17:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 17:13 [PATCH 0/2] PCI: Remove pci_enable_device_io() Heiner Kallweit
2024-03-23 17:14 ` Heiner Kallweit [this message]
2024-03-23 17:43 ` [PATCH 1/2] ata: pata_cs5520: Remove not needed call to pci_enable_device_io Sergey Shtylyov
2024-03-25 7:57 ` Damien Le Moal
2024-03-23 17:16 ` [PATCH 2/2] PCI: Remove pci_enable_device_io() Heiner Kallweit
2024-03-25 7:58 ` Damien Le Moal
2024-03-28 22:13 ` [PATCH 0/2] " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5068d0ce-2140-4d3f-b305-e8f0d61eed1f@gmail.com \
--to=hkallweit1@gmail.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.