* Re: [RFC PATCH] arm64: dts: rockchip: add core devicetree for rk3318
@ 2020-04-17 11:05 ` Heiko Stuebner
0 siblings, 0 replies; 9+ messages in thread
From: Heiko Stuebner @ 2020-04-17 11:05 UTC (permalink / raw)
To: Johan Jonker
Cc: robh+dt, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
Hi Johan,
Am Freitag, 17. April 2020, 12:57:39 CEST schrieb Johan Jonker:
> The rk3318 is basically a rk3328 with improved gpu,
> so add a dtsi based on that.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Please don't add dangling dtsi files.
I'd expect at least a board dts to actually use that and
also the updated gpu node.
From a cursory glance it looks like it gets upgraded from
450-MP2 to 450MP3 or so, so that would at least mean
another set of interrupts.
Heiko
> ---
> arch/arm64/boot/dts/rockchip/rk3318.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3318.dtsi
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3318.dtsi b/arch/arm64/boot/dts/rockchip/rk3318.dtsi
> new file mode 100644
> index 000000000..a32f771bc
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3318.dtsi
> @@ -0,0 +1,3 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +#include "rk3328.dtsi"
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH] arm64: dts: rockchip: add core devicetree for rk3318
@ 2020-04-17 11:05 ` Heiko Stuebner
0 siblings, 0 replies; 9+ messages in thread
From: Heiko Stuebner @ 2020-04-17 11:05 UTC (permalink / raw)
To: Johan Jonker
Cc: devicetree, robh+dt, linux-kernel, linux-arm-kernel,
linux-rockchip
Hi Johan,
Am Freitag, 17. April 2020, 12:57:39 CEST schrieb Johan Jonker:
> The rk3318 is basically a rk3328 with improved gpu,
> so add a dtsi based on that.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Please don't add dangling dtsi files.
I'd expect at least a board dts to actually use that and
also the updated gpu node.
From a cursory glance it looks like it gets upgraded from
450-MP2 to 450MP3 or so, so that would at least mean
another set of interrupts.
Heiko
> ---
> arch/arm64/boot/dts/rockchip/rk3318.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3318.dtsi
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3318.dtsi b/arch/arm64/boot/dts/rockchip/rk3318.dtsi
> new file mode 100644
> index 000000000..a32f771bc
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3318.dtsi
> @@ -0,0 +1,3 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +#include "rk3328.dtsi"
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH] arm64: dts: rockchip: add core devicetree for rk3318
2020-04-17 11:05 ` Heiko Stuebner
(?)
@ 2020-04-17 11:51 ` Robin Murphy
-1 siblings, 0 replies; 9+ messages in thread
From: Robin Murphy @ 2020-04-17 11:51 UTC (permalink / raw)
To: Heiko Stuebner, Johan Jonker
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On 2020-04-17 12:05 pm, Heiko Stuebner wrote:
> Hi Johan,
>
> Am Freitag, 17. April 2020, 12:57:39 CEST schrieb Johan Jonker:
>> The rk3318 is basically a rk3328 with improved gpu,
>> so add a dtsi based on that.
>>
>> Signed-off-by: Johan Jonker <jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Please don't add dangling dtsi files.
> I'd expect at least a board dts to actually use that and
> also the updated gpu node.
>
> From a cursory glance it looks like it gets upgraded from
> 450-MP2 to 450MP3 or so, so that would at least mean
> another set of interrupts.
I'm not sure anything's "improved" - as far as the internet can tell
it's a special low-cost variant of RK3328 for low-end TV box vendors
that Rockchip don't want to talk about. The DTB for my H96 Max 3318
shows no appreciable difference from the BSP DT for RK3328, although I
wouldn't be surprised if some of the unused stuff like the external GMAC
was actually missing or broken. The board itself is the exact same one
used in a lot of other cheap RK3328 boxes (and I mean literally, it's
silkscreened "RK3328_8D4_V1.2").
Thanks to one unexpectedly honest Aliexpress listing I stumbled across,
the "penta-core GPU" apparently translates from TV-box-marketing-speak
to mean Mali-450 MP2 (1GP + 2PP) plus the RGA plus the VOP ;)
Robin.
>
> Heiko
>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3318.dtsi | 3 +++
>> 1 file changed, 3 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/rockchip/rk3318.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3318.dtsi b/arch/arm64/boot/dts/rockchip/rk3318.dtsi
>> new file mode 100644
>> index 000000000..a32f771bc
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/rockchip/rk3318.dtsi
>> @@ -0,0 +1,3 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +
>> +#include "rk3328.dtsi"
>>
>
>
>
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH] arm64: dts: rockchip: add core devicetree for rk3318
@ 2020-04-17 11:51 ` Robin Murphy
0 siblings, 0 replies; 9+ messages in thread
From: Robin Murphy @ 2020-04-17 11:51 UTC (permalink / raw)
To: Heiko Stuebner, Johan Jonker
Cc: devicetree, robh+dt, linux-kernel, linux-arm-kernel,
linux-rockchip
On 2020-04-17 12:05 pm, Heiko Stuebner wrote:
> Hi Johan,
>
> Am Freitag, 17. April 2020, 12:57:39 CEST schrieb Johan Jonker:
>> The rk3318 is basically a rk3328 with improved gpu,
>> so add a dtsi based on that.
>>
>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>
> Please don't add dangling dtsi files.
> I'd expect at least a board dts to actually use that and
> also the updated gpu node.
>
> From a cursory glance it looks like it gets upgraded from
> 450-MP2 to 450MP3 or so, so that would at least mean
> another set of interrupts.
I'm not sure anything's "improved" - as far as the internet can tell
it's a special low-cost variant of RK3328 for low-end TV box vendors
that Rockchip don't want to talk about. The DTB for my H96 Max 3318
shows no appreciable difference from the BSP DT for RK3328, although I
wouldn't be surprised if some of the unused stuff like the external GMAC
was actually missing or broken. The board itself is the exact same one
used in a lot of other cheap RK3328 boxes (and I mean literally, it's
silkscreened "RK3328_8D4_V1.2").
Thanks to one unexpectedly honest Aliexpress listing I stumbled across,
the "penta-core GPU" apparently translates from TV-box-marketing-speak
to mean Mali-450 MP2 (1GP + 2PP) plus the RGA plus the VOP ;)
Robin.
>
> Heiko
>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3318.dtsi | 3 +++
>> 1 file changed, 3 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/rockchip/rk3318.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3318.dtsi b/arch/arm64/boot/dts/rockchip/rk3318.dtsi
>> new file mode 100644
>> index 000000000..a32f771bc
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/rockchip/rk3318.dtsi
>> @@ -0,0 +1,3 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +
>> +#include "rk3328.dtsi"
>>
>
>
>
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH] arm64: dts: rockchip: add core devicetree for rk3318
@ 2020-04-17 11:51 ` Robin Murphy
0 siblings, 0 replies; 9+ messages in thread
From: Robin Murphy @ 2020-04-17 11:51 UTC (permalink / raw)
To: Heiko Stuebner, Johan Jonker
Cc: devicetree, robh+dt, linux-kernel, linux-arm-kernel,
linux-rockchip
On 2020-04-17 12:05 pm, Heiko Stuebner wrote:
> Hi Johan,
>
> Am Freitag, 17. April 2020, 12:57:39 CEST schrieb Johan Jonker:
>> The rk3318 is basically a rk3328 with improved gpu,
>> so add a dtsi based on that.
>>
>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>
> Please don't add dangling dtsi files.
> I'd expect at least a board dts to actually use that and
> also the updated gpu node.
>
> From a cursory glance it looks like it gets upgraded from
> 450-MP2 to 450MP3 or so, so that would at least mean
> another set of interrupts.
I'm not sure anything's "improved" - as far as the internet can tell
it's a special low-cost variant of RK3328 for low-end TV box vendors
that Rockchip don't want to talk about. The DTB for my H96 Max 3318
shows no appreciable difference from the BSP DT for RK3328, although I
wouldn't be surprised if some of the unused stuff like the external GMAC
was actually missing or broken. The board itself is the exact same one
used in a lot of other cheap RK3328 boxes (and I mean literally, it's
silkscreened "RK3328_8D4_V1.2").
Thanks to one unexpectedly honest Aliexpress listing I stumbled across,
the "penta-core GPU" apparently translates from TV-box-marketing-speak
to mean Mali-450 MP2 (1GP + 2PP) plus the RGA plus the VOP ;)
Robin.
>
> Heiko
>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3318.dtsi | 3 +++
>> 1 file changed, 3 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/rockchip/rk3318.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3318.dtsi b/arch/arm64/boot/dts/rockchip/rk3318.dtsi
>> new file mode 100644
>> index 000000000..a32f771bc
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/rockchip/rk3318.dtsi
>> @@ -0,0 +1,3 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +
>> +#include "rk3328.dtsi"
>>
>
>
>
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread