All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>,
	qemu-arm <qemu-arm@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 3/3] target/arm: Make Cortex-M3 and M4 default to 8 PMSA regions
Date: Tue, 11 Jul 2017 13:30:06 -0400 (EDT)	[thread overview]
Message-ID: <2146046377.49609243.1499794206964.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAFEAcA9Hv_C-w9hVO2C5WYw7SFOerHPsGb1-B44fQiy2Ud+CCQ@mail.gmail.com>

hi

----- Original Message -----
> On 11 July 2017 at 18:18, Marc-André Lureau <marcandre.lureau@redhat.com>
> wrote:
> > ----- Original Message -----
> >> The Cortex-M3 and M4 CPUs always have 8 PMSA MPU regions (this isn't
> >> a configurable option for the hardware).  Make the default value of
> >> the pmsav7-dregion property be set per-cpu, so we don't need to have
> >> every user of these CPUs set it manually.  (The existing default of
> >> 16 is correct for the other PMSAv7 core, the Cortex-R5.)
> >>
> >> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> >
> > So until now that value was wrong for m3/m4 if I understand correctly.
> 
> Correct. (It was too high, so didn't cause a problem for
> guests typically -- a guest assuming 8 memory regions would
> just not use the registers associated with the extra
> unexpected ones.)

Would be nice to add that to the commit message

in any case:
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

WARNING: multiple messages have this Message-ID (diff)
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm <qemu-arm@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	patches@linaro.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] target/arm: Make Cortex-M3 and M4 default to 8 PMSA regions
Date: Tue, 11 Jul 2017 13:30:06 -0400 (EDT)	[thread overview]
Message-ID: <2146046377.49609243.1499794206964.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAFEAcA9Hv_C-w9hVO2C5WYw7SFOerHPsGb1-B44fQiy2Ud+CCQ@mail.gmail.com>

hi

----- Original Message -----
> On 11 July 2017 at 18:18, Marc-André Lureau <marcandre.lureau@redhat.com>
> wrote:
> > ----- Original Message -----
> >> The Cortex-M3 and M4 CPUs always have 8 PMSA MPU regions (this isn't
> >> a configurable option for the hardware).  Make the default value of
> >> the pmsav7-dregion property be set per-cpu, so we don't need to have
> >> every user of these CPUs set it manually.  (The existing default of
> >> 16 is correct for the other PMSAv7 core, the Cortex-R5.)
> >>
> >> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> >
> > So until now that value was wrong for m3/m4 if I understand correctly.
> 
> Correct. (It was too high, so didn't cause a problem for
> guests typically -- a guest assuming 8 memory regions would
> just not use the registers associated with the extra
> unexpected ones.)

Would be nice to add that to the commit message

in any case:
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

  reply	other threads:[~2017-07-11 17:38 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11 15:53 [Qemu-arm] [PATCH 0/3] Allow int props with no default, use them in ARM Peter Maydell
2017-07-11 15:53 ` [Qemu-devel] " Peter Maydell
2017-07-11 15:53 ` [Qemu-arm] [PATCH 1/3] qdev-properties.h: Explicitly set the default value for arraylen properties Peter Maydell
2017-07-11 15:53   ` [Qemu-devel] " Peter Maydell
2017-07-11 16:46   ` Marc-André Lureau
2017-07-11 16:46     ` Marc-André Lureau
2017-07-13 14:11   ` [Qemu-arm] " Markus Armbruster
2017-07-13 14:11     ` Markus Armbruster
2017-07-13 14:26     ` [Qemu-arm] " Peter Maydell
2017-07-13 14:26       ` Peter Maydell
2017-07-13 16:21       ` [Qemu-arm] " Markus Armbruster
2017-07-13 16:21         ` Markus Armbruster
2017-07-11 15:53 ` [Qemu-arm] [PATCH 2/3] qdev: support properties which don't set a default value Peter Maydell
2017-07-11 15:53   ` [Qemu-devel] " Peter Maydell
2017-07-11 17:15   ` Marc-André Lureau
2017-07-11 17:15     ` Marc-André Lureau
2017-07-11 17:25     ` [Qemu-arm] " Peter Maydell
2017-07-11 17:25       ` [Qemu-devel] " Peter Maydell
2017-07-12 11:22   ` [Qemu-arm] " Markus Armbruster
2017-07-12 11:22     ` Markus Armbruster
2017-07-12 12:27     ` Peter Maydell
2017-07-12 12:27       ` Peter Maydell
2017-07-13 15:38     ` Peter Maydell
2017-07-13 15:38       ` Peter Maydell
2017-07-13 17:10       ` [Qemu-arm] " Markus Armbruster
2017-07-13 17:10         ` Markus Armbruster
2017-07-13 17:18         ` Peter Maydell
2017-07-13 18:25           ` [Qemu-arm] " Markus Armbruster
2017-07-13 18:25             ` Markus Armbruster
2017-07-11 15:53 ` [Qemu-arm] [PATCH 3/3] target/arm: Make Cortex-M3 and M4 default to 8 PMSA regions Peter Maydell
2017-07-11 15:53   ` [Qemu-devel] " Peter Maydell
2017-07-11 17:18   ` Marc-André Lureau
2017-07-11 17:18     ` Marc-André Lureau
2017-07-11 17:27     ` [Qemu-arm] " Peter Maydell
2017-07-11 17:27       ` [Qemu-devel] " Peter Maydell
2017-07-11 17:30       ` Marc-André Lureau [this message]
2017-07-11 17:30         ` Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2146046377.49609243.1499794206964.JavaMail.zimbra@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=armbru@redhat.com \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.