From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 3/4] ethdev: count devices consistently
Date: Thu, 30 Mar 2017 21:26:12 +0200 [thread overview]
Message-ID: <2147239.2BbhZDoxjl@xps13> (raw)
In-Reply-To: <08811b2c92fa8c802a13000186aaebd5db5ee2ca.1488550937.git.gaetan.rivet@6wind.com>
2017-03-03 16:40, Gaetan Rivet:
> Make the rte_eth_dev_count() return the correct number of devices even
> after some are detached by the hotplug API.
Please explain what is the correct number,
or that the wrong number was a max id.
> This change does not affect existing applications that do not use
> hotplug API calls. Those that do are already aware that port IDs are not
> necessarily contiguous.
[...]
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> -#define RTE_ETH_FOREACH_DEV(p) \
> - for (p = rte_eth_find_next(0); \
> - p < RTE_MAX_ETHPORTS; \
> +#define RTE_ETH_FOREACH_DEV(p) \
> + for (p = rte_eth_find_next(0); \
> + (unsigned int)p < (unsigned int)RTE_MAX_ETHPORTS; \
> p = rte_eth_find_next(p + 1))
This macro was introduced in previous patch.
Why adding the cast here?
next prev parent reply other threads:[~2017-03-30 19:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 15:40 [PATCH 0/4] clarify eth_dev state management Gaetan Rivet
2017-03-03 15:40 ` [PATCH 1/4] ethdev: expose device states Gaetan Rivet
2017-03-03 15:40 ` [PATCH 2/4] ethdev: add device iterator Gaetan Rivet
2017-03-03 15:40 ` [PATCH 3/4] ethdev: count devices consistently Gaetan Rivet
2017-03-30 19:26 ` Thomas Monjalon [this message]
2017-03-31 9:13 ` Gaëtan Rivet
2017-03-03 15:40 ` [PATCH 4/4] app/testpmd: use ethdev iterator to list devices Gaetan Rivet
2017-03-31 12:04 ` [PATCH v2 0/3] clarify eth_dev state management Gaetan Rivet
2017-03-31 12:04 ` [PATCH v2 1/3] ethdev: expose device states Gaetan Rivet
2017-03-31 12:04 ` [PATCH v2 2/3] ethdev: add device iterator Gaetan Rivet
2017-04-05 20:42 ` Thomas Monjalon
2017-03-31 12:04 ` [PATCH v2 3/3] app/testpmd: use ethdev iterator to list devices Gaetan Rivet
2017-04-05 20:46 ` [PATCH v2 0/3] clarify eth_dev state management Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2147239.2BbhZDoxjl@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.