Re: [PATCH v8 1/4] iio: adc: Kconfig change description for Allwinner GPADC

From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: linux-iio@vger.kernel.org, Maksim Kiselev <bigunclemax@gmail.com>
Cc: "Maksim Kiselev" <bigunclemax@gmail.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Samuel Holland" <samuel@sholland.org>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>,
	"Andre Przywara" <andre.przywara@arm.com>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"Cosmin Tanislav" <demonsingur@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Leonard Göhrs" <l.goehrs@pengutronix.de>,
	"ChiYuan Huang" <cy_huang@richtek.com>,
	"Ramona Bolboaca" <ramona.bolboaca@analog.com>,
	"Ibrahim Tilki" <Ibrahim.Tilki@analog.com>,
	"ChiaEn Wu" <chiaen_wu@richtek.com>,
	"William Breathitt Gray" <william.gray@linaro.org>,
	"Haibo Chen" <haibo.chen@nxp.com>,
	"Mike Looijmans" <mike.looijmans@topic.nl>,
	"Quentin Schulz" <quentin.schulz@free-electrons.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v8 1/4] iio: adc: Kconfig change description for Allwinner GPADC
Date: Tue, 11 Jul 2023 20:14:08 +0200	[thread overview]
Message-ID: <2148594.irdbgypaU6@jernej-laptop> (raw)
In-Reply-To: <20230619154252.3951913-2-bigunclemax@gmail.com>

Dne ponedeljek, 19. junij 2023 ob 17:42:24 CEST je Maksim Kiselev napisal(a):
> This patch adds SoCs names to Allwinner GPADC description to
> make it more informative.

Please reword to remove "This patch".

> 
> Fixes: d1caa9905538 ("iio: adc: add support for Allwinner SoCs ADC")

I'm fine with the patch in general, but does this really warrant fixes tag?

Best regards,
Jernej

> Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com>
> ---
>  drivers/iio/adc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index eb2b09ef5d5b..d93868684c7b 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -1105,7 +1105,7 @@ config STMPE_ADC
>  	  built-in ADC block (stmpe811).
> 
>  config SUN4I_GPADC
> -	tristate "Support for the Allwinner SoCs GPADC"
> +	tristate "Allwinner A10/A13/A31 and similar GPADCs driver"
>  	depends on IIO
>  	depends on MFD_SUN4I_GPADC || MACH_SUN8I
>  	depends on THERMAL || !THERMAL_OF