From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: rockchip: convert smp bringup to CPU_METHOD_OF_DECLARE
Date: Wed, 26 Mar 2014 13:03:18 +0100 [thread overview]
Message-ID: <2151573.evmqdkWnet@diego> (raw)
In-Reply-To: <20140326110024.GR10341@e106331-lin.cambridge.arm.com>
Am Mittwoch, 26. M?rz 2014, 11:00:24 schrieb Mark Rutland:
> On Wed, Mar 26, 2014 at 10:27:35AM +0000, Heiko St?bner wrote:
> > With the newly introduced CPU_METHOD_OF_DECLARE is not necessary anymore
> > to reference the relevant smp_ops in the board file, but instead it can
> > simply be set by the enable-method property of the cpu nodes.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> >
> > Documentation/devicetree/bindings/arm/cpus.txt | 1 +
> > arch/arm/boot/dts/rk3066a.dtsi | 1 +
> > arch/arm/boot/dts/rk3188.dtsi | 1 +
> > arch/arm/mach-rockchip/core.h | 2 --
> > arch/arm/mach-rockchip/platsmp.c | 3 ++-
> > arch/arm/mach-rockchip/rockchip.c | 1 -
> > 6 files changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/cpus.txt
> > b/Documentation/devicetree/bindings/arm/cpus.txt index 333f4ae..2501d5d
> > 100644
> > --- a/Documentation/devicetree/bindings/arm/cpus.txt
> > +++ b/Documentation/devicetree/bindings/arm/cpus.txt
> > @@ -185,6 +185,7 @@ nodes to be present and contain the properties
> > described below.>
> > "qcom,gcc-msm8660"
> > "qcom,kpss-acc-v1"
> > "qcom,kpss-acc-v2"
> >
> > + "rockchip,rk3066-smp"
>
> We should document what what these actually mean, so as to be a hardware
> description and not a Linux internals description.
is something like
"rockchip,rk3066-smp" - cpu-core handling used by SoCs
from Rockchip starting with rk3066
enough, or should it contain more data?
Thanks
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: "arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Linux ARM Kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [PATCH] ARM: rockchip: convert smp bringup to CPU_METHOD_OF_DECLARE
Date: Wed, 26 Mar 2014 13:03:18 +0100 [thread overview]
Message-ID: <2151573.evmqdkWnet@diego> (raw)
In-Reply-To: <20140326110024.GR10341-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
Am Mittwoch, 26. März 2014, 11:00:24 schrieb Mark Rutland:
> On Wed, Mar 26, 2014 at 10:27:35AM +0000, Heiko Stübner wrote:
> > With the newly introduced CPU_METHOD_OF_DECLARE is not necessary anymore
> > to reference the relevant smp_ops in the board file, but instead it can
> > simply be set by the enable-method property of the cpu nodes.
> >
> > Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> > ---
> >
> > Documentation/devicetree/bindings/arm/cpus.txt | 1 +
> > arch/arm/boot/dts/rk3066a.dtsi | 1 +
> > arch/arm/boot/dts/rk3188.dtsi | 1 +
> > arch/arm/mach-rockchip/core.h | 2 --
> > arch/arm/mach-rockchip/platsmp.c | 3 ++-
> > arch/arm/mach-rockchip/rockchip.c | 1 -
> > 6 files changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/cpus.txt
> > b/Documentation/devicetree/bindings/arm/cpus.txt index 333f4ae..2501d5d
> > 100644
> > --- a/Documentation/devicetree/bindings/arm/cpus.txt
> > +++ b/Documentation/devicetree/bindings/arm/cpus.txt
> > @@ -185,6 +185,7 @@ nodes to be present and contain the properties
> > described below.>
> > "qcom,gcc-msm8660"
> > "qcom,kpss-acc-v1"
> > "qcom,kpss-acc-v2"
> >
> > + "rockchip,rk3066-smp"
>
> We should document what what these actually mean, so as to be a hardware
> description and not a Linux internals description.
is something like
"rockchip,rk3066-smp" - cpu-core handling used by SoCs
from Rockchip starting with rk3066
enough, or should it contain more data?
Thanks
Heiko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-26 12:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 10:27 [PATCH] ARM: rockchip: convert smp bringup to CPU_METHOD_OF_DECLARE Heiko Stübner
2014-03-26 10:27 ` Heiko Stübner
2014-03-26 11:00 ` Mark Rutland
2014-03-26 11:00 ` Mark Rutland
2014-03-26 12:03 ` Heiko Stübner [this message]
2014-03-26 12:03 ` Heiko Stübner
2014-03-27 0:06 ` [PATCH v2] " Heiko Stübner
2014-03-27 0:06 ` Heiko Stübner
2014-05-12 17:17 ` Heiko Stübner
2014-05-12 17:17 ` Heiko Stübner
2014-05-16 22:54 ` Olof Johansson
2014-05-16 22:54 ` Olof Johansson
2014-05-17 0:16 ` Heiko Stübner
2014-05-17 0:16 ` Heiko Stübner
2014-05-26 18:13 ` Olof Johansson
2014-05-26 18:13 ` Olof Johansson
2014-05-26 19:20 ` Heiko Stübner
2014-05-26 19:20 ` Heiko Stübner
2014-05-26 19:21 ` Olof Johansson
2014-05-26 19:21 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2151573.evmqdkWnet@diego \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.