All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 05/11] memory: add Atmel EBI (External Bus Interface) driver
Date: Mon, 01 Dec 2014 22:28:39 +0100	[thread overview]
Message-ID: <2153824.ln4mvSCK1X@wuerfel> (raw)
In-Reply-To: <20141201212820.6a7fc4b0@bbrezillon>

On Monday 01 December 2014 21:28:20 Boris Brezillon wrote:
> > On Monday 01 December 2014 19:29:23 Boris Brezillon wrote:
> > > On Mon, 01 Dec 2014 17:26:27 +0100 Arnd Bergmann <arnd@arndb.de> wrote:
> > > 
> > > #define AT91_EBICSA_REGFIELD(off)                   \
> > >     REG_FIELD(ebicsa_off, AT91_MATRIX_EBI_NUM_CS - 1)
> > > 
> > 
> > That would be acceptable too, but what I really meant is one step further:
> > 
> > static const struct reg_field at91sam9260_ebi_csa = 
> >       REG_FIELD(AT91SAM9260_MATRIX_EBICSA_OFF, 0, AT91_MATRIX_EBI_NUM_CS - 1);
> 
> That's what I did in the first place (in a version I didn't submitted),
> and I guess I'll go for that one unless you really prefer the
> alternative (I ran into a lot of trouble with DT bindings ABI
> stability, and I'd prefer to keep DT bindings as simple as
> possible).

Ok, that's good then.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Andrew Victor <linux@maxim.org.za>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH v3 05/11] memory: add Atmel EBI (External Bus Interface) driver
Date: Mon, 01 Dec 2014 22:28:39 +0100	[thread overview]
Message-ID: <2153824.ln4mvSCK1X@wuerfel> (raw)
In-Reply-To: <20141201212820.6a7fc4b0@bbrezillon>

On Monday 01 December 2014 21:28:20 Boris Brezillon wrote:
> > On Monday 01 December 2014 19:29:23 Boris Brezillon wrote:
> > > On Mon, 01 Dec 2014 17:26:27 +0100 Arnd Bergmann <arnd@arndb.de> wrote:
> > > 
> > > #define AT91_EBICSA_REGFIELD(off)                   \
> > >     REG_FIELD(ebicsa_off, AT91_MATRIX_EBI_NUM_CS - 1)
> > > 
> > 
> > That would be acceptable too, but what I really meant is one step further:
> > 
> > static const struct reg_field at91sam9260_ebi_csa = 
> >       REG_FIELD(AT91SAM9260_MATRIX_EBICSA_OFF, 0, AT91_MATRIX_EBI_NUM_CS - 1);
> 
> That's what I did in the first place (in a version I didn't submitted),
> and I guess I'll go for that one unless you really prefer the
> alternative (I ran into a lot of trouble with DT bindings ABI
> stability, and I'd prefer to keep DT bindings as simple as
> possible).

Ok, that's good then.

	Arnd

  reply	other threads:[~2014-12-01 21:28 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01 10:27 [PATCH v3 00/11] memory: add Atmel EBI (External Bus Interface) driver Boris Brezillon
2014-12-01 10:27 ` Boris Brezillon
2014-12-01 10:27 ` Boris Brezillon
2014-12-01 10:27 ` [PATCH v3 01/11] mfd: syscon: Add atmel-matrix registers definition Boris Brezillon
2014-12-01 10:27   ` Boris Brezillon
2014-12-03 15:57   ` Nicolas Ferre
2014-12-03 15:57     ` Nicolas Ferre
2014-12-03 15:57     ` Nicolas Ferre
2014-12-01 10:27 ` [PATCH v3 02/11] mfd: syscon: Add Atmel Matrix bus DT binding documentation Boris Brezillon
2014-12-01 10:27   ` Boris Brezillon
2014-12-01 10:27   ` Boris Brezillon
2014-12-03 14:32   ` Nicolas Ferre
2014-12-03 14:32     ` Nicolas Ferre
2014-12-03 14:32     ` Nicolas Ferre
2014-12-03 14:52     ` Boris Brezillon
2014-12-03 14:52       ` Boris Brezillon
2014-12-03 14:52       ` Boris Brezillon
2014-12-01 10:27 ` [PATCH v3 03/11] mfd: syscon: Add atmel-smc registers definition Boris Brezillon
2014-12-01 10:27   ` Boris Brezillon
2014-12-01 10:27   ` Boris Brezillon
2014-12-01 10:27 ` [PATCH v3 04/11] mfd: syscon: Add Atmel SMC binding doc Boris Brezillon
2014-12-01 10:27   ` Boris Brezillon
2014-12-01 10:27   ` Boris Brezillon
2014-12-01 10:27 ` [PATCH v3 05/11] memory: add Atmel EBI (External Bus Interface) driver Boris Brezillon
2014-12-01 10:27   ` Boris Brezillon
2014-12-01 10:40   ` Alexander Stein
2014-12-01 10:40     ` Alexander Stein
2014-12-01 10:40     ` Alexander Stein
2014-12-01 10:50     ` Boris Brezillon
2014-12-01 10:50       ` Boris Brezillon
2014-12-01 10:50       ` Boris Brezillon
2014-12-01 16:17       ` Arnd Bergmann
2014-12-01 16:17         ` Arnd Bergmann
2014-12-02  9:18         ` Alexander Stein
2014-12-02  9:18           ` Alexander Stein
2014-12-02  9:41           ` Arnd Bergmann
2014-12-02  9:41             ` Arnd Bergmann
2014-12-02  9:41             ` Arnd Bergmann
2014-12-01 16:26   ` Arnd Bergmann
2014-12-01 16:26     ` Arnd Bergmann
2014-12-01 16:26     ` Arnd Bergmann
2014-12-01 18:29     ` Boris Brezillon
2014-12-01 18:29       ` Boris Brezillon
2014-12-01 18:29       ` Boris Brezillon
2014-12-01 19:43       ` Arnd Bergmann
2014-12-01 19:43         ` Arnd Bergmann
2014-12-01 19:43         ` Arnd Bergmann
2014-12-01 20:28         ` Boris Brezillon
2014-12-01 20:28           ` Boris Brezillon
2014-12-01 20:28           ` Boris Brezillon
2014-12-01 21:28           ` Arnd Bergmann [this message]
2014-12-01 21:28             ` Arnd Bergmann
2014-12-09 20:53   ` Alexander Stein
2014-12-09 20:53     ` Alexander Stein
2014-12-09 20:53     ` Alexander Stein
2014-12-15 10:22     ` Boris Brezillon
2014-12-15 10:22       ` Boris Brezillon
2014-12-15 10:22       ` Boris Brezillon
2014-12-15 10:29       ` Alexander Stein
2014-12-15 10:29         ` Alexander Stein
2014-12-15 10:29         ` Alexander Stein
2014-12-15 10:43         ` Boris Brezillon
2014-12-15 10:43           ` Boris Brezillon
2014-12-15 10:43           ` Boris Brezillon
2014-12-01 10:27 ` [PATCH v3 06/11] memory: atmel-ebi: add DT bindings documentation Boris Brezillon
2014-12-01 10:27   ` Boris Brezillon
2014-12-03 14:56   ` Nicolas Ferre
2014-12-03 14:56     ` Nicolas Ferre
2014-12-03 14:56     ` Nicolas Ferre
2014-12-03 15:15     ` Nicolas Ferre
2014-12-03 15:15       ` Nicolas Ferre
2014-12-03 15:15       ` Nicolas Ferre
2014-12-03 15:34       ` Boris Brezillon
2014-12-03 15:34         ` Boris Brezillon
2014-12-03 15:34         ` Boris Brezillon
2014-12-03 15:38         ` Boris Brezillon
2014-12-03 15:38           ` Boris Brezillon
2014-12-03 15:38           ` Boris Brezillon
2014-12-03 19:28     ` Boris Brezillon
2014-12-03 19:28       ` Boris Brezillon
2014-12-03 19:28       ` Boris Brezillon
2014-12-01 10:27 ` [PATCH v3 07/11] ARM: at91: select ATMEL_EBI when compiling a kernel for at91sam9 or sama5d3 Boris Brezillon
2014-12-01 10:27   ` Boris Brezillon
2014-12-03 16:21   ` Nicolas Ferre
2014-12-03 16:21     ` Nicolas Ferre
2014-12-03 16:21     ` Nicolas Ferre
2014-12-01 10:27 ` [PATCH v3 08/11] ARM: at91/dt: add HSMC (Static Memory Controller) node in sama5d3 dtsi Boris Brezillon
2014-12-01 10:27   ` Boris Brezillon
2014-12-01 10:27 ` [PATCH v3 09/11] ARM: at91/dt: add matrix " Boris Brezillon
2014-12-01 10:27   ` Boris Brezillon
2014-12-01 10:27 ` [PATCH v3 10/11] ARM: at91/dt: add EBI (External Bus Interface) " Boris Brezillon
2014-12-01 10:27   ` Boris Brezillon
2014-12-01 10:27 ` [PATCH v3 11/11] ARM: at91/dt: add NOR definition in sama5d3xcm dtsi Boris Brezillon
2014-12-01 10:27   ` Boris Brezillon
2014-12-02  8:47 ` [PATCH v4 05/11] memory: add Atmel EBI (External Bus Interface) driver Boris Brezillon
2014-12-02  8:47   ` Boris Brezillon
2014-12-02  8:47   ` Boris Brezillon
2014-12-03 15:24   ` Nicolas Ferre
2014-12-03 15:24     ` Nicolas Ferre
2014-12-03 15:24     ` Nicolas Ferre
2014-12-03 11:14 ` [PATCH v4 01/11] mfd: syscon: Add atmel-matrix registers definition Boris Brezillon
2014-12-03 11:14   ` Boris Brezillon
2014-12-03 11:14   ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2153824.ln4mvSCK1X@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.