All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
	guptarud@gmail.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	"Rudraksha Gupta" <guptarud@gmail.com>,
	"Kamil Trzciński" <ayufan@ayufan.eu>,
	"Martijn Braam" <martijn@brixit.nl>,
	"Ondrej Jirman" <megi@xff.cz>
Subject: Re: [PATCH 2/3] mfd: rk8xx-core: Configure `rk808-clkout2` function
Date: Tue, 13 Jan 2026 11:23:31 +0100	[thread overview]
Message-ID: <2159404.K71DO8KEF6@diego> (raw)
In-Reply-To: <20260112-ppp_connectivity-v1-2-284d6e83b212@gmail.com>

Hi,

Am Dienstag, 13. Januar 2026, 07:42:25 Mitteleuropäische Normalzeit schrieb Rudraksha Gupta via B4 Relay:
> From: Kamil Trzciński <ayufan@ayufan.eu>
> 
> While the Wifi and Bluetooth chip are defined in the Pinephone Pro's
> DTS, it actually isn't able to be used. Let's define rk808-clkout2 so
> that userspace can actually interact with Wifi and Bluetooth

Needs of one special device don't really justify changing core drivers.
So this commit message definitly needs a more general description on
why this is needed.

> Co-developed-by: Martijn Braam <martijn@brixit.nl>
> Signed-off-by: Martijn Braam <martijn@brixit.nl>
> Signed-off-by: Kamil Trzciński <ayufan@ayufan.eu>
> Signed-off-by: Ondrej Jirman <megi@xff.cz>
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
> ---
>  drivers/mfd/rk8xx-core.c  | 1 +
>  include/linux/mfd/rk808.h | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/rk8xx-core.c b/drivers/mfd/rk8xx-core.c
> index def4587fdfb8..602218694334 100644
> --- a/drivers/mfd/rk8xx-core.c
> +++ b/drivers/mfd/rk8xx-core.c
> @@ -282,6 +282,7 @@ static const struct rk808_reg_data rk818_pre_init_reg[] = {
>  	{ RK818_H5V_EN_REG,	  BIT(0),	    RK818_H5V_EN },
>  	{ RK808_VB_MON_REG,	  MASK_ALL,	    VB_LO_ACT |
>  						    VB_LO_SEL_3500MV },
> +	{ RK808_CLK32OUT_REG, CLK32KOUT2_FUNC_MASK, CLK32KOUT2_FUNC },

So now you're unconditionally enabling this clock output, without anybody
being able to turn it off again?

Please look at drivers/clk/clk-rk808.c and adapt it to handle the rk8xx
variants, as that provides a real clock driver that your wifi node can
use.


Heiko




WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
	guptarud@gmail.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	"Rudraksha Gupta" <guptarud@gmail.com>,
	"Kamil Trzciński" <ayufan@ayufan.eu>,
	"Martijn Braam" <martijn@brixit.nl>,
	"Ondrej Jirman" <megi@xff.cz>
Subject: Re: [PATCH 2/3] mfd: rk8xx-core: Configure `rk808-clkout2` function
Date: Tue, 13 Jan 2026 11:23:31 +0100	[thread overview]
Message-ID: <2159404.K71DO8KEF6@diego> (raw)
In-Reply-To: <20260112-ppp_connectivity-v1-2-284d6e83b212@gmail.com>

Hi,

Am Dienstag, 13. Januar 2026, 07:42:25 Mitteleuropäische Normalzeit schrieb Rudraksha Gupta via B4 Relay:
> From: Kamil Trzciński <ayufan@ayufan.eu>
> 
> While the Wifi and Bluetooth chip are defined in the Pinephone Pro's
> DTS, it actually isn't able to be used. Let's define rk808-clkout2 so
> that userspace can actually interact with Wifi and Bluetooth

Needs of one special device don't really justify changing core drivers.
So this commit message definitly needs a more general description on
why this is needed.

> Co-developed-by: Martijn Braam <martijn@brixit.nl>
> Signed-off-by: Martijn Braam <martijn@brixit.nl>
> Signed-off-by: Kamil Trzciński <ayufan@ayufan.eu>
> Signed-off-by: Ondrej Jirman <megi@xff.cz>
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
> ---
>  drivers/mfd/rk8xx-core.c  | 1 +
>  include/linux/mfd/rk808.h | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/rk8xx-core.c b/drivers/mfd/rk8xx-core.c
> index def4587fdfb8..602218694334 100644
> --- a/drivers/mfd/rk8xx-core.c
> +++ b/drivers/mfd/rk8xx-core.c
> @@ -282,6 +282,7 @@ static const struct rk808_reg_data rk818_pre_init_reg[] = {
>  	{ RK818_H5V_EN_REG,	  BIT(0),	    RK818_H5V_EN },
>  	{ RK808_VB_MON_REG,	  MASK_ALL,	    VB_LO_ACT |
>  						    VB_LO_SEL_3500MV },
> +	{ RK808_CLK32OUT_REG, CLK32KOUT2_FUNC_MASK, CLK32KOUT2_FUNC },

So now you're unconditionally enabling this clock output, without anybody
being able to turn it off again?

Please look at drivers/clk/clk-rk808.c and adapt it to handle the rk8xx
variants, as that provides a real clock driver that your wifi node can
use.


Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2026-01-13 10:23 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13  6:42 [PATCH 0/3] Pinephone Pro Connectivity: Adding Modem, Bluetooth, and Wi-Fi Rudraksha Gupta
2026-01-13  6:42 ` Rudraksha Gupta via B4 Relay
2026-01-13  6:42 ` Rudraksha Gupta via B4 Relay
2026-01-13  6:42 ` [PATCH 1/3] arm64: dts: rockchip: Add modem to the Pinephone Pro Rudraksha Gupta
2026-01-13  6:42   ` Rudraksha Gupta via B4 Relay
2026-01-13  6:42   ` Rudraksha Gupta via B4 Relay
2026-01-13  7:22   ` Krzysztof Kozlowski
2026-01-13  7:22     ` Krzysztof Kozlowski
2026-01-14  5:57     ` Danct12
2026-01-14  5:57       ` Danct12
2026-01-13 20:47   ` Ondřej Jirman
2026-01-13 20:47     ` Ondřej Jirman
2026-01-13  6:42 ` [PATCH 2/3] mfd: rk8xx-core: Configure `rk808-clkout2` function Rudraksha Gupta
2026-01-13  6:42   ` Rudraksha Gupta via B4 Relay
2026-01-13  6:42   ` Rudraksha Gupta via B4 Relay
2026-01-13 10:23   ` Heiko Stübner [this message]
2026-01-13 10:23     ` Heiko Stübner
2026-01-13 11:04   ` Lee Jones
2026-01-13 11:04     ` Lee Jones
2026-01-13 20:20   ` Ondřej Jirman
2026-01-13 20:20     ` Ondřej Jirman
2026-01-13  6:42 ` [PATCH 3/3] arm64: dts: rockchip: Remove interrupt GPIO for WiFi for the Pinephone Pro Rudraksha Gupta
2026-01-13  6:42   ` Rudraksha Gupta via B4 Relay
2026-01-13  6:42   ` Rudraksha Gupta via B4 Relay
2026-01-13  7:23   ` Krzysztof Kozlowski
2026-01-13  7:23     ` Krzysztof Kozlowski
2026-01-13 10:26   ` Heiko Stübner
2026-01-13 10:26     ` Heiko Stübner
2026-01-13 21:22   ` Ondřej Jirman
2026-01-13 21:22     ` Ondřej Jirman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2159404.K71DO8KEF6@diego \
    --to=heiko@sntech.de \
    --cc=ayufan@ayufan.eu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=guptarud@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=martijn@brixit.nl \
    --cc=megi@xff.cz \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.