All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos Corbacho <carlos@strangeworlds.co.uk>
To: Jyrki Kuoppala <jkp@iki.fi>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH] Fix to qt1010 tuner frequency selection (media/dvb)
Date: Wed, 19 Oct 2011 22:06:27 +0100	[thread overview]
Message-ID: <2165330.TqTdf0zloM@valkyrie> (raw)
In-Reply-To: <4E7F58BB.5080803@iki.fi>

Jyrki,

So after a bit more testing...

[...]

> >>        /* 22 */
> >>        if      (freq<  450000000) rd[15].val = 0xd0; /* 450 MHz
> >>        */
> >> 
> >> -    else if (freq<  482000000) rd[15].val = 0xd1; /* 482 MHz */
> >> +    else if (freq<  482000000) rd[15].val = 0xd2; /* 482 MHz */

This change isn't so good.

With this change, I can no longer tune to channel 21 (474 MHz). If I revert it 
back to 0xd1, it's fine.

[...]

> >> 
> >>        else if (freq<  514000000) rd[15].val = 0xd4; /* 514 MHz
> >>        */
> >> 
> >> -    else if (freq<  546000000) rd[15].val = 0xd7; /* 546 MHz */
> >> +    else if (freq<  546000000) rd[15].val = 0xd6; /* 546 MHz */
> >> +    else if (freq<  578000000) rd[15].val = 0xd8; /* 578 MHz */

(This change is still good though, as this does allow me to now tune to the 
BBC channels in this range).

-Carlos

  reply	other threads:[~2011-10-19 21:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22 17:19 [PATCH] Fix to qt1010 tuner frequency selection (media/dvb) Jyrki Kuoppala
2011-09-25 16:13 ` Carlos Corbacho
2011-09-25 16:37   ` Jyrki Kuoppala
2011-10-19 21:06     ` Carlos Corbacho [this message]
2011-10-20  4:45       ` Jyrki Kuoppala
2011-10-23  8:18         ` Carlos Corbacho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2165330.TqTdf0zloM@valkyrie \
    --to=carlos@strangeworlds.co.uk \
    --cc=jkp@iki.fi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.