From: Jyrki Kuoppala <jkp@iki.fi>
To: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH] Fix to qt1010 tuner frequency selection (media/dvb)
Date: Thu, 20 Oct 2011 07:45:45 +0300 [thread overview]
Message-ID: <4E9FA779.5040406@iki.fi> (raw)
In-Reply-To: <2165330.TqTdf0zloM@valkyrie>
I think my problem frequency has also been at the later spot. It is possible there is something more complicated going on at 474 MHz - so based on your testing, it's best to apply just the latter change, at least for now.
Jyrki
+ else if (freq< 546000000) rd[15].val = 0xd6; /* 546 MHz */
+ else if (freq< 546000000) rd[15].val = 0xd6; /* 546 MHz */
20.10.2011 00:06, Carlos Corbacho kirjoitti:
> Jyrki,
>
> So after a bit more testing...
>
> [...]
>
>>>> /* 22 */
>>>> if (freq< 450000000) rd[15].val = 0xd0; /* 450 MHz
>>>> */
>>>>
>>>> - else if (freq< 482000000) rd[15].val = 0xd1; /* 482 MHz */
>>>> + else if (freq< 482000000) rd[15].val = 0xd2; /* 482 MHz */
> This change isn't so good.
>
> With this change, I can no longer tune to channel 21 (474 MHz). If I revert it
> back to 0xd1, it's fine.
>
> [...]
>
>>>> else if (freq< 514000000) rd[15].val = 0xd4; /* 514 MHz
>>>> */
>>>>
>>>> - else if (freq< 546000000) rd[15].val = 0xd7; /* 546 MHz */
>>>> + else if (freq< 546000000) rd[15].val = 0xd6; /* 546 MHz */
>>>> + else if (freq< 578000000) rd[15].val = 0xd8; /* 578 MHz */
> (This change is still good though, as this does allow me to now tune to the
> BBC channels in this range).
>
> -Carlos
next prev parent reply other threads:[~2011-10-20 4:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 17:19 [PATCH] Fix to qt1010 tuner frequency selection (media/dvb) Jyrki Kuoppala
2011-09-25 16:13 ` Carlos Corbacho
2011-09-25 16:37 ` Jyrki Kuoppala
2011-10-19 21:06 ` Carlos Corbacho
2011-10-20 4:45 ` Jyrki Kuoppala [this message]
2011-10-23 8:18 ` Carlos Corbacho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9FA779.5040406@iki.fi \
--to=jkp@iki.fi \
--cc=carlos@strangeworlds.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.