All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: mturquette@baylibre.com, sboyd@kernel.org,
	sugar.zhang@rock-chips.com, zhangqing@rock-chips.com,
	robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, Elaine Zhang <zhangqing@rock-chips.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org, huangtao@rock-chips.com,
	finley.xiao@rock-chips.com
Subject: Re: [PATCH v4 4/7] dt-bindings: clock: Add support for rockchip pvtpll
Date: Tue, 21 Oct 2025 15:48:40 +0200	[thread overview]
Message-ID: <2168478.KlZ2vcFHjT@phil> (raw)
In-Reply-To: <20251021065232.2201500-5-zhangqing@rock-chips.com>

Hi Elaine,

Am Dienstag, 21. Oktober 2025, 08:52:29 Mitteleuropäische Sommerzeit schrieb Elaine Zhang:

> +  rockchip,cru:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: |
> +      Phandle to the main Clock and Reset Unit (CRU) controller.
> +      Required for PVTPLLs that need to interact with the main CRU
> +      for clock management operations.
> +

I don't think we want a whole syscon exposing the whole CRU unit to the
whole world, see comments in the pvtpll driver patch.

Thanks
Heiko




WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: mturquette@baylibre.com, sboyd@kernel.org,
	sugar.zhang@rock-chips.com, zhangqing@rock-chips.com,
	robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, Elaine Zhang <zhangqing@rock-chips.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org, huangtao@rock-chips.com,
	finley.xiao@rock-chips.com
Subject: Re: [PATCH v4 4/7] dt-bindings: clock: Add support for rockchip pvtpll
Date: Tue, 21 Oct 2025 15:48:40 +0200	[thread overview]
Message-ID: <2168478.KlZ2vcFHjT@phil> (raw)
In-Reply-To: <20251021065232.2201500-5-zhangqing@rock-chips.com>

Hi Elaine,

Am Dienstag, 21. Oktober 2025, 08:52:29 Mitteleuropäische Sommerzeit schrieb Elaine Zhang:

> +  rockchip,cru:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: |
> +      Phandle to the main Clock and Reset Unit (CRU) controller.
> +      Required for PVTPLLs that need to interact with the main CRU
> +      for clock management operations.
> +

I don't think we want a whole syscon exposing the whole CRU unit to the
whole world, see comments in the pvtpll driver patch.

Thanks
Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-10-21 13:48 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21  6:52 [Resend PATCH v4 0/7] clk: rockchip: Add clock controller for the RV1126B and RK3506 Elaine Zhang
2025-10-21  6:52 ` Elaine Zhang
2025-10-21  6:52 ` [PATCH v4 1/7] clk: rockchip: Implement rockchip_clk_register_armclk_multi_pll() Elaine Zhang
2025-10-21  6:52   ` Elaine Zhang
2025-10-21  6:52 ` [PATCH v4 2/7] dt-bindings: clock, reset: Add support for rv1126b Elaine Zhang
2025-10-21  6:52   ` Elaine Zhang
2025-10-21  8:38   ` Heiko Stuebner
2025-10-21  8:38     ` Heiko Stuebner
2025-10-22  3:21     ` zhangqing
2025-10-22  3:21       ` zhangqing
2025-10-22  9:52       ` Heiko Stuebner
2025-10-22  9:52         ` Heiko Stuebner
2025-10-23  8:43       ` [v4 " Markus Elfring
2025-10-23  8:43         ` Markus Elfring
2025-10-21  6:52 ` [PATCH v4 3/7] clk: rockchip: Add clock controller for the RV1126B Elaine Zhang
2025-10-21  6:52   ` Elaine Zhang
2025-10-21  6:52 ` [PATCH v4 4/7] dt-bindings: clock: Add support for rockchip pvtpll Elaine Zhang
2025-10-21  6:52   ` Elaine Zhang
2025-10-21 13:48   ` Heiko Stuebner [this message]
2025-10-21 13:48     ` Heiko Stuebner
2025-10-21  6:52 ` [PATCH v4 5/7] clk: rockchip: add support for pvtpll clk Elaine Zhang
2025-10-21  6:52   ` Elaine Zhang
2025-10-21 13:47   ` Heiko Stuebner
2025-10-21 13:47     ` Heiko Stuebner
2025-10-22  3:44     ` zhangqing
2025-10-22  3:44       ` zhangqing
2025-10-21  6:52 ` [PATCH v4 6/7] dt-bindings: clock: rockchip: Add RK3506 clock and reset unit Elaine Zhang
2025-10-21  6:52   ` Elaine Zhang
2025-10-21  8:36   ` Heiko Stuebner
2025-10-21  8:36     ` Heiko Stuebner
2025-10-24  7:14   ` Krzysztof Kozlowski
2025-10-24  7:14     ` Krzysztof Kozlowski
2025-10-21  6:52 ` [PATCH v4 7/7] clk: rockchip: Add clock and reset driver for RK3506 Elaine Zhang
2025-10-21  6:52   ` Elaine Zhang
2025-10-21  6:55 ` [Resend PATCH v4 0/7] clk: rockchip: Add clock controller for the RV1126B and RK3506 Heiko Stuebner
2025-10-21  6:55   ` Heiko Stuebner
  -- strict thread matches above, loose matches on Subject: below --
2025-10-21  3:38 [PATCH " Elaine Zhang
2025-10-21  3:38 ` [PATCH v4 4/7] dt-bindings: clock: Add support for rockchip pvtpll Elaine Zhang
2025-10-21  3:38   ` Elaine Zhang
2025-10-21  4:54   ` Rob Herring (Arm)
2025-10-21  4:54     ` Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2168478.KlZ2vcFHjT@phil \
    --to=heiko@sntech.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=finley.xiao@rock-chips.com \
    --cc=huangtao@rock-chips.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sugar.zhang@rock-chips.com \
    --cc=zhangqing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.