Re: [PATCH 8/9] ARM: multi_v7_defconfig: Add options to support TQMLS102xA series

From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
	Russell King <linux@armlinux.org.uk>, Marek Vasut <marex@denx.de>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: soc@kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 8/9] ARM: multi_v7_defconfig: Add options to support TQMLS102xA series
Date: Fri, 20 Jan 2023 12:12:39 +0100	[thread overview]
Message-ID: <2168770.1BCLMh4Saa@steina-w> (raw)
In-Reply-To: <acab1d7a-ef00-a3be-f73c-6cb9d01687b9@linaro.org>

Hi Krzysztof,

thanks for the feedback.

Am Donnerstag, 19. Januar 2023, 18:04:31 CET schrieb Krzysztof Kozlowski:
> On 19/01/2023 15:42, Alexander Stein wrote:
> > This enables drivers used on TQMLS102xA + MBLS1021A.
> 
> Do not use "This (commit/patch)".
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submit
> ting-patches.rst#L95

Thanks, this sounds much better.

> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > 
> >  arch/arm/configs/multi_v7_defconfig | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/arch/arm/configs/multi_v7_defconfig
> > b/arch/arm/configs/multi_v7_defconfig index ee184eb37adcf..441a449172368
> > 100644
> > --- a/arch/arm/configs/multi_v7_defconfig
> > +++ b/arch/arm/configs/multi_v7_defconfig
> > @@ -191,6 +191,7 @@ CONFIG_PCI_TEGRA=y
> > 
> >  CONFIG_PCI_RCAR_GEN2=y
> >  CONFIG_PCIE_RCAR_HOST=y
> >  CONFIG_PCI_DRA7XX_EP=y
> > 
> > +CONFIG_PCI_LAYERSCAPE=y
> > 
> >  CONFIG_PCI_ENDPOINT=y
> >  CONFIG_PCI_ENDPOINT_CONFIGFS=y
> >  CONFIG_PCI_EPF_TEST=m
> > 
> > @@ -249,6 +250,7 @@ CONFIG_AHCI_ST=y
> > 
> >  CONFIG_AHCI_IMX=y
> >  CONFIG_AHCI_SUNXI=y
> >  CONFIG_AHCI_TEGRA=y
> > 
> > +CONFIG_AHCI_QORIQ=y
> > 
> >  CONFIG_SATA_HIGHBANK=y
> >  CONFIG_SATA_MV=y
> >  CONFIG_SATA_RCAR=y
> > 
> > @@ -329,6 +331,7 @@ CONFIG_TOUCHSCREEN_ADC=m
> > 
> >  CONFIG_TOUCHSCREEN_ATMEL_MXT=m
> >  CONFIG_TOUCHSCREEN_ELAN=m
> >  CONFIG_TOUCHSCREEN_MMS114=m
> > 
> > +CONFIG_TOUCHSCREEN_EDT_FT5X06=m
> > 
> >  CONFIG_TOUCHSCREEN_WM97XX=m
> >  CONFIG_TOUCHSCREEN_ST1232=m
> >  CONFIG_TOUCHSCREEN_STMPE=y
> > 
> > @@ -483,6 +486,7 @@ CONFIG_GPIO_ASPEED_SGPIO=y
> > 
> >  CONFIG_GPIO_DAVINCI=y
> >  CONFIG_GPIO_DWAPB=y
> >  CONFIG_GPIO_EM=y
> > 
> > +CONFIG_GPIO_MPC8XXX=y
> 
> module

Sounds reasonable, but it's not actually possible, it's just a bool.

> >  CONFIG_GPIO_MXC=y
> >  CONFIG_GPIO_RCAR=y
> >  CONFIG_GPIO_SYSCON=y
> > 
> > @@ -493,6 +497,7 @@ CONFIG_GPIO_PCA953X=y
> > 
> >  CONFIG_GPIO_PCA953X_IRQ=y
> >  CONFIG_GPIO_PCF857X=y
> >  CONFIG_GPIO_PALMAS=y
> > 
> > +CONFIG_GPIO_STMPE=y
> 
> module

That one as well, it's just a bool.

> >  CONFIG_GPIO_TPS6586X=y
> >  CONFIG_GPIO_TPS65910=y
> >  CONFIG_GPIO_TWL4030=y
> > 
> > @@ -533,6 +538,7 @@ CONFIG_SENSORS_INA2XX=m
> > 
> >  CONFIG_CPU_THERMAL=y
> >  CONFIG_DEVFREQ_THERMAL=y
> >  CONFIG_IMX_THERMAL=y
> > 
> > +CONFIG_QORIQ_THERMAL=m
> > 
> >  CONFIG_ROCKCHIP_THERMAL=y
> >  CONFIG_RCAR_THERMAL=y
> >  CONFIG_ARMADA_THERMAL=y
> > 
> > @@ -821,6 +827,8 @@ CONFIG_SND_SOC_MSM8916_WCD_ANALOG=m
> > 
> >  CONFIG_SND_SOC_MSM8916_WCD_DIGITAL=m
> >  CONFIG_SND_SOC_SGTL5000=m
> >  CONFIG_SND_SOC_STI_SAS=m
> > 
> > +CONFIG_SND_SOC_TLV320AIC32X4=m
> > +CONFIG_SND_SOC_TLV320AIC32X4_I2C=m
> > 
> >  CONFIG_SND_SOC_WM8978=m
> >  CONFIG_SND_AUDIO_GRAPH_CARD=m
> >  CONFIG_USB=y
> > 
> > @@ -830,6 +838,7 @@ CONFIG_USB_XHCI_MVEBU=y
> > 
> >  CONFIG_USB_XHCI_TEGRA=m
> >  CONFIG_USB_BRCMSTB=m
> >  CONFIG_USB_EHCI_HCD=y
> > 
> > +CONFIG_USB_EHCI_FSL=y
> 
> module

Well, apparently module autoload is broken due to wrong modalias value of ehci 
node created by fsl-mph-dr-of. This setting this as a module is currently not 
working.

> >  CONFIG_USB_EHCI_HCD_STI=y
> >  CONFIG_USB_EHCI_EXYNOS=m
> >  CONFIG_USB_EHCI_MV=m
> > 
> > @@ -933,6 +942,8 @@ CONFIG_NEW_LEDS=y
> > 
> >  CONFIG_LEDS_CLASS=y
> >  CONFIG_LEDS_CLASS_FLASH=m
> >  CONFIG_LEDS_CPCAP=m
> > 
> > +CONFIG_LEDS_PCA9532=m
> > +CONFIG_LEDS_PCA9532_GPIO=y
> > 
> >  CONFIG_LEDS_GPIO=y
> >  CONFIG_LEDS_PWM=y
> >  CONFIG_LEDS_MAX8997=m
> > 
> > @@ -949,6 +960,7 @@ CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
> > 
> >  CONFIG_LEDS_TRIGGER_TRANSIENT=y
> >  CONFIG_LEDS_TRIGGER_CAMERA=y
> >  CONFIG_EDAC=y
> > 
> > +CONFIG_EDAC_LAYERSCAPE=y
> > 
> >  CONFIG_EDAC_HIGHBANK_MC=y
> >  CONFIG_EDAC_HIGHBANK_L2=y
> >  CONFIG_RTC_CLASS=y
> > 
> > @@ -962,6 +974,7 @@ CONFIG_RTC_DRV_MAX8997=m
> > 
> >  CONFIG_RTC_DRV_MAX77686=y
> >  CONFIG_RTC_DRV_RK808=m
> >  CONFIG_RTC_DRV_RS5C372=m
> > 
> > +CONFIG_RTC_DRV_PCF85063=y
> 
> module

Okay, module it is. So I assume it is acceptable the system time is set much 
later after mounting rootfs then?

> >  CONFIG_RTC_DRV_PCF85363=m
> >  CONFIG_RTC_DRV_BQ32K=m
> >  CONFIG_RTC_DRV_TWL4030=y
> 
> Best regards,
> Krzysztof

Best regards,
Alexander