From: Thomas Monjalon <thomas@monjalon.net>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: dev@dpdk.org, "Van Haaren, Harry" <harry.van.haaren@intel.com>
Subject: Re: [PATCH] event/sw: fix events mis-identified as needing reorder
Date: Thu, 20 Apr 2017 00:31:16 +0200 [thread overview]
Message-ID: <2176270.5Bc8X6HNAl@xps> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA612A2D4C8@IRSMSX102.ger.corp.intel.com>
14/04/2017 17:28, Van Haaren, Harry:
> From: Richardson, Bruce
> Sent: Friday, April 14, 2017 4:18 PM
> >
> > When taking events from a port, we checked the history list to check if
> > the
> > event needed to be put back in order i.e. originally came from a reordered
> > queue type. The check for reordering involved checking if the reorder
> > buffer entry pointer was null. However, after that pointer was used it was
> > never cleared to null again.
> >
> > This caused problems when we had mixed reordered and atomic or parallel
> > events, as the events from the latter two queue types were misidentified
> > as
> > needing reordering. This let in some cases to crashes, but mostly led to
> > dropping events, and then application lock-up.
> >
> > Fixes: 617995dfc5b2 ("event/sw: add scheduling logic")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> +CC Thomas, would you pick this directly to master please, as no
> next-eventdev will be merged, thanks.
>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied, thanks
prev parent reply other threads:[~2017-04-19 22:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 15:18 [PATCH] event/sw: fix events mis-identified as needing reorder Bruce Richardson
2017-04-14 15:28 ` Van Haaren, Harry
2017-04-19 22:31 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2176270.5Bc8X6HNAl@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.