All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Finley Xiao <finley.xiao@rock-chips.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	ulf.hansson@linaro.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, finley.xiao@rock-chips.com,
	zhangqing@rock-chips.com, sugar.zhang@rock-chips.com,
	huangtao@rock-chips.com
Subject: Re: [PATCH v1 2/2] pmdomain: rockchip: Add support for RV1126B
Date: Thu, 16 Oct 2025 18:13:34 +0200	[thread overview]
Message-ID: <2176528.bB369e8A3T@diego> (raw)
In-Reply-To: <20251016134103.294636-3-finley.xiao@rock-chips.com>

Am Donnerstag, 16. Oktober 2025, 15:41:03 Mitteleuropäische Sommerzeit schrieb Finley Xiao:
> Add configuration and power domains for RV1126 SoC.
> 
> Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> ---

[...]

> @@ -1104,6 +1122,13 @@ static const struct rockchip_domain_info rv1126_pm_domains[] = {
>  	[RV1126_PD_USB]		= DOMAIN_RV1126("usb", BIT(9), BIT(15), BIT(15),  false),
>  };
>  
> +static const struct rockchip_domain_info rv1126b_pm_domains[] = {
> +					      /* name    pwr     req      wakeup */
> +	[RV1126B_PD_NPU]	= DOMAIN_RV1126B("npu",  BIT(0), BIT(8),  false),
> +	[RV1126B_PD_VDO]	= DOMAIN_RV1126B("vdo",  BIT(1), BIT(9),  false),
> +	[RV1126B_PD_AISP]	= DOMAIN_RV1126B("aisp", BIT(2), BIT(10), false),
> +};
> +

same clarification needed as for patch 1 ... is it aiisp (with 2 "i")?
As described everywhere in the TRM.

Other than that I checked the bits and registers against the TRM, so

Reviewed-by: Heiko Stuebner <heiko@sntech.de>


Heiko




WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Finley Xiao <finley.xiao@rock-chips.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	ulf.hansson@linaro.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, finley.xiao@rock-chips.com,
	zhangqing@rock-chips.com, sugar.zhang@rock-chips.com,
	huangtao@rock-chips.com
Subject: Re: [PATCH v1 2/2] pmdomain: rockchip: Add support for RV1126B
Date: Thu, 16 Oct 2025 18:13:34 +0200	[thread overview]
Message-ID: <2176528.bB369e8A3T@diego> (raw)
In-Reply-To: <20251016134103.294636-3-finley.xiao@rock-chips.com>

Am Donnerstag, 16. Oktober 2025, 15:41:03 Mitteleuropäische Sommerzeit schrieb Finley Xiao:
> Add configuration and power domains for RV1126 SoC.
> 
> Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> ---

[...]

> @@ -1104,6 +1122,13 @@ static const struct rockchip_domain_info rv1126_pm_domains[] = {
>  	[RV1126_PD_USB]		= DOMAIN_RV1126("usb", BIT(9), BIT(15), BIT(15),  false),
>  };
>  
> +static const struct rockchip_domain_info rv1126b_pm_domains[] = {
> +					      /* name    pwr     req      wakeup */
> +	[RV1126B_PD_NPU]	= DOMAIN_RV1126B("npu",  BIT(0), BIT(8),  false),
> +	[RV1126B_PD_VDO]	= DOMAIN_RV1126B("vdo",  BIT(1), BIT(9),  false),
> +	[RV1126B_PD_AISP]	= DOMAIN_RV1126B("aisp", BIT(2), BIT(10), false),
> +};
> +

same clarification needed as for patch 1 ... is it aiisp (with 2 "i")?
As described everywhere in the TRM.

Other than that I checked the bits and registers against the TRM, so

Reviewed-by: Heiko Stuebner <heiko@sntech.de>


Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-10-16 16:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16 13:41 [PATCH v1 0/2] Add power-controller support for RV1126B Finley Xiao
2025-10-16 13:41 ` Finley Xiao
2025-10-16 13:41 ` [PATCH v1 1/2] dt-bindings: power: rockchip: Add " Finley Xiao
2025-10-16 13:41   ` Finley Xiao
2025-10-16 16:06   ` Heiko Stübner
2025-10-16 16:06     ` Heiko Stübner
2025-10-16 17:27   ` Krzysztof Kozlowski
2025-10-16 17:27     ` Krzysztof Kozlowski
     [not found]     ` <494b724d-31e3-45f1-9cc2-ac64851a6f70@rock-chips.com>
2025-10-17  9:01       ` Krzysztof Kozlowski
2025-10-17  9:01         ` Krzysztof Kozlowski
2025-10-16 13:41 ` [PATCH v1 2/2] pmdomain: " Finley Xiao
2025-10-16 13:41   ` Finley Xiao
2025-10-16 16:13   ` Heiko Stübner [this message]
2025-10-16 16:13     ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2176528.bB369e8A3T@diego \
    --to=heiko@sntech.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=finley.xiao@rock-chips.com \
    --cc=huangtao@rock-chips.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=sugar.zhang@rock-chips.com \
    --cc=ulf.hansson@linaro.org \
    --cc=zhangqing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.