From: David Howells <dhowells@redhat.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-mm <linux-mm@kvack.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH/RFC] remove frv usage of flush_tlb_pgtables()
Date: Fri, 27 Jul 2007 10:43:58 +0100 [thread overview]
Message-ID: <21776.1185529438@redhat.com> (raw)
In-Reply-To: <1185493838.5495.144.camel@localhost.localdomain>
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> frv is the last user in the tree of that dubious hook, and it's my
> understanding that it's not even needed. It's only called by memory.c
> free_pgd_range() which is always called within an mmu_gather, and
> tlb_flush() on frv will do a flush_tlb_mm(), which from my reading
> of the code, seems to do what flush_tlb_ptables() does, which is
> to clear the cached PGE.
Yeah... I hadn't got around to killing myself yet.
Acked-By: David Howells <dhowells@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-mm <linux-mm@kvack.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH/RFC] remove frv usage of flush_tlb_pgtables()
Date: Fri, 27 Jul 2007 10:43:58 +0100 [thread overview]
Message-ID: <21776.1185529438@redhat.com> (raw)
In-Reply-To: <1185493838.5495.144.camel@localhost.localdomain>
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> frv is the last user in the tree of that dubious hook, and it's my
> understanding that it's not even needed. It's only called by memory.c
> free_pgd_range() which is always called within an mmu_gather, and
> tlb_flush() on frv will do a flush_tlb_mm(), which from my reading
> of the code, seems to do what flush_tlb_ptables() does, which is
> to clear the cached PGE.
Yeah... I hadn't got around to killing myself yet.
Acked-By: David Howells <dhowells@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-07-27 9:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 23:50 [PATCH/RFC] remove frv usage of flush_tlb_pgtables() Benjamin Herrenschmidt
2007-07-26 23:50 ` Benjamin Herrenschmidt
2007-07-27 9:43 ` David Howells [this message]
2007-07-27 9:43 ` David Howells
2007-07-27 12:37 ` Benjamin Herrenschmidt
2007-07-27 12:37 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21776.1185529438@redhat.com \
--to=dhowells@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.