From: "Heiko Stübner" <heiko.stuebner@collabora.com>
To: linux-rockchip@lists.infradead.org
Cc: linux-clk@vger.kernel.org, dianders@chromium.org,
mturquette@baylibre.com, sboyd@codeaurora.org,
Chris Zhong <zyw@rock-chips.com>
Subject: Re: [PATCH] clk: rockchip: only enter pll slow-mode directly before reboots on rk3288
Date: Mon, 21 Dec 2015 02:06:10 +0100 [thread overview]
Message-ID: <2178082.zdAf6brHOY@diego> (raw)
In-Reply-To: <1705995.CL2pqRBHZb@diego>
Am Freitag, 18. Dezember 2015, 19:33:50 schrieb Heiko St=FCbner:
> As commit 1d33929e2a2b ("clk: rockchip: switch PLLs to slow mode befo=
re
> reboot for rk3288") states, switching the PLLs to slow-mode is only
> necessary when rebooting using the soft-reset done through the CRU.
>=20
> The dwc2 controllers used create really big number of interrupts in
> special constellations involving usb-hubs and their number is so high=
,
> it can even overwhelm the interrupt handler if the cpu-speed os to lo=
w.
>=20
> Right now the PLLs are put into slow-mode in a shutdown syscore_ops
> callback which means it happens on all reboots (not only the soft-res=
et
> ones) and even on poweroff actions.
>=20
> This can result in the system not powering off and getting stuck inst=
ead,
> so we should move the slow-mode change nearer to the actual reboot ac=
tion.
>=20
> For this we introduce the possiblity to also set a callback that gets=
> called from the restart-handler directly prior to restarting the syst=
em
> and move the shutdown-callback to this new option.
>=20
> With this the slow-mode switch is done only on the necessary reboots
> and also has a smaller possibility of causing artifacts.
>=20
> Fixes: 1d33929e2a2b ("clk: rockchip: switch PLLs to slow mode before =
reboot
> for rk3288") Signed-off-by: Heiko Stuebner <heiko.stuebner@collabora.=
com>
applied to my clk branch for 4.5
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko.stuebner@collabora.com>
To: linux-rockchip@lists.infradead.org
Cc: linux-clk@vger.kernel.org, dianders@chromium.org,
mturquette@baylibre.com, sboyd@codeaurora.org,
Chris Zhong <zyw@rock-chips.com>
Subject: Re: [PATCH] clk: rockchip: only enter pll slow-mode directly before reboots on rk3288
Date: Mon, 21 Dec 2015 02:06:10 +0100 [thread overview]
Message-ID: <2178082.zdAf6brHOY@diego> (raw)
In-Reply-To: <1705995.CL2pqRBHZb@diego>
Am Freitag, 18. Dezember 2015, 19:33:50 schrieb Heiko Stübner:
> As commit 1d33929e2a2b ("clk: rockchip: switch PLLs to slow mode before
> reboot for rk3288") states, switching the PLLs to slow-mode is only
> necessary when rebooting using the soft-reset done through the CRU.
>
> The dwc2 controllers used create really big number of interrupts in
> special constellations involving usb-hubs and their number is so high,
> it can even overwhelm the interrupt handler if the cpu-speed os to low.
>
> Right now the PLLs are put into slow-mode in a shutdown syscore_ops
> callback which means it happens on all reboots (not only the soft-reset
> ones) and even on poweroff actions.
>
> This can result in the system not powering off and getting stuck instead,
> so we should move the slow-mode change nearer to the actual reboot action.
>
> For this we introduce the possiblity to also set a callback that gets
> called from the restart-handler directly prior to restarting the system
> and move the shutdown-callback to this new option.
>
> With this the slow-mode switch is done only on the necessary reboots
> and also has a smaller possibility of causing artifacts.
>
> Fixes: 1d33929e2a2b ("clk: rockchip: switch PLLs to slow mode before reboot
> for rk3288") Signed-off-by: Heiko Stuebner <heiko.stuebner@collabora.com>
applied to my clk branch for 4.5
next prev parent reply other threads:[~2015-12-21 1:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 18:33 [PATCH] clk: rockchip: only enter pll slow-mode directly before reboots on rk3288 Heiko Stübner
2015-12-18 22:40 ` Doug Anderson
2015-12-18 22:40 ` Doug Anderson
2015-12-21 1:06 ` Heiko Stübner [this message]
2015-12-21 1:06 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2178082.zdAf6brHOY@diego \
--to=heiko.stuebner@collabora.com \
--cc=dianders@chromium.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.