All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Heiko Stuebner <heiko.stuebner@cherry.de>,
	Dan Carpenter <dan.carpenter@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] phy: rockchip-samsung-dcphy: Add missing assignment
Date: Fri, 21 Mar 2025 18:08:26 +0100	[thread overview]
Message-ID: <2181342.OBFZWjSADL@phil> (raw)
In-Reply-To: <e64265a4-9543-4728-a49f-ea910fccef7c@stanley.mountain>

Hey Dan,

Am Freitag, 21. März 2025, 15:36:14 MEZ schrieb Dan Carpenter:
> The "ret = " was accidentally dropped so the error handling doesn't work.
> 
> Fixes: b2a1a2ae7818 ("phy: rockchip: Add Samsung MIPI D-/C-PHY driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

oh darn ... thanks so much for catching that

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c b/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c
> index 08c78c1bafc9..28a052e17366 100644
> --- a/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c
> +++ b/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c
> @@ -1653,7 +1653,7 @@ static __maybe_unused int samsung_mipi_dcphy_runtime_resume(struct device *dev)
>  		return ret;
>  	}
>  
> -	clk_prepare_enable(samsung->ref_clk);
> +	ret = clk_prepare_enable(samsung->ref_clk);
>  	if (ret) {
>  		dev_err(samsung->dev, "Failed to enable reference clock, %d\n", ret);
>  		clk_disable_unprepare(samsung->pclk);
> 





WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Heiko Stuebner <heiko.stuebner@cherry.de>,
	Dan Carpenter <dan.carpenter@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] phy: rockchip-samsung-dcphy: Add missing assignment
Date: Fri, 21 Mar 2025 18:08:26 +0100	[thread overview]
Message-ID: <2181342.OBFZWjSADL@phil> (raw)
In-Reply-To: <e64265a4-9543-4728-a49f-ea910fccef7c@stanley.mountain>

Hey Dan,

Am Freitag, 21. März 2025, 15:36:14 MEZ schrieb Dan Carpenter:
> The "ret = " was accidentally dropped so the error handling doesn't work.
> 
> Fixes: b2a1a2ae7818 ("phy: rockchip: Add Samsung MIPI D-/C-PHY driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

oh darn ... thanks so much for catching that

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c b/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c
> index 08c78c1bafc9..28a052e17366 100644
> --- a/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c
> +++ b/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c
> @@ -1653,7 +1653,7 @@ static __maybe_unused int samsung_mipi_dcphy_runtime_resume(struct device *dev)
>  		return ret;
>  	}
>  
> -	clk_prepare_enable(samsung->ref_clk);
> +	ret = clk_prepare_enable(samsung->ref_clk);
>  	if (ret) {
>  		dev_err(samsung->dev, "Failed to enable reference clock, %d\n", ret);
>  		clk_disable_unprepare(samsung->pclk);
> 





-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Heiko Stuebner <heiko.stuebner@cherry.de>,
	Dan Carpenter <dan.carpenter@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] phy: rockchip-samsung-dcphy: Add missing assignment
Date: Fri, 21 Mar 2025 18:08:26 +0100	[thread overview]
Message-ID: <2181342.OBFZWjSADL@phil> (raw)
In-Reply-To: <e64265a4-9543-4728-a49f-ea910fccef7c@stanley.mountain>

Hey Dan,

Am Freitag, 21. März 2025, 15:36:14 MEZ schrieb Dan Carpenter:
> The "ret = " was accidentally dropped so the error handling doesn't work.
> 
> Fixes: b2a1a2ae7818 ("phy: rockchip: Add Samsung MIPI D-/C-PHY driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

oh darn ... thanks so much for catching that

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c b/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c
> index 08c78c1bafc9..28a052e17366 100644
> --- a/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c
> +++ b/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c
> @@ -1653,7 +1653,7 @@ static __maybe_unused int samsung_mipi_dcphy_runtime_resume(struct device *dev)
>  		return ret;
>  	}
>  
> -	clk_prepare_enable(samsung->ref_clk);
> +	ret = clk_prepare_enable(samsung->ref_clk);
>  	if (ret) {
>  		dev_err(samsung->dev, "Failed to enable reference clock, %d\n", ret);
>  		clk_disable_unprepare(samsung->pclk);
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-03-21 17:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-21 14:36 [PATCH next] phy: rockchip-samsung-dcphy: Add missing assignment Dan Carpenter
2025-03-21 14:36 ` Dan Carpenter
2025-03-21 14:36 ` Dan Carpenter
2025-03-21 17:08 ` Heiko Stuebner [this message]
2025-03-21 17:08   ` Heiko Stuebner
2025-03-21 17:08   ` Heiko Stuebner
2025-04-11 12:10 ` Vinod Koul
2025-04-11 12:10   ` Vinod Koul
2025-04-11 12:10   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2181342.OBFZWjSADL@phil \
    --to=heiko@sntech.de \
    --cc=dan.carpenter@linaro.org \
    --cc=heiko.stuebner@cherry.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kishon@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.