All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Elaine Zhang <zhangqing@rock-chips.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org,
	linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org, xxx@rock-chips.com,
	xf@rock-chips.com, huangtao@rock-chips.com,
	kever.yang@rock-chips.com,
	Elaine Zhang <zhangqing@rock-chips.com>
Subject: Re: [PATCH v3 3/6] clk: rockchip: Export rockchip_register_softrst()
Date: Mon, 07 Sep 2020 00:35:37 +0200	[thread overview]
Message-ID: <2186827.9gi7mZr2Dv@diego> (raw)
In-Reply-To: <20200904074405.24439-4-zhangqing@rock-chips.com>

Am Freitag, 4. September 2020, 09:44:02 CEST schrieb Elaine Zhang:
> This is used by the Rockchip clk driver, export it to allow that
> driver to be compiled as a module..
> 
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>  drivers/clk/rockchip/softrst.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/clk/rockchip/softrst.c b/drivers/clk/rockchip/softrst.c
> index 5f1ff5e47c4f..caba9055090b 100644
> --- a/drivers/clk/rockchip/softrst.c
> +++ b/drivers/clk/rockchip/softrst.c
> @@ -77,9 +77,9 @@ static const struct reset_control_ops rockchip_softrst_ops = {
>  	.deassert	= rockchip_softrst_deassert,
>  };
>  
> -void __init rockchip_register_softrst(struct device_node *np,
> -				      unsigned int num_regs,
> -				      void __iomem *base, u8 flags)
> +void rockchip_register_softrst(struct device_node *np,
> +			       unsigned int num_regs,
> +			       void __iomem *base, u8 flags)
>  {
>  	struct rockchip_softrst *softrst;
>  	int ret;
> @@ -107,3 +107,4 @@ void __init rockchip_register_softrst(struct device_node *np,
>  		kfree(softrst);
>  	}
>  };
> +EXPORT_SYMBOL(rockchip_register_softrst);

Same comment about EXPORT_SYMBOL_GPL perhaps?





WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Elaine Zhang <zhangqing@rock-chips.com>
Cc: huangtao@rock-chips.com, xf@rock-chips.com, sboyd@kernel.org,
	mturquette@baylibre.com, Elaine Zhang <zhangqing@rock-chips.com>,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	kever.yang@rock-chips.com, linux-rockchip@lists.infradead.org,
	xxx@rock-chips.com
Subject: Re: [PATCH v3 3/6] clk: rockchip: Export rockchip_register_softrst()
Date: Mon, 07 Sep 2020 00:35:37 +0200	[thread overview]
Message-ID: <2186827.9gi7mZr2Dv@diego> (raw)
In-Reply-To: <20200904074405.24439-4-zhangqing@rock-chips.com>

Am Freitag, 4. September 2020, 09:44:02 CEST schrieb Elaine Zhang:
> This is used by the Rockchip clk driver, export it to allow that
> driver to be compiled as a module..
> 
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>  drivers/clk/rockchip/softrst.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/clk/rockchip/softrst.c b/drivers/clk/rockchip/softrst.c
> index 5f1ff5e47c4f..caba9055090b 100644
> --- a/drivers/clk/rockchip/softrst.c
> +++ b/drivers/clk/rockchip/softrst.c
> @@ -77,9 +77,9 @@ static const struct reset_control_ops rockchip_softrst_ops = {
>  	.deassert	= rockchip_softrst_deassert,
>  };
>  
> -void __init rockchip_register_softrst(struct device_node *np,
> -				      unsigned int num_regs,
> -				      void __iomem *base, u8 flags)
> +void rockchip_register_softrst(struct device_node *np,
> +			       unsigned int num_regs,
> +			       void __iomem *base, u8 flags)
>  {
>  	struct rockchip_softrst *softrst;
>  	int ret;
> @@ -107,3 +107,4 @@ void __init rockchip_register_softrst(struct device_node *np,
>  		kfree(softrst);
>  	}
>  };
> +EXPORT_SYMBOL(rockchip_register_softrst);

Same comment about EXPORT_SYMBOL_GPL perhaps?





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2020-09-06 22:35 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04  7:43 [PATCH v3 0/6] clk: rockchip: Support module build Elaine Zhang
2020-09-04  7:43 ` Elaine Zhang
2020-09-04  7:44 ` [PATCH v3 1/6] clk: rockchip: Use clk_hw_register_composite instead of clk_register_composite calls Elaine Zhang
2020-09-04  7:44   ` Elaine Zhang
2020-09-06 22:45   ` Heiko Stübner
2020-09-06 22:45     ` Heiko Stübner
2020-09-04  7:44 ` [PATCH v3 2/6] clk: rockchip: Export rockchip_clk_register_ddrclk() Elaine Zhang
2020-09-04  7:44   ` Elaine Zhang
2020-09-06 22:34   ` Heiko Stübner
2020-09-06 22:34     ` Heiko Stübner
2020-09-04  7:44 ` [PATCH v3 3/6] clk: rockchip: Export rockchip_register_softrst() Elaine Zhang
2020-09-04  7:44   ` Elaine Zhang
2020-09-06 22:35   ` Heiko Stübner [this message]
2020-09-06 22:35     ` Heiko Stübner
2020-09-04  7:44 ` [PATCH v3 4/6] clk: rockchip: Export some clock common APIs for module drivers Elaine Zhang
2020-09-04  7:44   ` Elaine Zhang
2020-09-06 22:45   ` Heiko Stübner
2020-09-06 22:45     ` Heiko Stübner
2020-09-04  7:44 ` [PATCH v3 5/6] clk: rockchip: fix the clk config to support module build Elaine Zhang
2020-09-04  7:44   ` Elaine Zhang
2020-09-06 22:42   ` Heiko Stübner
2020-09-06 22:42     ` Heiko Stübner
2020-09-04  7:45 ` [PATCH v3 6/6] clk: rockchip: rk3399: Support " Elaine Zhang
2020-09-04  7:45   ` Elaine Zhang
2020-09-06 22:49   ` Heiko Stübner
2020-09-06 22:49     ` Heiko Stübner
2020-09-10  3:07     ` elaine.zhang
2020-09-10  3:07       ` elaine.zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2186827.9gi7mZr2Dv@diego \
    --to=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=kever.yang@rock-chips.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=xf@rock-chips.com \
    --cc=xxx@rock-chips.com \
    --cc=zhangqing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.