All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Jianfeng Liu <liujianfeng1994@gmail.com>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, ezequiel@vanguardiasur.com.ar,
	p.zabel@pengutronix.de, mchehab@kernel.org,
	Nicolas Dufresne <nicolas@ndufresne.ca>
Cc: sfr@canb.auug.org.au, Ezequiel Garcia <elezegarcia@gmail.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	knaerzche@gmail.com, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v3 0/2] [v3]Add hantro g1 video decoder support for RK3588
Date: Wed, 17 Jan 2024 22:12:42 +0100	[thread overview]
Message-ID: <2196595.7aRn1RRit1@diego> (raw)
In-Reply-To: <5490507acc121113e52a8cdddb155fddf6dbb374.camel@ndufresne.ca>

Hi Nicolas,

Am Mittwoch, 17. Januar 2024, 20:16:24 CET schrieb Nicolas Dufresne:
> Le dimanche 31 décembre 2023 à 23:11 +0800, Jianfeng Liu a écrit :
> > This is the v3 version of this series adding hantro g1 video decoder
> > support for rk3588.
> > 
> > RK3588 has Hantro G1 video decoder known as VDPU121 in TRM of RK3588 which
> > is capable to decode MPEG2/H.264/VP8 up to 1920x1088. This vpu ip is also
> > found in RK3568.
> 
> The only concern I have is that we rejected enabling this VPU on RK3399, since
> having two H.264 decoders was confusing userspace softwares at the time, causing
> the slow one to be picked sometimes. I know the selection is not fully
> implemented in GStreamer either, not sure for LibreELEC ffmpeg fork, Chromium or
> Cros-codec.
> 
> Of course, its not a problem now, but only when someone provides an rkvdec2
> driver that enables the much more capable HW decoder. Shall we hold on H.264
> mainline for now ?

hmm, reading the TRM the VDPU121 claims to support:
- VP8
- VC1
- MPEG-1,2,4
- H.263
- JPEG

So at least the TRM doesn't list h.264 as supported at all on VDPU121 .
Not sure what is up with that or is Rockchip also just suggesting that h.264
should be in the VDPU381 [where h.264 is listed as featured] ?


Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Jianfeng Liu <liujianfeng1994@gmail.com>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, ezequiel@vanguardiasur.com.ar,
	p.zabel@pengutronix.de, mchehab@kernel.org,
	Nicolas Dufresne <nicolas@ndufresne.ca>
Cc: sfr@canb.auug.org.au, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, sigmaris@gmail.com,
	knaerzche@gmail.com, Ezequiel Garcia <elezegarcia@gmail.com>
Subject: Re: [PATCH v3 0/2] [v3]Add hantro g1 video decoder support for RK3588
Date: Wed, 17 Jan 2024 22:12:42 +0100	[thread overview]
Message-ID: <2196595.7aRn1RRit1@diego> (raw)
In-Reply-To: <5490507acc121113e52a8cdddb155fddf6dbb374.camel@ndufresne.ca>

Hi Nicolas,

Am Mittwoch, 17. Januar 2024, 20:16:24 CET schrieb Nicolas Dufresne:
> Le dimanche 31 décembre 2023 à 23:11 +0800, Jianfeng Liu a écrit :
> > This is the v3 version of this series adding hantro g1 video decoder
> > support for rk3588.
> > 
> > RK3588 has Hantro G1 video decoder known as VDPU121 in TRM of RK3588 which
> > is capable to decode MPEG2/H.264/VP8 up to 1920x1088. This vpu ip is also
> > found in RK3568.
> 
> The only concern I have is that we rejected enabling this VPU on RK3399, since
> having two H.264 decoders was confusing userspace softwares at the time, causing
> the slow one to be picked sometimes. I know the selection is not fully
> implemented in GStreamer either, not sure for LibreELEC ffmpeg fork, Chromium or
> Cros-codec.
> 
> Of course, its not a problem now, but only when someone provides an rkvdec2
> driver that enables the much more capable HW decoder. Shall we hold on H.264
> mainline for now ?

hmm, reading the TRM the VDPU121 claims to support:
- VP8
- VC1
- MPEG-1,2,4
- H.263
- JPEG

So at least the TRM doesn't list h.264 as supported at all on VDPU121 .
Not sure what is up with that or is Rockchip also just suggesting that h.264
should be in the VDPU381 [where h.264 is listed as featured] ?


Heiko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Jianfeng Liu <liujianfeng1994@gmail.com>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, ezequiel@vanguardiasur.com.ar,
	p.zabel@pengutronix.de, mchehab@kernel.org,
	Nicolas Dufresne <nicolas@ndufresne.ca>
Cc: sfr@canb.auug.org.au, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, sigmaris@gmail.com,
	knaerzche@gmail.com, Ezequiel Garcia <elezegarcia@gmail.com>
Subject: Re: [PATCH v3 0/2] [v3]Add hantro g1 video decoder support for RK3588
Date: Wed, 17 Jan 2024 22:12:42 +0100	[thread overview]
Message-ID: <2196595.7aRn1RRit1@diego> (raw)
In-Reply-To: <5490507acc121113e52a8cdddb155fddf6dbb374.camel@ndufresne.ca>

Hi Nicolas,

Am Mittwoch, 17. Januar 2024, 20:16:24 CET schrieb Nicolas Dufresne:
> Le dimanche 31 décembre 2023 à 23:11 +0800, Jianfeng Liu a écrit :
> > This is the v3 version of this series adding hantro g1 video decoder
> > support for rk3588.
> > 
> > RK3588 has Hantro G1 video decoder known as VDPU121 in TRM of RK3588 which
> > is capable to decode MPEG2/H.264/VP8 up to 1920x1088. This vpu ip is also
> > found in RK3568.
> 
> The only concern I have is that we rejected enabling this VPU on RK3399, since
> having two H.264 decoders was confusing userspace softwares at the time, causing
> the slow one to be picked sometimes. I know the selection is not fully
> implemented in GStreamer either, not sure for LibreELEC ffmpeg fork, Chromium or
> Cros-codec.
> 
> Of course, its not a problem now, but only when someone provides an rkvdec2
> driver that enables the much more capable HW decoder. Shall we hold on H.264
> mainline for now ?

hmm, reading the TRM the VDPU121 claims to support:
- VP8
- VC1
- MPEG-1,2,4
- H.263
- JPEG

So at least the TRM doesn't list h.264 as supported at all on VDPU121 .
Not sure what is up with that or is Rockchip also just suggesting that h.264
should be in the VDPU381 [where h.264 is listed as featured] ?


Heiko



  reply	other threads:[~2024-01-17 21:13 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-31 15:11 [PATCH v3 0/2] [v3]Add hantro g1 video decoder support for RK3588 Jianfeng Liu
2023-12-31 15:11 ` Jianfeng Liu
2023-12-31 15:11 ` Jianfeng Liu
2023-12-31 15:11 ` [PATCH v3 1/2] arm64: dts: rockchip: Add Hantro G1 VPU " Jianfeng Liu
2023-12-31 15:11   ` Jianfeng Liu
2023-12-31 15:11   ` Jianfeng Liu
2024-01-17 19:13   ` Nicolas Dufresne
2024-01-17 19:13     ` Nicolas Dufresne
2024-01-17 19:13     ` Nicolas Dufresne
2024-01-18  8:06     ` amazingfate
2024-01-18  8:06       ` amazingfate
2024-01-18  8:06       ` amazingfate
2024-01-18 21:44       ` Nicolas Dufresne
2024-01-18 21:44         ` Nicolas Dufresne
2024-01-18 21:44         ` Nicolas Dufresne
2023-12-31 15:11 ` [PATCH v3 2/2] dt-bindings: media: rockchip-vpu: Add rk3588 vpu compatible string Jianfeng Liu
2023-12-31 15:11   ` Jianfeng Liu
2023-12-31 15:11   ` Jianfeng Liu
2024-01-01 13:58   ` Conor Dooley
2024-01-01 13:58     ` Conor Dooley
2024-01-01 13:58     ` Conor Dooley
2024-03-15 12:22   ` Heiko Stübner
2024-03-15 12:22     ` Heiko Stübner
2024-03-15 12:22     ` Heiko Stübner
2024-03-15 12:45     ` Jianfeng Liu
2024-03-15 12:45       ` Jianfeng Liu
2024-03-15 12:45       ` Jianfeng Liu
2024-01-17 19:16 ` [PATCH v3 0/2] [v3]Add hantro g1 video decoder support for RK3588 Nicolas Dufresne
2024-01-17 19:16   ` Nicolas Dufresne
2024-01-17 19:16   ` Nicolas Dufresne
2024-01-17 21:12   ` Heiko Stübner [this message]
2024-01-17 21:12     ` Heiko Stübner
2024-01-17 21:12     ` Heiko Stübner
2024-01-18 11:30   ` amazingfate
2024-01-18 11:30     ` amazingfate
2024-01-18 11:30     ` amazingfate
2024-01-18 13:53     ` Piotr Oniszczuk
2024-01-18 13:53       ` Piotr Oniszczuk
2024-01-18 13:53       ` Piotr Oniszczuk
2024-01-18 21:51       ` Nicolas Dufresne
2024-01-18 21:51         ` Nicolas Dufresne
2024-01-18 21:51         ` Nicolas Dufresne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2196595.7aRn1RRit1@diego \
    --to=heiko@sntech.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=elezegarcia@gmail.com \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=knaerzche@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=liujianfeng1994@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=nicolas@ndufresne.ca \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.