From: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
To: Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH V2] ARM: dt: tegra: paz00: add regulators
Date: Wed, 27 Jun 2012 20:50:57 +0200 [thread overview]
Message-ID: <21985997.TUGv5fZBXQ@ax5200p> (raw)
In-Reply-To: <20120627113100.GF308-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
On Wednesday 27 June 2012 12:31:01 Mark Brown wrote:
> On Tue, Jun 26, 2012 at 06:31:00PM -0600, Stephen Warren wrote:
> > sm1: HW defaults and schematic match at 1.0v. marvin24's kernel had a max
> > of 1.125v, but this wasn't applied since apply_uV wasn't set.
>
> apply_uV is only valid if a single voltage is specified.
yes, that's why there is a ".apply_uV = (_minmv == _maxmv)" in the regulator
macro.
> If a voltage
> range were specified and it were acted on we'd take the lowest (not
> highest) voltage allowed.
Sorry, I don't get it. In this case, the board wouldn't boot at all because
nearly all supplies would be undervoltaged. I just checked and all voltages
are actually set to the *highest* (max) value. Maybe they aren't changed at
all?
Marc
WARNING: multiple messages have this Message-ID (diff)
From: marvin24@gmx.de (Marc Dietrich)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] ARM: dt: tegra: paz00: add regulators
Date: Wed, 27 Jun 2012 20:50:57 +0200 [thread overview]
Message-ID: <21985997.TUGv5fZBXQ@ax5200p> (raw)
In-Reply-To: <20120627113100.GF308@opensource.wolfsonmicro.com>
On Wednesday 27 June 2012 12:31:01 Mark Brown wrote:
> On Tue, Jun 26, 2012 at 06:31:00PM -0600, Stephen Warren wrote:
> > sm1: HW defaults and schematic match at 1.0v. marvin24's kernel had a max
> > of 1.125v, but this wasn't applied since apply_uV wasn't set.
>
> apply_uV is only valid if a single voltage is specified.
yes, that's why there is a ".apply_uV = (_minmv == _maxmv)" in the regulator
macro.
> If a voltage
> range were specified and it were acted on we'd take the lowest (not
> highest) voltage allowed.
Sorry, I don't get it. In this case, the board wouldn't boot at all because
nearly all supplies would be undervoltaged. I just checked and all voltages
are actually set to the *highest* (max) value. Maybe they aren't changed at
all?
Marc
next prev parent reply other threads:[~2012-06-27 18:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 0:31 [PATCH V2] ARM: dt: tegra: paz00: add regulators Stephen Warren
2012-06-27 0:31 ` Stephen Warren
[not found] ` <1340757060-27232-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-06-27 11:31 ` Mark Brown
2012-06-27 11:31 ` Mark Brown
[not found] ` <20120627113100.GF308-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-06-27 17:08 ` Stephen Warren
2012-06-27 17:08 ` Stephen Warren
2012-06-27 18:50 ` Marc Dietrich [this message]
2012-06-27 18:50 ` Marc Dietrich
2012-06-27 18:56 ` Stephen Warren
2012-06-27 18:56 ` Stephen Warren
[not found] ` <4FEB5741.6020400-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-06-27 19:01 ` Marc Dietrich
2012-06-27 19:01 ` Marc Dietrich
2012-06-27 21:59 ` Marc Dietrich
2012-06-27 21:59 ` Marc Dietrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21985997.TUGv5fZBXQ@ax5200p \
--to=marvin24-mmb7mzphnfy@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.