All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Dan Johansen <strit@manjaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Enable HDMI and GPU on quartz64-b
Date: Fri, 23 Sep 2022 11:45:33 +0200	[thread overview]
Message-ID: <2198677.PYKUYFuaPT@phil> (raw)
In-Reply-To: <659fc2fe-f820-04ad-8a4f-224b4d4bd97b@manjaro.org>

Hi,

Am Donnerstag, 22. September 2022, 23:22:37 CEST schrieb Dan Johansen:
> This seems to be based against linux-next and not mainline. It fails to 
> apply on mainline for me.

I would not expect things any other way though :-) .
I.e. in the current cycle everything new is of course targetting
v6.1 and the Quartz boards already saw some other changes.


> Den 20.09.2022 kl. 16.34 skrev Nicolas Frattaroli:
> > This enables the GPU and HDMI output (including HDMI audio) on
> > the PINE64 Quartz64 Model B single board computer.
> >
> > Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> > ---
> >   .../boot/dts/rockchip/rk3566-quartz64-b.dts   | 60 +++++++++++++++++++
> >   1 file changed, 60 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> > index 0f623198970f..77b179cd20e7 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> > @@ -4,6 +4,7 @@
> >   
> >   #include <dt-bindings/gpio/gpio.h>
> >   #include <dt-bindings/pinctrl/rockchip.h>
> > +#include <dt-bindings/soc/rockchip,vop2.h>
> >   #include "rk3566.dtsi"
> >   
> >   / {
> > @@ -28,6 +29,17 @@ gmac1_clkin: external-gmac1-clock {
> >   		#clock-cells = <0>;
> >   	};
> >   
> > +	hdmi-con {
> > +		compatible = "hdmi-connector";
> > +		type = "a";
> > +
> > +		port {
> > +			hdmi_con_in: endpoint {
> > +				remote-endpoint = <&hdmi_out_con>;
> > +			};
> > +		};
> > +	};
> > +
> >   	leds {
> >   		compatible = "gpio-leds";
> >   
> > @@ -183,6 +195,33 @@ &gmac1m1_clkinout
> >   	status = "okay";
> >   };
> >   
> > +&gpu {
> > +	mali-supply = <&vdd_gpu>;
> > +	status = "okay";
> > +};
> > +
> > +&hdmi {
> > +	avdd-0v9-supply = <&vdda0v9_image>;
> > +	avdd-1v8-supply = <&vcca1v8_image>;
> > +	status = "okay";
> > +};
> > +
> > +&hdmi_in {
> > +	hdmi_in_vp0: endpoint {
> > +		remote-endpoint = <&vp0_out_hdmi>;
> > +	};
> > +};
> > +
> > +&hdmi_out {
> > +	hdmi_out_con: endpoint {
> > +		remote-endpoint = <&hdmi_con_in>;
> > +	};
> > +};
> > +
> > +&hdmi_sound {
> > +	status = "okay";
> > +};
> > +
> >   &i2c0 {
> >   	status = "okay";
> >   
> > @@ -456,6 +495,10 @@ &i2c5 {
> >   	status = "disabled";
> >   };
> >   
> > +&i2s0_8ch {
> > +	status = "okay";
> > +};
> > +
> >   &i2s1_8ch {
> >   	pinctrl-names = "default";
> >   	pinctrl-0 = <&i2s1m0_sclktx
> The above part does not seem to exist in the current mainline (rc6) git 
> repo.

which is of course already in linux-next, so this
patch just applied nicely.


Heiko

> > @@ -677,3 +720,20 @@ &usb_host0_ehci {
> >   &usb_host0_ohci {
> >   	status = "okay";
> >   };
> > +
> > +&vop {
> > +	assigned-clocks = <&cru DCLK_VOP0>, <&cru DCLK_VOP1>;
> > +	assigned-clock-parents = <&pmucru PLL_HPLL>, <&cru PLL_VPLL>;
> > +	status = "okay";
> > +};
> > +
> > +&vop_mmu {
> > +	status = "okay";
> > +};
> > +
> > +&vp0 {
> > +	vp0_out_hdmi: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
> > +		reg = <ROCKCHIP_VOP2_EP_HDMI0>;
> > +		remote-endpoint = <&hdmi_in_vp0>;
> > +	};
> > +};
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Dan Johansen <strit@manjaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Enable HDMI and GPU on quartz64-b
Date: Fri, 23 Sep 2022 11:45:33 +0200	[thread overview]
Message-ID: <2198677.PYKUYFuaPT@phil> (raw)
In-Reply-To: <659fc2fe-f820-04ad-8a4f-224b4d4bd97b@manjaro.org>

Hi,

Am Donnerstag, 22. September 2022, 23:22:37 CEST schrieb Dan Johansen:
> This seems to be based against linux-next and not mainline. It fails to 
> apply on mainline for me.

I would not expect things any other way though :-) .
I.e. in the current cycle everything new is of course targetting
v6.1 and the Quartz boards already saw some other changes.


> Den 20.09.2022 kl. 16.34 skrev Nicolas Frattaroli:
> > This enables the GPU and HDMI output (including HDMI audio) on
> > the PINE64 Quartz64 Model B single board computer.
> >
> > Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> > ---
> >   .../boot/dts/rockchip/rk3566-quartz64-b.dts   | 60 +++++++++++++++++++
> >   1 file changed, 60 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> > index 0f623198970f..77b179cd20e7 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> > @@ -4,6 +4,7 @@
> >   
> >   #include <dt-bindings/gpio/gpio.h>
> >   #include <dt-bindings/pinctrl/rockchip.h>
> > +#include <dt-bindings/soc/rockchip,vop2.h>
> >   #include "rk3566.dtsi"
> >   
> >   / {
> > @@ -28,6 +29,17 @@ gmac1_clkin: external-gmac1-clock {
> >   		#clock-cells = <0>;
> >   	};
> >   
> > +	hdmi-con {
> > +		compatible = "hdmi-connector";
> > +		type = "a";
> > +
> > +		port {
> > +			hdmi_con_in: endpoint {
> > +				remote-endpoint = <&hdmi_out_con>;
> > +			};
> > +		};
> > +	};
> > +
> >   	leds {
> >   		compatible = "gpio-leds";
> >   
> > @@ -183,6 +195,33 @@ &gmac1m1_clkinout
> >   	status = "okay";
> >   };
> >   
> > +&gpu {
> > +	mali-supply = <&vdd_gpu>;
> > +	status = "okay";
> > +};
> > +
> > +&hdmi {
> > +	avdd-0v9-supply = <&vdda0v9_image>;
> > +	avdd-1v8-supply = <&vcca1v8_image>;
> > +	status = "okay";
> > +};
> > +
> > +&hdmi_in {
> > +	hdmi_in_vp0: endpoint {
> > +		remote-endpoint = <&vp0_out_hdmi>;
> > +	};
> > +};
> > +
> > +&hdmi_out {
> > +	hdmi_out_con: endpoint {
> > +		remote-endpoint = <&hdmi_con_in>;
> > +	};
> > +};
> > +
> > +&hdmi_sound {
> > +	status = "okay";
> > +};
> > +
> >   &i2c0 {
> >   	status = "okay";
> >   
> > @@ -456,6 +495,10 @@ &i2c5 {
> >   	status = "disabled";
> >   };
> >   
> > +&i2s0_8ch {
> > +	status = "okay";
> > +};
> > +
> >   &i2s1_8ch {
> >   	pinctrl-names = "default";
> >   	pinctrl-0 = <&i2s1m0_sclktx
> The above part does not seem to exist in the current mainline (rc6) git 
> repo.

which is of course already in linux-next, so this
patch just applied nicely.


Heiko

> > @@ -677,3 +720,20 @@ &usb_host0_ehci {
> >   &usb_host0_ohci {
> >   	status = "okay";
> >   };
> > +
> > +&vop {
> > +	assigned-clocks = <&cru DCLK_VOP0>, <&cru DCLK_VOP1>;
> > +	assigned-clock-parents = <&pmucru PLL_HPLL>, <&cru PLL_VPLL>;
> > +	status = "okay";
> > +};
> > +
> > +&vop_mmu {
> > +	status = "okay";
> > +};
> > +
> > +&vp0 {
> > +	vp0_out_hdmi: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
> > +		reg = <ROCKCHIP_VOP2_EP_HDMI0>;
> > +		remote-endpoint = <&hdmi_in_vp0>;
> > +	};
> > +};
> 





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Dan Johansen <strit@manjaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Enable HDMI and GPU on quartz64-b
Date: Fri, 23 Sep 2022 11:45:33 +0200	[thread overview]
Message-ID: <2198677.PYKUYFuaPT@phil> (raw)
In-Reply-To: <659fc2fe-f820-04ad-8a4f-224b4d4bd97b@manjaro.org>

Hi,

Am Donnerstag, 22. September 2022, 23:22:37 CEST schrieb Dan Johansen:
> This seems to be based against linux-next and not mainline. It fails to 
> apply on mainline for me.

I would not expect things any other way though :-) .
I.e. in the current cycle everything new is of course targetting
v6.1 and the Quartz boards already saw some other changes.


> Den 20.09.2022 kl. 16.34 skrev Nicolas Frattaroli:
> > This enables the GPU and HDMI output (including HDMI audio) on
> > the PINE64 Quartz64 Model B single board computer.
> >
> > Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> > ---
> >   .../boot/dts/rockchip/rk3566-quartz64-b.dts   | 60 +++++++++++++++++++
> >   1 file changed, 60 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> > index 0f623198970f..77b179cd20e7 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> > @@ -4,6 +4,7 @@
> >   
> >   #include <dt-bindings/gpio/gpio.h>
> >   #include <dt-bindings/pinctrl/rockchip.h>
> > +#include <dt-bindings/soc/rockchip,vop2.h>
> >   #include "rk3566.dtsi"
> >   
> >   / {
> > @@ -28,6 +29,17 @@ gmac1_clkin: external-gmac1-clock {
> >   		#clock-cells = <0>;
> >   	};
> >   
> > +	hdmi-con {
> > +		compatible = "hdmi-connector";
> > +		type = "a";
> > +
> > +		port {
> > +			hdmi_con_in: endpoint {
> > +				remote-endpoint = <&hdmi_out_con>;
> > +			};
> > +		};
> > +	};
> > +
> >   	leds {
> >   		compatible = "gpio-leds";
> >   
> > @@ -183,6 +195,33 @@ &gmac1m1_clkinout
> >   	status = "okay";
> >   };
> >   
> > +&gpu {
> > +	mali-supply = <&vdd_gpu>;
> > +	status = "okay";
> > +};
> > +
> > +&hdmi {
> > +	avdd-0v9-supply = <&vdda0v9_image>;
> > +	avdd-1v8-supply = <&vcca1v8_image>;
> > +	status = "okay";
> > +};
> > +
> > +&hdmi_in {
> > +	hdmi_in_vp0: endpoint {
> > +		remote-endpoint = <&vp0_out_hdmi>;
> > +	};
> > +};
> > +
> > +&hdmi_out {
> > +	hdmi_out_con: endpoint {
> > +		remote-endpoint = <&hdmi_con_in>;
> > +	};
> > +};
> > +
> > +&hdmi_sound {
> > +	status = "okay";
> > +};
> > +
> >   &i2c0 {
> >   	status = "okay";
> >   
> > @@ -456,6 +495,10 @@ &i2c5 {
> >   	status = "disabled";
> >   };
> >   
> > +&i2s0_8ch {
> > +	status = "okay";
> > +};
> > +
> >   &i2s1_8ch {
> >   	pinctrl-names = "default";
> >   	pinctrl-0 = <&i2s1m0_sclktx
> The above part does not seem to exist in the current mainline (rc6) git 
> repo.

which is of course already in linux-next, so this
patch just applied nicely.


Heiko

> > @@ -677,3 +720,20 @@ &usb_host0_ehci {
> >   &usb_host0_ohci {
> >   	status = "okay";
> >   };
> > +
> > +&vop {
> > +	assigned-clocks = <&cru DCLK_VOP0>, <&cru DCLK_VOP1>;
> > +	assigned-clock-parents = <&pmucru PLL_HPLL>, <&cru PLL_VPLL>;
> > +	status = "okay";
> > +};
> > +
> > +&vop_mmu {
> > +	status = "okay";
> > +};
> > +
> > +&vp0 {
> > +	vp0_out_hdmi: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
> > +		reg = <ROCKCHIP_VOP2_EP_HDMI0>;
> > +		remote-endpoint = <&hdmi_in_vp0>;
> > +	};
> > +};
> 





  reply	other threads:[~2022-09-23  9:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20 14:34 [PATCH] arm64: dts: rockchip: Enable HDMI and GPU on quartz64-b Nicolas Frattaroli
2022-09-20 14:34 ` Nicolas Frattaroli
2022-09-20 14:34 ` Nicolas Frattaroli
2022-09-22 21:22 ` Dan Johansen
2022-09-22 21:22   ` Dan Johansen
2022-09-22 21:22   ` Dan Johansen
2022-09-23  9:45   ` Heiko Stuebner [this message]
2022-09-23  9:45     ` Heiko Stuebner
2022-09-23  9:45     ` Heiko Stuebner
2022-09-23  9:53     ` Dan Johansen
2022-09-23  9:53       ` Dan Johansen
2022-09-23  9:53       ` Dan Johansen
2022-09-23 10:02       ` Heiko Stuebner
2022-09-23 10:02         ` Heiko Stuebner
2022-09-23 10:02         ` Heiko Stuebner
2022-09-23 10:33 ` Heiko Stuebner
2022-09-23 10:33   ` Heiko Stuebner
2022-09-23 10:33   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2198677.PYKUYFuaPT@phil \
    --to=heiko@sntech.de \
    --cc=devicetree@vger.kernel.org \
    --cc=frattaroli.nicolas@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=strit@manjaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.