All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joey Lu <a0987203069@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	mcoquelin.stm32@gmail.com, richardcochran@gmail.com,
	alexandre.torgue@foss.st.com, joabreu@synopsys.com,
	ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com,
	linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 1/3] dt-bindings: net: nuvoton: Add schema for Nuvoton MA35 family GMAC
Date: Thu, 7 Nov 2024 18:31:26 +0800	[thread overview]
Message-ID: <21a00f02-7f2f-46da-a67f-be3e64019303@gmail.com> (raw)
In-Reply-To: <f3c6b67f-5c15-43e2-832e-28392fbe52ec@lunn.ch>

Dear Andrew,

Thank you for your reply.

Andrew Lunn 於 11/7/2024 2:13 AM 寫道:
>> +  phy-mode:
>> +    enum:
>> +      - rmii
>> +      - rgmii-id
> The phy-mode deepened on the board design. All four rgmii values are
> valid.
I will add them.
>> +
>> +  tx_delay:
>> +    maxItems: 1
>> +    description:
>> +      Control transmit clock path delay in nanoseconds.
>> +
>> +  rx_delay:
>> +    maxItems: 1
>> +    description:
>> +      Control receive clock path delay in nanoseconds.
> If you absolutely really need these, keep them, but i suggest you drop
> them. They just cause confusion, when ideally we want the PHY to be
> adding RGMII delays, not the MAC.
>
> If you do need them, then they should be in pS.

I will fix it.

We have customers who use a fixed link instead of a PHY, so these 
properties may be necessary.

> 	Andrew

Thanks!

BR,

Joey



WARNING: multiple messages have this Message-ID (diff)
From: Joey Lu <a0987203069@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: robh@kernel.org, conor+dt@kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	devicetree@vger.kernel.org, openbmc@lists.ozlabs.org,
	netdev@vger.kernel.org, richardcochran@gmail.com,
	ychuang3@nuvoton.com, alexandre.torgue@foss.st.com,
	linux-kernel@vger.kernel.org, andrew+netdev@lunn.ch,
	edumazet@google.com, joabreu@synopsys.com,
	linux-arm-kernel@lists.infradead.org, mcoquelin.stm32@gmail.com,
	schung@nuvoton.com, kuba@kernel.org, krzk+dt@kernel.org,
	pabeni@redhat.com, davem@davemloft.net, yclu4@nuvoton.com
Subject: Re: [PATCH 1/3] dt-bindings: net: nuvoton: Add schema for Nuvoton MA35 family GMAC
Date: Thu, 7 Nov 2024 18:31:26 +0800	[thread overview]
Message-ID: <21a00f02-7f2f-46da-a67f-be3e64019303@gmail.com> (raw)
In-Reply-To: <f3c6b67f-5c15-43e2-832e-28392fbe52ec@lunn.ch>

Dear Andrew,

Thank you for your reply.

Andrew Lunn 於 11/7/2024 2:13 AM 寫道:
>> +  phy-mode:
>> +    enum:
>> +      - rmii
>> +      - rgmii-id
> The phy-mode deepened on the board design. All four rgmii values are
> valid.
I will add them.
>> +
>> +  tx_delay:
>> +    maxItems: 1
>> +    description:
>> +      Control transmit clock path delay in nanoseconds.
>> +
>> +  rx_delay:
>> +    maxItems: 1
>> +    description:
>> +      Control receive clock path delay in nanoseconds.
> If you absolutely really need these, keep them, but i suggest you drop
> them. They just cause confusion, when ideally we want the PHY to be
> adding RGMII delays, not the MAC.
>
> If you do need them, then they should be in pS.

I will fix it.

We have customers who use a fixed link instead of a PHY, so these 
properties may be necessary.

> 	Andrew

Thanks!

BR,

Joey


  parent reply	other threads:[~2024-11-07 10:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20241106111930.218825-1-a0987203069@gmail.com>
     [not found] ` <20241106111930.218825-2-a0987203069@gmail.com>
     [not found]   ` <20241106-bloated-ranch-be94506d360c@spud>
2024-11-07 10:15     ` [PATCH 1/3] dt-bindings: net: nuvoton: Add schema for Nuvoton MA35 family GMAC Joey Lu
2024-11-07 10:15       ` Joey Lu
2024-11-07 11:47       ` Krzysztof Kozlowski
2024-11-07 11:47         ` Krzysztof Kozlowski
2024-11-07 17:09       ` Conor Dooley
2024-11-07 17:09         ` Conor Dooley
2024-11-08  3:24         ` Joey Lu
2024-11-08  3:24           ` Joey Lu
     [not found]   ` <f3c6b67f-5c15-43e2-832e-28392fbe52ec@lunn.ch>
2024-11-07 10:31     ` Joey Lu [this message]
2024-11-07 10:31       ` Joey Lu
2024-11-07 13:18       ` Andrew Lunn
2024-11-07 13:18         ` Andrew Lunn
2024-11-11  9:17         ` Joey Lu
2024-11-11  9:17           ` Joey Lu
     [not found]   ` <12f4ea21-d83b-412c-9904-d9fe8f8a0167@lunn.ch>
2024-11-07 10:34     ` Joey Lu
2024-11-07 10:34       ` Joey Lu
     [not found] ` <20241106111930.218825-4-a0987203069@gmail.com>
     [not found]   ` <4c018927-b6ac-4414-9dde-487453350cca@lunn.ch>
2024-11-07 10:36     ` [PATCH 3/3] net: stmmac: dwmac-nuvoton: Add dwmac glue for Nuvoton MA35 family Joey Lu
2024-11-07 10:36       ` Joey Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21a00f02-7f2f-46da-a67f-be3e64019303@gmail.com \
    --to=a0987203069@gmail.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=joabreu@synopsys.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    --cc=schung@nuvoton.com \
    --cc=ychuang3@nuvoton.com \
    --cc=yclu4@nuvoton.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.