All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nilawar, Badal" <badal.nilawar@intel.com>
To: "Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>,
	Matthew Brost <matthew.brost@intel.com>,
	<intel-xe@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>
Cc: <dakr@kernel.org>, <pstanner@redhat.com>
Subject: Re: [PATCH 3/4] drm/xe: Mark G2H work queue with WQ_MEM_RECLAIM
Date: Tue, 22 Oct 2024 11:02:34 +0530	[thread overview]
Message-ID: <220773bc-0515-4f70-b012-568652e0fdc0@intel.com> (raw)
In-Reply-To: <bcbf8d2c-c781-4597-8fb2-8763b8514519@intel.com>



On 22-10-2024 10:36, Ghimiray, Himal Prasad wrote:
> 
> 
> On 21-10-2024 23:27, Matthew Brost wrote:
>> G2H work queue can be used to free memory thus we should allow this work
>> queue to run during reclaim. Mark with G2H work queue with
>> WQ_MEM_RECLAIM appropriately.
>>
>> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
>> ---
>>   drivers/gpu/drm/xe/xe_guc_ct.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/ 
>> xe_guc_ct.c
>> index c260d8840990..1b5d8fb1033a 100644
>> --- a/drivers/gpu/drm/xe/xe_guc_ct.c
>> +++ b/drivers/gpu/drm/xe/xe_guc_ct.c
>> @@ -213,7 +213,7 @@ int xe_guc_ct_init(struct xe_guc_ct *ct)
>>       xe_gt_assert(gt, !(guc_ct_size() % PAGE_SIZE));
>> -    ct->g2h_wq = alloc_ordered_workqueue("xe-g2h-wq", 0);
>> +    ct->g2h_wq = alloc_ordered_workqueue("xe-g2h-wq", WQ_MEM_RECLAIM);
> 
> LGTM
> Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

Some how this patch is not reflecting in my mailbox, so replying here.
Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>

Regards,
Badal

> 
> 
>>       if (!ct->g2h_wq)
>>           return -ENOMEM;
> 


  reply	other threads:[~2024-10-22  5:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21 17:57 [PATCH 0/4] Mark work queues with WQ_MEM_RECLAIM Matthew Brost
2024-10-21 17:57 ` [PATCH 1/4] drm/sched: Mark scheduler " Matthew Brost
2024-10-22 14:19   ` Philipp Stanner
2024-10-22 18:11     ` Matthew Brost
2024-10-23  7:56       ` Philipp Stanner
2024-10-21 17:57 ` [PATCH 2/4] drm/xe: Mark GGTT work queue " Matthew Brost
2024-10-22  5:06   ` Ghimiray, Himal Prasad
2024-10-22  5:34   ` Nilawar, Badal
2024-10-21 17:57 ` [PATCH 3/4] drm/xe: Mark G2H " Matthew Brost
2024-10-22  5:06   ` Ghimiray, Himal Prasad
2024-10-22  5:32     ` Nilawar, Badal [this message]
2024-10-21 17:57 ` [PATCH 4/4] drm/xe: Mark GT " Matthew Brost
2024-10-22  5:06   ` Ghimiray, Himal Prasad
2024-10-22  5:25   ` Nilawar, Badal
2024-10-21 18:21 ` ✓ CI.Patch_applied: success for Mark work queues " Patchwork
2024-10-21 18:21 ` ✓ CI.checkpatch: " Patchwork
2024-10-21 18:23 ` ✓ CI.KUnit: " Patchwork
2024-10-21 18:42 ` ✓ CI.Build: " Patchwork
2024-10-21 18:45 ` ✓ CI.Hooks: " Patchwork
2024-10-21 18:46 ` ✓ CI.checksparse: " Patchwork
2024-10-21 19:29 ` ✓ CI.BAT: " Patchwork
2024-10-22  0:34 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=220773bc-0515-4f70-b012-568652e0fdc0@intel.com \
    --to=badal.nilawar@intel.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=pstanner@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.