From: "Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>
To: Matthew Brost <matthew.brost@intel.com>,
<intel-xe@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>
Cc: <dakr@kernel.org>, <pstanner@redhat.com>
Subject: Re: [PATCH 4/4] drm/xe: Mark GT work queue with WQ_MEM_RECLAIM
Date: Tue, 22 Oct 2024 10:36:49 +0530 [thread overview]
Message-ID: <8ea7292b-33d5-4b88-913d-52201502f545@intel.com> (raw)
In-Reply-To: <20241021175705.1584521-5-matthew.brost@intel.com>
On 21-10-2024 23:27, Matthew Brost wrote:
> GT ordered work queue can be used to free memory via resets and fence
> signaling thus we should allow this work queue to run during reclaim.
> Mark with GT ordered work queue with WQ_MEM_RECLAIM appropriately.
>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/xe/xe_gt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index 89e9d9d4db06..d6744be01a68 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -77,7 +77,8 @@ struct xe_gt *xe_gt_alloc(struct xe_tile *tile)
> return ERR_PTR(-ENOMEM);
>
> gt->tile = tile;
> - gt->ordered_wq = alloc_ordered_workqueue("gt-ordered-wq", 0);
> + gt->ordered_wq = alloc_ordered_workqueue("gt-ordered-wq",
> + WQ_MEM_RECLAIM);
LGTM
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
>
> err = drmm_add_action_or_reset(>_to_xe(gt)->drm, gt_fini, gt);
> if (err)
next prev parent reply other threads:[~2024-10-22 5:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 17:57 [PATCH 0/4] Mark work queues with WQ_MEM_RECLAIM Matthew Brost
2024-10-21 17:57 ` [PATCH 1/4] drm/sched: Mark scheduler " Matthew Brost
2024-10-22 14:19 ` Philipp Stanner
2024-10-22 18:11 ` Matthew Brost
2024-10-23 7:56 ` Philipp Stanner
2024-10-21 17:57 ` [PATCH 2/4] drm/xe: Mark GGTT work queue " Matthew Brost
2024-10-22 5:06 ` Ghimiray, Himal Prasad
2024-10-22 5:34 ` Nilawar, Badal
2024-10-21 17:57 ` [PATCH 3/4] drm/xe: Mark G2H " Matthew Brost
2024-10-22 5:06 ` Ghimiray, Himal Prasad
2024-10-22 5:32 ` Nilawar, Badal
2024-10-21 17:57 ` [PATCH 4/4] drm/xe: Mark GT " Matthew Brost
2024-10-22 5:06 ` Ghimiray, Himal Prasad [this message]
2024-10-22 5:25 ` Nilawar, Badal
2024-10-21 18:21 ` ✓ CI.Patch_applied: success for Mark work queues " Patchwork
2024-10-21 18:21 ` ✓ CI.checkpatch: " Patchwork
2024-10-21 18:23 ` ✓ CI.KUnit: " Patchwork
2024-10-21 18:42 ` ✓ CI.Build: " Patchwork
2024-10-21 18:45 ` ✓ CI.Hooks: " Patchwork
2024-10-21 18:46 ` ✓ CI.checksparse: " Patchwork
2024-10-21 19:29 ` ✓ CI.BAT: " Patchwork
2024-10-22 0:34 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ea7292b-33d5-4b88-913d-52201502f545@intel.com \
--to=himal.prasad.ghimiray@intel.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
--cc=pstanner@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.