* [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks.
@ 2016-12-09 4:15 Con Kolivas
2016-12-09 10:22 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Con Kolivas @ 2016-12-09 4:15 UTC (permalink / raw)
To: linux-kernel; +Cc: Takashi Iwai, alsa-devel
The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the
following warning.
[ 6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072),
cval->res is probably wrong.
[ 6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val =
4608/7680/1
Adding it to the list of devices in volume_control_quirks makes it work
properly, fixing related typo.
Signed-off-by: Con Kolivas <kernel@kolivas.org>
---
sound/usb/mixer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index 2f8c388..4703cae 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -932,9 +932,10 @@ static void volume_control_quirks(struct usb_mixer_elem_info *cval,
case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
case USB_ID(0x046d, 0x08ca): /* Logitech Quickcam Fusion */
case USB_ID(0x046d, 0x0991):
+ case USB_ID(0x046d, 0x09a2): /* QuickCam Communicate Deluxe/S7500 */
/* Most audio usb devices lie about volume resolution.
* Most Logitech webcams have res = 384.
- * Proboly there is some logitech magic behind this number --fishor
+ * Probably there is some logitech magic behind this number --fishor
*/
if (!strcmp(kctl->id.name, "Mic Capture Volume")) {
usb_audio_info(chip,
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks.
2016-12-09 4:15 [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks Con Kolivas
@ 2016-12-09 10:22 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2016-12-09 10:22 UTC (permalink / raw)
To: Con Kolivas; +Cc: linux-kernel, alsa-devel
On Fri, 09 Dec 2016 05:15:57 +0100,
Con Kolivas wrote:
>
> The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the
> following warning.
>
> [ 6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072),
> cval->res is probably wrong.
> [ 6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val =
> 4608/7680/1
>
> Adding it to the list of devices in volume_control_quirks makes it work
> properly, fixing related typo.
>
> Signed-off-by: Con Kolivas <kernel@kolivas.org>
Applied (with Cc to stable), thanks.
Takashi
>
> ---
> sound/usb/mixer.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
> index 2f8c388..4703cae 100644
> --- a/sound/usb/mixer.c
> +++ b/sound/usb/mixer.c
> @@ -932,9 +932,10 @@ static void volume_control_quirks(struct usb_mixer_elem_info *cval,
> case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
> case USB_ID(0x046d, 0x08ca): /* Logitech Quickcam Fusion */
> case USB_ID(0x046d, 0x0991):
> + case USB_ID(0x046d, 0x09a2): /* QuickCam Communicate Deluxe/S7500 */
> /* Most audio usb devices lie about volume resolution.
> * Most Logitech webcams have res = 384.
> - * Proboly there is some logitech magic behind this number --fishor
> + * Probably there is some logitech magic behind this number --fishor
> */
> if (!strcmp(kctl->id.name, "Mic Capture Volume")) {
> usb_audio_info(chip,
> --
> 2.7.4
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks.
@ 2016-12-09 10:22 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2016-12-09 10:22 UTC (permalink / raw)
To: Con Kolivas; +Cc: linux-kernel, alsa-devel
On Fri, 09 Dec 2016 05:15:57 +0100,
Con Kolivas wrote:
>
> The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the
> following warning.
>
> [ 6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072),
> cval->res is probably wrong.
> [ 6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val =
> 4608/7680/1
>
> Adding it to the list of devices in volume_control_quirks makes it work
> properly, fixing related typo.
>
> Signed-off-by: Con Kolivas <kernel@kolivas.org>
Applied (with Cc to stable), thanks.
Takashi
>
> ---
> sound/usb/mixer.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
> index 2f8c388..4703cae 100644
> --- a/sound/usb/mixer.c
> +++ b/sound/usb/mixer.c
> @@ -932,9 +932,10 @@ static void volume_control_quirks(struct usb_mixer_elem_info *cval,
> case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
> case USB_ID(0x046d, 0x08ca): /* Logitech Quickcam Fusion */
> case USB_ID(0x046d, 0x0991):
> + case USB_ID(0x046d, 0x09a2): /* QuickCam Communicate Deluxe/S7500 */
> /* Most audio usb devices lie about volume resolution.
> * Most Logitech webcams have res = 384.
> - * Proboly there is some logitech magic behind this number --fishor
> + * Probably there is some logitech magic behind this number --fishor
> */
> if (!strcmp(kctl->id.name, "Mic Capture Volume")) {
> usb_audio_info(chip,
> --
> 2.7.4
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks.
2016-12-09 10:22 ` Takashi Iwai
(?)
@ 2016-12-09 20:27 ` Con Kolivas
-1 siblings, 0 replies; 6+ messages in thread
From: Con Kolivas @ 2016-12-09 20:27 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, linux-kernel
On 9 December 2016 at 21:22, Takashi Iwai <tiwai@suse.de> wrote:
> On Fri, 09 Dec 2016 05:15:57 +0100,
> Con Kolivas wrote:
> >
> > The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the
> > following warning.
> >
> > [ 6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072),
> > cval->res is probably wrong.
> > [ 6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val =
> > 4608/7680/1
> >
> > Adding it to the list of devices in volume_control_quirks makes it work
> > properly, fixing related typo.
> >
> > Signed-off-by: Con Kolivas <kernel@kolivas.org>
>
> Applied (with Cc to stable), thanks.
>
>
You're welcome. As there appear to be a lot of these devices from the same
manufacturer with the same error, and there are likely a lot of devices out
there that are missed from this whitelist, do you think it would be
worthwhile changing the code to detect the combination of unlikely big
volume range and usb vendor of 0x046d and automatically try using the
volume_control_quirk on them instead of a discrete whitelist?
Thanks,
Con
> Takashi
>
> >
> > ---
> > sound/usb/mixer.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
> > index 2f8c388..4703cae 100644
> > --- a/sound/usb/mixer.c
> > +++ b/sound/usb/mixer.c
> > @@ -932,9 +932,10 @@ static void volume_control_quirks(struct
> usb_mixer_elem_info *cval,
> > case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
> > case USB_ID(0x046d, 0x08ca): /* Logitech Quickcam Fusion */
> > case USB_ID(0x046d, 0x0991):
> > + case USB_ID(0x046d, 0x09a2): /* QuickCam Communicate Deluxe/S7500
> */
> > /* Most audio usb devices lie about volume resolution.
> > * Most Logitech webcams have res = 384.
> > - * Proboly there is some logitech magic behind this number --fishor
> > + * Probably there is some logitech magic behind this number
> --fishor
> > */
> > if (!strcmp(kctl->id.name, "Mic Capture Volume")) {
> > usb_audio_info(chip,
> > --
> > 2.7.4
> >
> >
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks.
2016-12-09 10:22 ` Takashi Iwai
(?)
(?)
@ 2016-12-09 20:35 ` Con Kolivas
2016-12-09 20:53 ` Takashi Iwai
-1 siblings, 1 reply; 6+ messages in thread
From: Con Kolivas @ 2016-12-09 20:35 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-kernel, alsa-devel
On Friday, 9 December 2016 11:22:15 AM AEDT Takashi Iwai wrote:
> On Fri, 09 Dec 2016 05:15:57 +0100,
>
> Con Kolivas wrote:
> > The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the
> > following warning.
> >
> > [ 6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072),
> > cval->res is probably wrong.
> > [ 6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val =
> > 4608/7680/1
> >
> > Adding it to the list of devices in volume_control_quirks makes it work
> > properly, fixing related typo.
> >
> > Signed-off-by: Con Kolivas <kernel@kolivas.org>
>
> Applied (with Cc to stable), thanks.
(Apologies for google mail defaulting to html, resending with a proper mail
client)
You're welcome. As there appear to be a lot of these devices from the same
manufacturer with the same error, and there are likely a lot of devices out
there that are missed from this whitelist, do you think it would be worthwhile
changing the code to detect the combination of unlikely big volume range and
usb vendor of 0x046d and automatically try using the volume_control_quirk on
them instead of a discrete whitelist?
Thanks,
Con
>
>
> Takashi
>
> > ---
> >
> > sound/usb/mixer.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
> > index 2f8c388..4703cae 100644
> > --- a/sound/usb/mixer.c
> > +++ b/sound/usb/mixer.c
> > @@ -932,9 +932,10 @@ static void volume_control_quirks(struct
> > usb_mixer_elem_info *cval,>
> > case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
> > case USB_ID(0x046d, 0x08ca): /* Logitech Quickcam Fusion */
> >
> > case USB_ID(0x046d, 0x0991):
> > + case USB_ID(0x046d, 0x09a2): /* QuickCam Communicate Deluxe/S7500 */
> >
> > /* Most audio usb devices lie about volume resolution.
> >
> > * Most Logitech webcams have res = 384.
> >
> > - * Proboly there is some logitech magic behind this number --fishor
> > + * Probably there is some logitech magic behind this number --fishor
> >
> > */
> >
> > if (!strcmp(kctl->id.name, "Mic Capture Volume")) {
> >
> > usb_audio_info(chip,
--
-ck
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks.
2016-12-09 20:35 ` Con Kolivas
@ 2016-12-09 20:53 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2016-12-09 20:53 UTC (permalink / raw)
To: Con Kolivas; +Cc: linux-kernel, alsa-devel
On Fri, 09 Dec 2016 21:35:17 +0100,
Con Kolivas wrote:
>
> On Friday, 9 December 2016 11:22:15 AM AEDT Takashi Iwai wrote:
> > On Fri, 09 Dec 2016 05:15:57 +0100,
> >
> > Con Kolivas wrote:
> > > The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the
> > > following warning.
> > >
> > > [ 6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072),
> > > cval->res is probably wrong.
> > > [ 6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val =
> > > 4608/7680/1
> > >
> > > Adding it to the list of devices in volume_control_quirks makes it work
> > > properly, fixing related typo.
> > >
> > > Signed-off-by: Con Kolivas <kernel@kolivas.org>
> >
> > Applied (with Cc to stable), thanks.
>
> (Apologies for google mail defaulting to html, resending with a proper mail
> client)
>
> You're welcome. As there appear to be a lot of these devices from the same
> manufacturer with the same error, and there are likely a lot of devices out
> there that are missed from this whitelist, do you think it would be worthwhile
> changing the code to detect the combination of unlikely big volume range and
> usb vendor of 0x046d and automatically try using the volume_control_quirk on
> them instead of a discrete whitelist?
Yeah, it sounds like a good idea!
thanks,
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-12-09 20:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-09 4:15 [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks Con Kolivas
2016-12-09 10:22 ` Takashi Iwai
2016-12-09 10:22 ` Takashi Iwai
2016-12-09 20:27 ` Con Kolivas
2016-12-09 20:35 ` Con Kolivas
2016-12-09 20:53 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.