From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Peter Geis <pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Levin Du <djw-Efosm3t9Qi2Pt1CcHtbs0g@public.gmane.org>
Subject: Re: [PATCH] arm64: dts: rockchip: fix rk3328-roc-cc gmac2io stability issues
Date: Sun, 10 Feb 2019 18:55:55 +0100 [thread overview]
Message-ID: <2209386.zZQUimU7aI@phil> (raw)
In-Reply-To: <20190210170214.12057-1-pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi Peter,
Am Sonntag, 10. Februar 2019, 18:02:14 CET schrieb Peter Geis:
> This patch is a port of the fix from
> commit 73e42e186699 ("arm64: dts: rockchip: fix rock64 gmac2io stability
> issues")
>
> As per that patch, enabling thresh dma mode force disables checksuming.
> This is necessary as tx checksuming does not work with packets larger
> than 1498.
>
> The rk3328-roc-cc board exhibits tx stability issues with large packets
> similar to rock64's issues. This patch resolves that issue.
Patch itself looks good, but here you're missing a Signed-off-by line, see
Documentation/process/submitting-patches.rst
section "11) Sign your work - the Developer's Certificate of Origin"
for reference
Heiko
next prev parent reply other threads:[~2019-02-10 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 17:02 [PATCH] arm64: dts: rockchip: fix rk3328-roc-cc gmac2io stability issues Peter Geis
[not found] ` <20190210170214.12057-1-pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-02-10 17:55 ` Heiko Stuebner [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-10 18:04 Peter Geis
[not found] ` <20190210180439.380-1-pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-02-15 9:27 ` Heiko Stübner
2019-02-28 15:01 Leonidas P. Papadakos
[not found] ` <20190228150129.28637-1-papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-02-28 20:30 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2209386.zZQUimU7aI@phil \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=djw-Efosm3t9Qi2Pt1CcHtbs0g@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.