From: Heiko Stuebner <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>, John Keeping <john@metanate.com>
Cc: dri-devel@lists.freedesktop.org, Sandy Huang <hjc@rock-chips.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup
Date: Mon, 17 Oct 2022 13:29:11 +0200 [thread overview]
Message-ID: <2220890.jZfb76A358@phil> (raw)
In-Reply-To: <Y00o3M7SKAB/w9sW@donbot>
Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping:
> Hi Johan,
>
> On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan Jonker wrote:
> > Your patch contribution causes a kernel panic on MK808 with Rockchip rk3066a SoC.
> > Would you like to contribute to fix this issue?
> > The assumtion that drm_fbdev_generic_setup() does what rockchip_drm_fbdev_init did is not true!
> > A revert makes it work again.
>
> It looks like there are 3 different ways to end up with -ENOMEM here,
> can you track down whether you're hitting one of the cases in
> rockchip_gem_prime_vmap() or if it's the iosys_map_is_null case in
> drm_gem_vmap()?
>
> I guess the memory usage increases slightly using the generic code and
> RK3066 has less memory available.
also rk3066 and rk3188 do not have an iommu, so rely
on cma allocations.
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>, John Keeping <john@metanate.com>
Cc: dri-devel@lists.freedesktop.org, Sandy Huang <hjc@rock-chips.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup
Date: Mon, 17 Oct 2022 13:29:11 +0200 [thread overview]
Message-ID: <2220890.jZfb76A358@phil> (raw)
In-Reply-To: <Y00o3M7SKAB/w9sW@donbot>
Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping:
> Hi Johan,
>
> On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan Jonker wrote:
> > Your patch contribution causes a kernel panic on MK808 with Rockchip rk3066a SoC.
> > Would you like to contribute to fix this issue?
> > The assumtion that drm_fbdev_generic_setup() does what rockchip_drm_fbdev_init did is not true!
> > A revert makes it work again.
>
> It looks like there are 3 different ways to end up with -ENOMEM here,
> can you track down whether you're hitting one of the cases in
> rockchip_gem_prime_vmap() or if it's the iosys_map_is_null case in
> drm_gem_vmap()?
>
> I guess the memory usage increases slightly using the generic code and
> RK3066 has less memory available.
also rk3066 and rk3188 do not have an iommu, so rely
on cma allocations.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>, John Keeping <john@metanate.com>
Cc: David Airlie <airlied@linux.ie>, Sandy Huang <hjc@rock-chips.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup
Date: Mon, 17 Oct 2022 13:29:11 +0200 [thread overview]
Message-ID: <2220890.jZfb76A358@phil> (raw)
In-Reply-To: <Y00o3M7SKAB/w9sW@donbot>
Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping:
> Hi Johan,
>
> On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan Jonker wrote:
> > Your patch contribution causes a kernel panic on MK808 with Rockchip rk3066a SoC.
> > Would you like to contribute to fix this issue?
> > The assumtion that drm_fbdev_generic_setup() does what rockchip_drm_fbdev_init did is not true!
> > A revert makes it work again.
>
> It looks like there are 3 different ways to end up with -ENOMEM here,
> can you track down whether you're hitting one of the cases in
> rockchip_gem_prime_vmap() or if it's the iosys_map_is_null case in
> drm_gem_vmap()?
>
> I guess the memory usage increases slightly using the generic code and
> RK3066 has less memory available.
also rk3066 and rk3188 do not have an iommu, so rely
on cma allocations.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>, John Keeping <john@metanate.com>
Cc: dri-devel@lists.freedesktop.org, Sandy Huang <hjc@rock-chips.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup
Date: Mon, 17 Oct 2022 13:29:11 +0200 [thread overview]
Message-ID: <2220890.jZfb76A358@phil> (raw)
In-Reply-To: <Y00o3M7SKAB/w9sW@donbot>
Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping:
> Hi Johan,
>
> On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan Jonker wrote:
> > Your patch contribution causes a kernel panic on MK808 with Rockchip rk3066a SoC.
> > Would you like to contribute to fix this issue?
> > The assumtion that drm_fbdev_generic_setup() does what rockchip_drm_fbdev_init did is not true!
> > A revert makes it work again.
>
> It looks like there are 3 different ways to end up with -ENOMEM here,
> can you track down whether you're hitting one of the cases in
> rockchip_gem_prime_vmap() or if it's the iosys_map_is_null case in
> drm_gem_vmap()?
>
> I guess the memory usage increases slightly using the generic code and
> RK3066 has less memory available.
also rk3066 and rk3188 do not have an iommu, so rely
on cma allocations.
Heiko
next prev parent reply other threads:[~2022-10-17 11:29 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 11:50 [PATCH] drm/rockchip: use generic fbdev setup John Keeping
2021-10-29 11:50 ` John Keeping
2021-10-29 11:50 ` John Keeping
2021-10-29 19:00 ` Thomas Zimmermann
2021-10-29 19:00 ` Thomas Zimmermann
2021-10-29 19:00 ` Thomas Zimmermann
2021-10-30 12:05 ` John Keeping
2021-10-30 12:05 ` John Keeping
2021-10-30 12:05 ` John Keeping
2021-10-31 18:09 ` Thomas Zimmermann
2021-10-31 18:09 ` Thomas Zimmermann
2021-10-31 18:09 ` Thomas Zimmermann
2021-11-01 11:34 ` John Keeping
2021-11-01 11:34 ` John Keeping
2021-11-01 11:34 ` John Keeping
2021-11-01 11:34 ` John Keeping
2021-12-07 11:54 ` John Keeping
2021-12-07 11:54 ` John Keeping
2021-12-07 11:54 ` John Keeping
2021-12-07 11:54 ` John Keeping
2021-12-07 13:00 ` Thomas Zimmermann
2021-12-07 13:00 ` Thomas Zimmermann
2021-12-07 13:00 ` Thomas Zimmermann
2022-10-17 8:11 ` [BUG] " Johan Jonker
2022-10-17 8:11 ` Johan Jonker
2022-10-17 8:11 ` Johan Jonker
2022-10-17 8:11 ` Johan Jonker
2022-10-17 10:05 ` John Keeping
2022-10-17 10:05 ` John Keeping
2022-10-17 10:05 ` John Keeping
2022-10-17 10:05 ` John Keeping
2022-10-17 11:29 ` Heiko Stuebner [this message]
2022-10-17 11:29 ` Heiko Stuebner
2022-10-17 11:29 ` Heiko Stuebner
2022-10-17 11:29 ` Heiko Stuebner
2022-10-17 18:30 ` Johan Jonker
2022-10-17 18:30 ` Johan Jonker
2022-10-17 18:30 ` Johan Jonker
2022-10-17 18:30 ` Johan Jonker
2022-10-17 19:00 ` John Keeping
2022-10-17 19:00 ` John Keeping
2022-10-17 19:00 ` John Keeping
2022-10-17 19:00 ` John Keeping
2022-10-17 19:16 ` Johan Jonker
2022-10-17 19:16 ` Johan Jonker
2022-10-17 19:16 ` Johan Jonker
2022-10-17 19:16 ` Johan Jonker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2220890.jZfb76A358@phil \
--to=heiko@sntech.de \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=jbx6244@gmail.com \
--cc=john@metanate.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.