Re: [PATCH 2/2] arm64: dts: rockchip: add rock5 itx board

From: "Heiko Stübner" <heiko@sntech.de>
To: Alex Bee <knaerzche@gmail.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: add rock5 itx board
Date: Thu, 04 Jul 2024 13:21:46 +0200	[thread overview]
Message-ID: <2224639.1BCLMh4Saa@diego> (raw)
In-Reply-To: <faeb87de-b97e-4f95-bbb0-edd03a411f4c@gmail.com>

Hi Alex,

Am Donnerstag, 4. Juli 2024, 12:52:35 CEST schrieb Alex Bee:
> Am 03.07.24 um 23:05 schrieb Heiko Stuebner:
> > The Rock 5 ITX as the name suggests is made in the ITX form factor and
> > actually build in a form to be used in a regular case even providing
> > connectors for regular front-panel io.
> > 
> > It can be powered either bei 12V, ATX power-supply or PoE.
> > 
> > Notable peripherals are the 4 SATA ports, M.2 M-Key slot, M.2 E-key slot,
> > 2*2.5Gb pcie-connected ethernet nics.
> > 
> > As of yet unsupported display options consist of 2*hdmi, DP via type-c,
> > eDP + 2*DSI via pcb connectors.
> > 
> > USB ports are 4*USB3 + 2*USB2 on the back panel and 2-port front-panel
> > connector.
> > 
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---

> > +&usb_host1_xhci {
> > +	dr_mode = "host";
> > +	#address-cells = <1>;
> > +	#size-cells = <0>;
> > +	status = "okay";
> > +
> > +	/* 2.0 hub on port 1 */
> > +	hub_2_0: hub@1 {
> > +		compatible = "usb5e3,610";
> > +		reg = <1>;
> > +		peer-hub = <&hub_3_0>;
> > +		vdd-supply = <&vcc5v0_usb12>;
> Are you sure about this one? I couldn't find any schematics for this board,
> but both the bindings for usb5e3,610 and the datasheet[0] are saying this
> is the supply for the hub's internal logic which is typically ~3.3V. It's
> definitely not a supply for the vbus.
> 
> [0] http://www.sunnyqi.com/upLoad/product/month_1308/GL852G.pdf

yeah, you're right. The vdd-supply is coming from vcc_3v3 it seems
vcc5v0_usb12 is the phy supply instead.

Will fix that in v3.

Thanks for catching that
Heiko

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip