* Re: [PATCH] ARM: shmobile: dts: Add common file for AA121TD01 panel
2015-07-24 8:52 [PATCH] ARM: shmobile: dts: Add common file for AA121TD01 panel Kuninori Morimoto
@ 2015-07-27 5:18 ` Magnus Damm
2015-07-27 6:20 ` Simon Horman
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Magnus Damm @ 2015-07-27 5:18 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
On Fri, Jul 24, 2015 at 5:52 PM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> The Mitsubishi AA121TD01 panel is commonly used with the Marzen, Lager
> and Koelsch boards. Create a .dtsi file that describe the panel and its
> connection to the board.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
Thanks for preparing and submitting this patch - very nice!
Just so I remember which board did you test it on again? I suspect it
was Koelsch. It would be good to test LVDS on other boards too I
think.
Best,
/ magnus
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: shmobile: dts: Add common file for AA121TD01 panel
2015-07-24 8:52 [PATCH] ARM: shmobile: dts: Add common file for AA121TD01 panel Kuninori Morimoto
2015-07-27 5:18 ` Magnus Damm
@ 2015-07-27 6:20 ` Simon Horman
2015-07-27 11:01 ` Laurent Pinchart
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2015-07-27 6:20 UTC (permalink / raw)
To: linux-sh
Hi Magnus,
On Mon, Jul 27, 2015 at 02:18:12PM +0900, Magnus Damm wrote:
> Hi Morimoto-san,
>
> On Fri, Jul 24, 2015 at 5:52 PM, Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > The Mitsubishi AA121TD01 panel is commonly used with the Marzen, Lager
> > and Koelsch boards. Create a .dtsi file that describe the panel and its
> > connection to the board.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
>
> Thanks for preparing and submitting this patch - very nice!
Is that an Ack?
> Just so I remember which board did you test it on again? I suspect it
> was Koelsch. It would be good to test LVDS on other boards too I
> think.
>
> Best,
>
> / magnus
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: shmobile: dts: Add common file for AA121TD01 panel
2015-07-24 8:52 [PATCH] ARM: shmobile: dts: Add common file for AA121TD01 panel Kuninori Morimoto
2015-07-27 5:18 ` Magnus Damm
2015-07-27 6:20 ` Simon Horman
@ 2015-07-27 11:01 ` Laurent Pinchart
2015-07-28 3:44 ` Magnus Damm
2015-07-28 4:23 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2015-07-27 11:01 UTC (permalink / raw)
To: linux-sh
Hello Morimoto-san,
Thank you for the patch.
On Friday 24 July 2015 08:52:02 Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> The Mitsubishi AA121TD01 panel is commonly used with the Marzen, Lager
> and Koelsch boards. Create a .dtsi file that describe the panel and its
> connection to the board.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> arch/arm/boot/dts/r8a77xx-aa121td01-panel.dtsi | 41 +++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 arch/arm/boot/dts/r8a77xx-aa121td01-panel.dtsi
>
> diff --git a/arch/arm/boot/dts/r8a77xx-aa121td01-panel.dtsi
> b/arch/arm/boot/dts/r8a77xx-aa121td01-panel.dtsi new file mode 100644
> index 0000000..4261e6f
> --- /dev/null
> +++ b/arch/arm/boot/dts/r8a77xx-aa121td01-panel.dtsi
> @@ -0,0 +1,41 @@
> +/*
> + * Common file for the AA121TD01 panel connected to Renesas R-Car boards
> + *
> + * Copyright (C) 2015 Renesas Electronics Corp.
> + *
> + * This file is licensed under the terms of the GNU General Public License
> + * version 2. This program is licensed "as is" without any warranty of any
> + * kind, whether express or implied.
> + */
> +
> +/ {
> + panel {
> + compatible = "mitsubishi,aa121td01", "panel-dpi";
> +
> + width-mm = <260>;
> + height-mm = <165>;
According to
http://www.eurocomposant.fr/index.php/fr/content/download/4476/46559/file/AA121TD01.pdf
the display size is 261mm x 163mm.
> +
> + panel-timing {
> + /* 1280x800 @71Hz */
With a 71MHz clock, using the typical timings from the above datasheet, the
vertical refresh frequency will be 60Hz, not 71Hz.
> + clock-frequency = <71000000>;
> + hactive = <1280>;
> + vactive = <800>;
> + hsync-len = <160>;
> + hfront-porch = <64>;
> + hback-porch = <96>;
> + vfront-porch = <9>;
> + vback-porch = <15>;
> + vsync-len = <24>;
Still according to the same datasheet, the typical total horizontal blanking
time is 160 clock cycles. This is the sum of hsync-len, hfront-porch and
hback-porch. This patch sets the horizontal blanking time to 320 instead (160
+ 64 + 96). Similarly, for the vertical direction, the total should be 23, not
48. The above values would lead to a 52Hz vertical refresh frequency.
> + };
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&lvds_connector>;
> + };
> + };
> + };
> +};
> +
> +&lvds_connector {
> + remote-endpoint = <&panel_in>;
> +};
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: shmobile: dts: Add common file for AA121TD01 panel
2015-07-24 8:52 [PATCH] ARM: shmobile: dts: Add common file for AA121TD01 panel Kuninori Morimoto
` (2 preceding siblings ...)
2015-07-27 11:01 ` Laurent Pinchart
@ 2015-07-28 3:44 ` Magnus Damm
2015-07-28 4:23 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Magnus Damm @ 2015-07-28 3:44 UTC (permalink / raw)
To: linux-sh
Hi Simon,
On Mon, Jul 27, 2015 at 3:20 PM, Simon Horman <horms@verge.net.au> wrote:
> Hi Magnus,
>
> On Mon, Jul 27, 2015 at 02:18:12PM +0900, Magnus Damm wrote:
>> Hi Morimoto-san,
>>
>> On Fri, Jul 24, 2015 at 5:52 PM, Kuninori Morimoto
>> <kuninori.morimoto.gx@renesas.com> wrote:
>> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> >
>> > The Mitsubishi AA121TD01 panel is commonly used with the Marzen, Lager
>> > and Koelsch boards. Create a .dtsi file that describe the panel and its
>> > connection to the board.
>> >
>> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> > ---
>>
>> Thanks for preparing and submitting this patch - very nice!
>
> Is that an Ack?
Close enough, but my intention was more of a thank-you to Morimoto-san
for preparing and submitting that patch upstream.
I propose that we wait for Morimoto-san and Laurent to sort out the
details about the panel.
Thanks,
/ magnus
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: shmobile: dts: Add common file for AA121TD01 panel
2015-07-24 8:52 [PATCH] ARM: shmobile: dts: Add common file for AA121TD01 panel Kuninori Morimoto
` (3 preceding siblings ...)
2015-07-28 3:44 ` Magnus Damm
@ 2015-07-28 4:23 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2015-07-28 4:23 UTC (permalink / raw)
To: linux-sh
On Tue, Jul 28, 2015 at 12:44:46PM +0900, Magnus Damm wrote:
> Hi Simon,
>
> On Mon, Jul 27, 2015 at 3:20 PM, Simon Horman <horms@verge.net.au> wrote:
> > Hi Magnus,
> >
> > On Mon, Jul 27, 2015 at 02:18:12PM +0900, Magnus Damm wrote:
> >> Hi Morimoto-san,
> >>
> >> On Fri, Jul 24, 2015 at 5:52 PM, Kuninori Morimoto
> >> <kuninori.morimoto.gx@renesas.com> wrote:
> >> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >> >
> >> > The Mitsubishi AA121TD01 panel is commonly used with the Marzen, Lager
> >> > and Koelsch boards. Create a .dtsi file that describe the panel and its
> >> > connection to the board.
> >> >
> >> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >> > ---
> >>
> >> Thanks for preparing and submitting this patch - very nice!
> >
> > Is that an Ack?
>
> Close enough, but my intention was more of a thank-you to Morimoto-san
> for preparing and submitting that patch upstream.
>
> I propose that we wait for Morimoto-san and Laurent to sort out the
> details about the panel.
Thanks, that seems reasonable.
^ permalink raw reply [flat|nested] 6+ messages in thread