Re: [PATCH 0/5] cleanup in library header files

[Thomas Monjalon <thomas@monjalon.net>]

14/06/2023 17:08, David Marchand:
> On Wed, Jun 14, 2023 at 4:42 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> >
> > On Wed, Jun 14, 2023 at 8:01 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > >
> > > While pulling some trees for DPDK 23.07-rc1,
> > > I've seen that some wrong coding style for comments
> > > were copied over and over.
> > >
> > > In order to avoid copying wrong comment style,
> > > the three first patches are fixing a lot of comments.
> > > As it is not critical, they are not marked for backport.
> > >
> > > While looking the header files, I've fixed some misuses of "extern".
> >
> > Thanks for the cleanup. IMO, it is better to update
> > ./devtools/checkpatches.sh or so to flag these issue before getting to
> > repo for new changes,
> 
> Those are not easy to spot.
> +1 to add a check if that won't raise false positives.

It will raise false positives.
And these are minor issues.
I think we can do a cleanup every 5 years, it is OK :)