All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	Ruifeng Wang <ruifeng.wang@arm.com>
Subject: Re: [PATCH 0/5] cleanup in library header files
Date: Tue, 27 Jun 2023 16:52:39 +0200	[thread overview]
Message-ID: <9646715.ag9G3TJQzC@thomas> (raw)
In-Reply-To: <ZInSq1LHse0ptPkN@bricha3-MOBL.ger.corp.intel.com>

14/06/2023 16:46, Bruce Richardson:
> On Wed, Jun 14, 2023 at 04:26:46PM +0200, Thomas Monjalon wrote:
> > While pulling some trees for DPDK 23.07-rc1,
> > I've seen that some wrong coding style for comments
> > were copied over and over.
> > 
> > In order to avoid copying wrong comment style,
> > the three first patches are fixing a lot of comments.
> > As it is not critical, they are not marked for backport.
> > 
> > While looking the header files, I've fixed some misuses of "extern".
> > 
> > 
> > Thomas Monjalon (5):
> >   lib: remove blank line ending comment blocks
> >   lib: remove extra asterisks ending comment blocks
> >   lib: align comment blocks
> >   lib: restrict use of keyword extern
> >   cryptodev: fix comments of modular operation parameters
> >
> 
> Some really good cleanup here, thanks.
> 
> Not sure we need to fix the use of extern for functions, but removing the
> extern is harmless so ok for it.
> 
> Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied



      reply	other threads:[~2023-06-27 14:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14 14:26 [PATCH 0/5] cleanup in library header files Thomas Monjalon
2023-06-14 14:26 ` [PATCH 1/5] lib: remove blank line ending comment blocks Thomas Monjalon
2023-06-15  7:27   ` Ruifeng Wang
2023-06-14 14:26 ` [PATCH 2/5] lib: remove extra asterisks " Thomas Monjalon
2023-06-14 14:26 ` [PATCH 3/5] lib: align " Thomas Monjalon
2023-06-15  7:16   ` Ruifeng Wang
2023-06-14 14:26 ` [PATCH 4/5] lib: restrict use of keyword extern Thomas Monjalon
2023-06-14 14:26 ` [PATCH 5/5] cryptodev: fix comments of modular operation parameters Thomas Monjalon
2023-06-14 14:42 ` [PATCH 0/5] cleanup in library header files Jerin Jacob
2023-06-14 15:08   ` David Marchand
2023-06-14 15:53     ` Thomas Monjalon
2023-06-14 14:46 ` Bruce Richardson
2023-06-27 14:52   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9646715.ag9G3TJQzC@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ruifeng.wang@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.