All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/cma: remove to allocate shmfs backing store
Date: Thu, 28 Aug 2014 14:30:59 +0200	[thread overview]
Message-ID: <22378574.9TNJn11Yi2@avalon> (raw)
In-Reply-To: <1409120792-423-1-git-send-email-jy0922.shim@samsung.com>

Hi Joonyoung,

Thank you for the patch.

On Wednesday 27 August 2014 15:26:32 Joonyoung Shim wrote:
> Initialize GEM object using drm_gem_private_object_init instead of
> drm_gem_object_init. It doesn't need to have shmfs backing store because
> the CMA GEM object uses CMA area.
> 
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/drm_gem_cma_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c
> b/drivers/gpu/drm/drm_gem_cma_helper.c index e467e67..a65cbd0 100644
> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -52,7 +52,7 @@ __drm_gem_cma_create(struct drm_device *drm, unsigned int
> size)
> 
>  	gem_obj = &cma_obj->base;
> 
> -	ret = drm_gem_object_init(drm, gem_obj, size);
> +	ret = drm_gem_private_object_init(drm, gem_obj, size);
>  	if (ret)
>  		goto error;

-- 
Regards,

Laurent Pinchart

      reply	other threads:[~2014-08-28 12:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27  6:26 [PATCH] drm/cma: remove to allocate shmfs backing store Joonyoung Shim
2014-08-28 12:30 ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22378574.9TNJn11Yi2@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jy0922.shim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.