From: Tomasz Figa <t.figa@samsung.com>
To: linux-samsung-soc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Kukjin Kim <kgene.kim@samsung.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ian.campbell@citrix.com>,
Kumar Gala <galak@codeaurora.org>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] ARM: dts: exynos4210: Work around lack of cpufreq regulator lookup
Date: Mon, 26 Aug 2013 19:13:28 +0200 [thread overview]
Message-ID: <2243476.800bKojdAz@amdc1227> (raw)
In-Reply-To: <1377020136-14838-1-git-send-email-t.figa@samsung.com>
On Tuesday 20 of August 2013 19:35:36 Tomasz Figa wrote:
> Exynos cpufreq drivers does not support device tree based regulator
> lookup, so it can get the VDD ARM regulator only by its name. To get
> cpufreq working for now, this patch works this around by renaming the
> regulator in board dts files to vdd_arm, which is the name expected by
> the driver.
>
> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/boot/dts/exynos4210-origen.dts | 7 ++++++-
> arch/arm/boot/dts/exynos4210-trats.dts | 7 ++++++-
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts
> b/arch/arm/boot/dts/exynos4210-origen.dts index 382d8c7..46378fe 100644
> --- a/arch/arm/boot/dts/exynos4210-origen.dts
> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
> @@ -192,7 +192,12 @@
> };
>
> buck1_reg: BUCK1 {
> - regulator-name = "VDD_ARM_1.2V";
> + /*
> + * HACK: The real name is VDD_ARM_1.2V,
> + * but exynos-cpufreq does not support
> + * DT-based regulator lookup yet.
> + */
> + regulator-name = "vdd_arm";
> regulator-min-microvolt = <950000>;
> regulator-max-microvolt = <1350000>;
> regulator-always-on;
> diff --git a/arch/arm/boot/dts/exynos4210-trats.dts
> b/arch/arm/boot/dts/exynos4210-trats.dts index 1c164f2..63cc571 100644
> --- a/arch/arm/boot/dts/exynos4210-trats.dts
> +++ b/arch/arm/boot/dts/exynos4210-trats.dts
> @@ -290,7 +290,12 @@
> };
>
> varm_breg: BUCK1 {
> - regulator-name = "VARM_1.2V_C210";
> + /*
> + * HACK: The real name is VARM_1.2V_C210,
> + * but exynos-cpufreq does not support
> + * DT-based regulator lookup yet.
> + */
> + regulator-name = "vdd_arm";
> regulator-min-microvolt = <900000>;
> regulator-max-microvolt = <1350000>;
> regulator-always-on;
Ping.
This patch fixes broken cpufreq on above two boards, so it would be nice to
have it merged for 3.12, even if it's a bit hacky, since it's too late for
proper solution at the moment. (It's already in development, though.)
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: exynos4210: Work around lack of cpufreq regulator lookup
Date: Mon, 26 Aug 2013 19:13:28 +0200 [thread overview]
Message-ID: <2243476.800bKojdAz@amdc1227> (raw)
In-Reply-To: <1377020136-14838-1-git-send-email-t.figa@samsung.com>
On Tuesday 20 of August 2013 19:35:36 Tomasz Figa wrote:
> Exynos cpufreq drivers does not support device tree based regulator
> lookup, so it can get the VDD ARM regulator only by its name. To get
> cpufreq working for now, this patch works this around by renaming the
> regulator in board dts files to vdd_arm, which is the name expected by
> the driver.
>
> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/boot/dts/exynos4210-origen.dts | 7 ++++++-
> arch/arm/boot/dts/exynos4210-trats.dts | 7 ++++++-
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts
> b/arch/arm/boot/dts/exynos4210-origen.dts index 382d8c7..46378fe 100644
> --- a/arch/arm/boot/dts/exynos4210-origen.dts
> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
> @@ -192,7 +192,12 @@
> };
>
> buck1_reg: BUCK1 {
> - regulator-name = "VDD_ARM_1.2V";
> + /*
> + * HACK: The real name is VDD_ARM_1.2V,
> + * but exynos-cpufreq does not support
> + * DT-based regulator lookup yet.
> + */
> + regulator-name = "vdd_arm";
> regulator-min-microvolt = <950000>;
> regulator-max-microvolt = <1350000>;
> regulator-always-on;
> diff --git a/arch/arm/boot/dts/exynos4210-trats.dts
> b/arch/arm/boot/dts/exynos4210-trats.dts index 1c164f2..63cc571 100644
> --- a/arch/arm/boot/dts/exynos4210-trats.dts
> +++ b/arch/arm/boot/dts/exynos4210-trats.dts
> @@ -290,7 +290,12 @@
> };
>
> varm_breg: BUCK1 {
> - regulator-name = "VARM_1.2V_C210";
> + /*
> + * HACK: The real name is VARM_1.2V_C210,
> + * but exynos-cpufreq does not support
> + * DT-based regulator lookup yet.
> + */
> + regulator-name = "vdd_arm";
> regulator-min-microvolt = <900000>;
> regulator-max-microvolt = <1350000>;
> regulator-always-on;
Ping.
This patch fixes broken cpufreq on above two boards, so it would be nice to
have it merged for 3.12, even if it's a bit hacky, since it's too late for
proper solution at the moment. (It's already in development, though.)
Best regards,
Tomasz
next prev parent reply other threads:[~2013-08-26 17:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 17:35 [PATCH] ARM: dts: exynos4210: Work around lack of cpufreq regulator lookup Tomasz Figa
2013-08-20 17:35 ` Tomasz Figa
2013-08-26 17:13 ` Tomasz Figa [this message]
2013-08-26 17:13 ` Tomasz Figa
2013-09-25 14:10 ` [PATCH RESEND REGRESSION] " Tomasz Figa
2013-09-25 14:10 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2243476.800bKojdAz@amdc1227 \
--to=t.figa@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ian.campbell@citrix.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.