From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Colin King <colin.king@canonical.com>
Cc: linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: remove redundant assignment to ret
Date: Mon, 26 Aug 2019 09:20:21 +0000 [thread overview]
Message-ID: <2250924.CPEEF64KPg@kreacher> (raw)
In-Reply-To: <20190819065814.333kowws4mpw3qfx@vireshk-i7>
On Monday, August 19, 2019 8:58:14 AM CEST Viresh Kumar wrote:
> On 13-08-19, 13:21, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Variable ret is initialized to a value that is never read and it is
> > re-assigned later. The initialization is redundant and can be removed.
> >
> > Addresses-Coverity: ("Unused value")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/cpufreq/cpufreq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > index c28ebf2810f1..26d82e0a2de5 100644
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> > @@ -2140,7 +2140,7 @@ int cpufreq_driver_target(struct cpufreq_policy *policy,
> > unsigned int target_freq,
> > unsigned int relation)
> > {
> > - int ret = -EINVAL;
> > + int ret;
> >
> > down_write(&policy->rwsem);
> >
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
>
Patch applied, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Colin King <colin.king@canonical.com>
Cc: linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: remove redundant assignment to ret
Date: Mon, 26 Aug 2019 11:20:21 +0200 [thread overview]
Message-ID: <2250924.CPEEF64KPg@kreacher> (raw)
In-Reply-To: <20190819065814.333kowws4mpw3qfx@vireshk-i7>
On Monday, August 19, 2019 8:58:14 AM CEST Viresh Kumar wrote:
> On 13-08-19, 13:21, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Variable ret is initialized to a value that is never read and it is
> > re-assigned later. The initialization is redundant and can be removed.
> >
> > Addresses-Coverity: ("Unused value")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/cpufreq/cpufreq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > index c28ebf2810f1..26d82e0a2de5 100644
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> > @@ -2140,7 +2140,7 @@ int cpufreq_driver_target(struct cpufreq_policy *policy,
> > unsigned int target_freq,
> > unsigned int relation)
> > {
> > - int ret = -EINVAL;
> > + int ret;
> >
> > down_write(&policy->rwsem);
> >
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
>
Patch applied, thanks!
next prev parent reply other threads:[~2019-08-26 9:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 12:21 [PATCH] cpufreq: remove redundant assignment to ret Colin King
2019-08-13 12:21 ` Colin King
2019-08-19 6:58 ` Viresh Kumar
2019-08-19 6:58 ` Viresh Kumar
2019-08-26 9:20 ` Rafael J. Wysocki [this message]
2019-08-26 9:20 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2250924.CPEEF64KPg@kreacher \
--to=rjw@rjwysocki.net \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.